1*4882a593SmuzhiyunFrom f7a6df5f5bf3acc219352a1b25573ae2082d7e42 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Fabrice Fontaine <fontaine.fabrice@gmail.com> 3*4882a593SmuzhiyunDate: Thu, 3 Dec 2020 20:58:19 +0100 4*4882a593SmuzhiyunSubject: [PATCH] Fix build with 64 bits time_t 5*4882a593Smuzhiyun 6*4882a593Smuzhiyuntime element is deprecated on new input_event structure in kernel's 7*4882a593Smuzhiyuninput.h [1] 8*4882a593Smuzhiyun 9*4882a593SmuzhiyunThis will avoid the following build failure: 10*4882a593Smuzhiyun 11*4882a593Smuzhiyunhw/input/virtio-input-host.c: In function 'virtio_input_host_handle_status': 12*4882a593Smuzhiyunhw/input/virtio-input-host.c:198:28: error: 'struct input_event' has no member named 'time' 13*4882a593Smuzhiyun 198 | if (gettimeofday(&evdev.time, NULL)) { 14*4882a593Smuzhiyun | ^ 15*4882a593Smuzhiyun 16*4882a593SmuzhiyunFixes: 17*4882a593Smuzhiyun - http://autobuild.buildroot.org/results/a538167e288c14208d557cd45446df86d3d599d5 18*4882a593Smuzhiyun - http://autobuild.buildroot.org/results/efd4474fb4b6c0ce0ab3838ce130429c51e43bbb 19*4882a593Smuzhiyun 20*4882a593Smuzhiyun[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=152194fe9c3f 21*4882a593Smuzhiyun 22*4882a593SmuzhiyunSigned-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> 23*4882a593SmuzhiyunMessage-Id: <20201203195819.583626-1-fontaine.fabrice@gmail.com> 24*4882a593SmuzhiyunFixes: https://gitlab.com/qemu-project/qemu/-/issues/246 25*4882a593SmuzhiyunReviewed-by: Michael S. Tsirkin <mst@redhat.com> 26*4882a593SmuzhiyunSigned-off-by: Michael S. Tsirkin <mst@redhat.com> 27*4882a593Smuzhiyun 28*4882a593Smuzhiyun[Retrieved (and updated for qemu-xen) from: 29*4882a593Smuzhiyunhttps://github.com/qemu/qemu/commit/f7a6df5f5bf3acc219352a1b25573ae2082d7e42] 30*4882a593SmuzhiyunSigned-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> 31*4882a593Smuzhiyun--- 32*4882a593Smuzhiyun contrib/vhost-user-input/main.c | 8 ++++++-- 33*4882a593Smuzhiyun hw/input/virtio-input-host.c | 5 ++++- 34*4882a593Smuzhiyun 2 files changed, 10 insertions(+), 3 deletions(-) 35*4882a593Smuzhiyun 36*4882a593Smuzhiyundiff --git a/tools/qemu-xen/contrib/vhost-user-input/main.c b/tools/qemu-xen/contrib/vhost-user-input/main.c 37*4882a593Smuzhiyunindex c15d18c33f0c..081230da548a 100644 38*4882a593Smuzhiyun--- a/tools/qemu-xen/contrib/vhost-user-input/main.c 39*4882a593Smuzhiyun+++ b/tools/qemu-xen/contrib/vhost-user-input/main.c 40*4882a593Smuzhiyun@@ -6,13 +6,14 @@ 41*4882a593Smuzhiyun #include "qemu/osdep.h" 42*4882a593Smuzhiyun 43*4882a593Smuzhiyun #include <glib.h> 44*4882a593Smuzhiyun-#include <linux/input.h> 45*4882a593Smuzhiyun+#include <sys/ioctl.h> 46*4882a593Smuzhiyun 47*4882a593Smuzhiyun #include "qemu/iov.h" 48*4882a593Smuzhiyun #include "qemu/bswap.h" 49*4882a593Smuzhiyun #include "qemu/sockets.h" 50*4882a593Smuzhiyun #include "contrib/libvhost-user/libvhost-user.h" 51*4882a593Smuzhiyun #include "contrib/libvhost-user/libvhost-user-glib.h" 52*4882a593Smuzhiyun+#include "standard-headers/linux/input.h" 53*4882a593Smuzhiyun #include "standard-headers/linux/virtio_input.h" 54*4882a593Smuzhiyun #include "qapi/error.h" 55*4882a593Smuzhiyun 56*4882a593Smuzhiyun@@ -113,13 +114,16 @@ vi_evdev_watch(VuDev *dev, int condition, void *data) 57*4882a593Smuzhiyun static void vi_handle_status(VuInput *vi, virtio_input_event *event) 58*4882a593Smuzhiyun { 59*4882a593Smuzhiyun struct input_event evdev; 60*4882a593Smuzhiyun+ struct timeval tval; 61*4882a593Smuzhiyun int rc; 62*4882a593Smuzhiyun 63*4882a593Smuzhiyun- if (gettimeofday(&evdev.time, NULL)) { 64*4882a593Smuzhiyun+ if (gettimeofday(&tval, NULL)) { 65*4882a593Smuzhiyun perror("vi_handle_status: gettimeofday"); 66*4882a593Smuzhiyun return; 67*4882a593Smuzhiyun } 68*4882a593Smuzhiyun 69*4882a593Smuzhiyun+ evdev.input_event_sec = tval.tv_sec; 70*4882a593Smuzhiyun+ evdev.input_event_usec = tval.tv_usec; 71*4882a593Smuzhiyun evdev.type = le16toh(event->type); 72*4882a593Smuzhiyun evdev.code = le16toh(event->code); 73*4882a593Smuzhiyun evdev.value = le32toh(event->value); 74*4882a593Smuzhiyundiff --git a/tools/qemu-xen/hw/input/virtio-input-host.c b/tools/qemu-xen/hw/input/virtio-input-host.c 75*4882a593Smuzhiyunindex 85daf73f1a80..137efba57b0f 100644 76*4882a593Smuzhiyun--- a/tools/qemu-xen/hw/input/virtio-input-host.c 77*4882a593Smuzhiyun+++ b/tools/qemu-xen/hw/input/virtio-input-host.c 78*4882a593Smuzhiyun@@ -193,13 +193,16 @@ static void virtio_input_host_handle_status(VirtIOInput *vinput, 79*4882a593Smuzhiyun { 80*4882a593Smuzhiyun VirtIOInputHost *vih = VIRTIO_INPUT_HOST(vinput); 81*4882a593Smuzhiyun struct input_event evdev; 82*4882a593Smuzhiyun+ struct timeval tval; 83*4882a593Smuzhiyun int rc; 84*4882a593Smuzhiyun 85*4882a593Smuzhiyun- if (gettimeofday(&evdev.time, NULL)) { 86*4882a593Smuzhiyun+ if (gettimeofday(&tval, NULL)) { 87*4882a593Smuzhiyun perror("virtio_input_host_handle_status: gettimeofday"); 88*4882a593Smuzhiyun return; 89*4882a593Smuzhiyun } 90*4882a593Smuzhiyun 91*4882a593Smuzhiyun+ evdev.input_event_sec = tval.tv_sec; 92*4882a593Smuzhiyun+ evdev.input_event_usec = tval.tv_usec; 93*4882a593Smuzhiyun evdev.type = le16_to_cpu(event->type); 94*4882a593Smuzhiyun evdev.code = le16_to_cpu(event->code); 95*4882a593Smuzhiyun evdev.value = le32_to_cpu(event->value); 96