1*4882a593SmuzhiyunFrom 8656a0534fc8178138fa48ae1a165d43acd11a6f Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Jeffy Chen <jeffy.chen@rock-chips.com> 3*4882a593SmuzhiyunDate: Fri, 26 Nov 2021 09:38:19 +0800 4*4882a593SmuzhiyunSubject: [PATCH 17/17] gstreamer: Support choosing playbin2 and playbin3 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunNeither of them is perfect. 7*4882a593Smuzhiyun 8*4882a593SmuzhiyunThe playbin2 (decodebin2) cannot handle multiqueue overrun for some 9*4882a593Smuzhiyunbroken streams: 10*4882a593Smuzhiyunhttps://bugzilla.gnome.org/show_bug.cgi?id=775474 11*4882a593Smuzhiyun 12*4882a593SmuzhiyunThe playbin3 (decodebin3) might cause memory corruption or ghostpad 13*4882a593Smuzhiyunactivation deadlock in looping. 14*4882a593Smuzhiyun 15*4882a593SmuzhiyunSo let's support choosing them by setting QT_GSTREAMER_PLAYBIN env to 16*4882a593Smuzhiyunplaybin or playbin3. 17*4882a593Smuzhiyun 18*4882a593SmuzhiyunSigned-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> 19*4882a593Smuzhiyun--- 20*4882a593Smuzhiyun src/gsttools/qgstreamerplayersession.cpp | 2 +- 21*4882a593Smuzhiyun .../gstreamer/audiodecoder/qgstreameraudiodecodersession.cpp | 2 +- 22*4882a593Smuzhiyun 2 files changed, 2 insertions(+), 2 deletions(-) 23*4882a593Smuzhiyun 24*4882a593Smuzhiyundiff --git a/src/gsttools/qgstreamerplayersession.cpp b/src/gsttools/qgstreamerplayersession.cpp 25*4882a593Smuzhiyunindex b0a37f8..635b6e9 100755 26*4882a593Smuzhiyun--- a/src/gsttools/qgstreamerplayersession.cpp 27*4882a593Smuzhiyun+++ b/src/gsttools/qgstreamerplayersession.cpp 28*4882a593Smuzhiyun@@ -120,7 +120,7 @@ QGstreamerPlayerSession::QGstreamerPlayerSession(QObject *parent) 29*4882a593Smuzhiyun 30*4882a593Smuzhiyun void QGstreamerPlayerSession::initPlaybin() 31*4882a593Smuzhiyun { 32*4882a593Smuzhiyun- m_playbin = gst_element_factory_make(QT_GSTREAMER_PLAYBIN_ELEMENT_NAME, nullptr); 33*4882a593Smuzhiyun+ m_playbin = gst_element_factory_make(getenv("QT_GSTREAMER_PLAYBIN") ?: QT_GSTREAMER_PLAYBIN_ELEMENT_NAME, NULL); 34*4882a593Smuzhiyun if (m_playbin) { 35*4882a593Smuzhiyun //GST_PLAY_FLAG_NATIVE_VIDEO omits configuration of ffmpegcolorspace and videoscale, 36*4882a593Smuzhiyun //since those elements are included in the video output bin when necessary. 37*4882a593Smuzhiyundiff --git a/src/plugins/gstreamer/audiodecoder/qgstreameraudiodecodersession.cpp b/src/plugins/gstreamer/audiodecoder/qgstreameraudiodecodersession.cpp 38*4882a593Smuzhiyunindex d6b8ad7..6ad6849 100644 39*4882a593Smuzhiyun--- a/src/plugins/gstreamer/audiodecoder/qgstreameraudiodecodersession.cpp 40*4882a593Smuzhiyun+++ b/src/plugins/gstreamer/audiodecoder/qgstreameraudiodecodersession.cpp 41*4882a593Smuzhiyun@@ -91,7 +91,7 @@ QGstreamerAudioDecoderSession::QGstreamerAudioDecoderSession(QObject *parent) 42*4882a593Smuzhiyun m_durationQueries(0) 43*4882a593Smuzhiyun { 44*4882a593Smuzhiyun // Create pipeline here 45*4882a593Smuzhiyun- m_playbin = gst_element_factory_make(QT_GSTREAMER_PLAYBIN_ELEMENT_NAME, NULL); 46*4882a593Smuzhiyun+ m_playbin = gst_element_factory_make(getenv("QT_GSTREAMER_PLAYBIN") ?: QT_GSTREAMER_PLAYBIN_ELEMENT_NAME, NULL); 47*4882a593Smuzhiyun 48*4882a593Smuzhiyun if (m_playbin != 0) { 49*4882a593Smuzhiyun // Sort out messages 50*4882a593Smuzhiyun-- 51*4882a593Smuzhiyun2.20.1 52*4882a593Smuzhiyun 53