1*4882a593SmuzhiyunFrom 204898e28c7650089bf664eea8adfc16a22ba4f4 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Fabrice Fontaine <fontaine.fabrice@gmail.com> 3*4882a593SmuzhiyunDate: Tue, 6 Apr 2021 10:37:49 +0200 4*4882a593SmuzhiyunSubject: [PATCH] setup.py: fix build with gcc 4.8 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunFix the following build failure on gcc 4.8 which is raised since version 7*4882a593Smuzhiyun2.0.0 and 8*4882a593Smuzhiyunhttps://github.com/redis/hiredis-py/commit/9084152f624e8e593b4e86ddf8bd13329fdfc043: 9*4882a593Smuzhiyun 10*4882a593Smuzhiyunvendor/hiredis/read.c: In function 'redisReaderFree': 11*4882a593Smuzhiyunvendor/hiredis/read.c:646:9: error: 'for' loop initial declarations are only allowed in C99 mode 12*4882a593Smuzhiyun for (int i = 0; i < r->tasks; i++) { 13*4882a593Smuzhiyun ^ 14*4882a593Smuzhiyunvendor/hiredis/read.c:646:9: note: use option -std=c99 or -std=gnu99 to compile your code 15*4882a593Smuzhiyun 16*4882a593SmuzhiyunThis build failure is raised because hiredis source code is built 17*4882a593Smuzhiyunwithout C99: 18*4882a593Smuzhiyunhttps://github.com/redis/hiredis/commit/13a35bdb64615e381c5e1151cdd4e78bba71a6db 19*4882a593Smuzhiyun 20*4882a593SmuzhiyunFixes: 21*4882a593Smuzhiyun - http://autobuild.buildroot.org/results/04cbcddf6d83ebad8c98400754f9445375e9e489 22*4882a593Smuzhiyun 23*4882a593SmuzhiyunSigned-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> 24*4882a593Smuzhiyun[Upstream status: https://github.com/redis/hiredis-py/pull/110] 25*4882a593Smuzhiyun--- 26*4882a593Smuzhiyun setup.py | 1 + 27*4882a593Smuzhiyun 1 file changed, 1 insertion(+) 28*4882a593Smuzhiyun 29*4882a593Smuzhiyundiff --git a/setup.py b/setup.py 30*4882a593Smuzhiyunindex d83153b..1f623c9 100755 31*4882a593Smuzhiyun--- a/setup.py 32*4882a593Smuzhiyun+++ b/setup.py 33*4882a593Smuzhiyun@@ -13,6 +13,7 @@ def version(): 34*4882a593Smuzhiyun ext = Extension("hiredis.hiredis", 35*4882a593Smuzhiyun sources=sorted(glob.glob("src/*.c") + 36*4882a593Smuzhiyun ["vendor/hiredis/%s.c" % src for src in ("alloc", "read", "sds")]), 37*4882a593Smuzhiyun+ extra_compile_args=["-std=c99"], 38*4882a593Smuzhiyun include_dirs=["vendor"]) 39*4882a593Smuzhiyun 40*4882a593Smuzhiyun setup( 41*4882a593Smuzhiyun-- 42*4882a593Smuzhiyun2.30.2 43*4882a593Smuzhiyun 44