1*4882a593SmuzhiyunFrom a439daafdc98391eed13e23f93ecfca81d71c731 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Fabrice Fontaine <fontaine.fabrice@gmail.com> 3*4882a593SmuzhiyunDate: Mon, 2 Aug 2021 09:49:48 +0200 4*4882a593SmuzhiyunSubject: [PATCH] CMakeLists.txt: add UA_FORCE_WERROR 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunAllow the user to disable -Werror to avoid the following build failures: 7*4882a593Smuzhiyun 8*4882a593Smuzhiyun/tmp/instance-0/output-1/build/open62541-v1.2.2/arch/network_tcp.c: In function 'connection_recv': 9*4882a593Smuzhiyun/tmp/instance-0/output-1/build/open62541-v1.2.2/arch/network_tcp.c:96:5: error: conversion to 'unsigned int' from 'int' may change the sign of the result [-Werror=sign-conversion] 10*4882a593Smuzhiyun 96 | UA_fd_set(connection->sockfd, &fdset); 11*4882a593Smuzhiyun | ^~~~~~~~~ 12*4882a593Smuzhiyun 13*4882a593Smuzhiyun/tmp/instance-6/output-1/build/open62541-v1.2.2/plugins/ua_pubsub_udp.c: In function 'UA_PubSubChannelUDPMC_receive': 14*4882a593Smuzhiyun/tmp/instance-6/output-1/build/open62541-v1.2.2/plugins/ua_pubsub_udp.c:477:21: error: conversion to '__suseconds_t' {aka 'int'} from 'UA_UInt32' {aka 'unsigned int'} may change the sign of the result [-Werror=sign-conversion] 15*4882a593Smuzhiyun 477 | tmptv.tv_usec = (long int)(timeout % 1000000); 16*4882a593Smuzhiyun | ^ 17*4882a593Smuzhiyun 18*4882a593SmuzhiyunFixes: 19*4882a593Smuzhiyun - http://autobuild.buildroot.org/results/911811de81d8abb2a31feb8f27af1592641c6fbc 20*4882a593Smuzhiyun - http://autobuild.buildroot.org/results/f0187b3f2d62e955fddeef4e90f84ba4fd642bd2 21*4882a593Smuzhiyun 22*4882a593SmuzhiyunSigned-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> 23*4882a593Smuzhiyun[Upstream status: https://github.com/open62541/open62541/pull/4572] 24*4882a593Smuzhiyun--- 25*4882a593Smuzhiyun CMakeLists.txt | 6 +++++- 26*4882a593Smuzhiyun 1 file changed, 5 insertions(+), 1 deletion(-) 27*4882a593Smuzhiyun 28*4882a593Smuzhiyundiff --git a/CMakeLists.txt b/CMakeLists.txt 29*4882a593Smuzhiyunindex bc839f27..963460d0 100644 30*4882a593Smuzhiyun--- a/CMakeLists.txt 31*4882a593Smuzhiyun+++ b/CMakeLists.txt 32*4882a593Smuzhiyun@@ -292,6 +292,8 @@ if(UA_FORCE_CPP) 33*4882a593Smuzhiyun add_definitions(-D__STDC_CONSTANT_MACROS) # We need the UINT32_C define 34*4882a593Smuzhiyun endif() 35*4882a593Smuzhiyun 36*4882a593Smuzhiyun+option(UA_FORCE_WERROR "Force compilation with -Werror" ON) 37*4882a593Smuzhiyun+ 38*4882a593Smuzhiyun #General PubSub setup 39*4882a593Smuzhiyun option(UA_ENABLE_PUBSUB "Enable the PubSub protocol" OFF) 40*4882a593Smuzhiyun 41*4882a593Smuzhiyun@@ -589,7 +591,9 @@ if(NOT UA_FORCE_CPP AND (CMAKE_COMPILER_IS_GNUCC OR "x${CMAKE_C_COMPILER_ID}" ST 42*4882a593Smuzhiyun check_add_cc_flag("-Wall") # Warnings 43*4882a593Smuzhiyun check_add_cc_flag("-Wextra") # More warnings 44*4882a593Smuzhiyun check_add_cc_flag("-Wpedantic") # Standard compliance 45*4882a593Smuzhiyun- check_add_cc_flag("-Werror") # All warnings are errors 46*4882a593Smuzhiyun+ if(UA_FORCE_WERROR) 47*4882a593Smuzhiyun+ check_add_cc_flag("-Werror") # All warnings are errors 48*4882a593Smuzhiyun+ endif() 49*4882a593Smuzhiyun 50*4882a593Smuzhiyun check_add_cc_flag("-Wno-static-in-inline") # Clang doesn't like the use of static inline methods inside static inline methods 51*4882a593Smuzhiyun check_add_cc_flag("-Wno-overlength-strings") # May happen in the nodeset compiler when complex values are directly encoded 52*4882a593Smuzhiyun-- 53*4882a593Smuzhiyun2.30.2 54*4882a593Smuzhiyun 55