1*4882a593SmuzhiyunFrom 1557c3d919623a95c2aa090d3018c31401f63f88 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Tamar Christina <tamar.christina@arm.com> 3*4882a593SmuzhiyunDate: Fri, 21 May 2021 12:16:56 +0100 4*4882a593SmuzhiyunSubject: [PATCH] libsanitizer: Remove cyclades from libsanitizer 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunThe Linux kernel has removed the interface to cyclades from 7*4882a593Smuzhiyunthe latest kernel headers[1] due to them being orphaned for the 8*4882a593Smuzhiyunpast 13 years. 9*4882a593Smuzhiyun 10*4882a593Smuzhiyunlibsanitizer uses this header when compiling against glibc, but 11*4882a593Smuzhiyunglibcs itself doesn't seem to have any references to cyclades. 12*4882a593Smuzhiyun 13*4882a593SmuzhiyunFurther more it seems that the driver is broken in the kernel and 14*4882a593Smuzhiyunthe firmware doesn't seem to be available anymore. 15*4882a593Smuzhiyun 16*4882a593SmuzhiyunAs such since this is breaking the build of libsanitizer (and so the 17*4882a593SmuzhiyunGCC bootstrap[2]) I propose to remove this. 18*4882a593Smuzhiyun 19*4882a593Smuzhiyun[1] https://lkml.org/lkml/2021/3/2/153 20*4882a593Smuzhiyun[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100379 21*4882a593Smuzhiyun 22*4882a593Smuzhiyunlibsanitizer/ChangeLog: 23*4882a593Smuzhiyun 24*4882a593Smuzhiyun PR sanitizer/100379 25*4882a593Smuzhiyun * sanitizer_common/sanitizer_common_interceptors_ioctl.inc: Cherry-pick 26*4882a593Smuzhiyun llvm-project revision f7c5351552387bd43f6ca3631016d7f0dfe0f135. 27*4882a593Smuzhiyun * sanitizer_common/sanitizer_platform_limits_posix.cc: Likewise. 28*4882a593Smuzhiyun * sanitizer_common/sanitizer_platform_limits_posix.h: Likewise. 29*4882a593Smuzhiyun--- 30*4882a593Smuzhiyun .../sanitizer_common_interceptors_ioctl.inc | 9 --------- 31*4882a593Smuzhiyun .../sanitizer_platform_limits_posix.cpp | 11 ----------- 32*4882a593Smuzhiyun .../sanitizer_platform_limits_posix.h | 10 ---------- 33*4882a593Smuzhiyun 3 files changed, 30 deletions(-) 34*4882a593Smuzhiyun 35*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc b/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc 36*4882a593Smuzhiyunindex 490a04b2181..42e43a04441 100644 37*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc 38*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc 39*4882a593Smuzhiyun@@ -366,15 +366,6 @@ static void ioctl_table_fill() { 40*4882a593Smuzhiyun 41*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID 42*4882a593Smuzhiyun // _(SIOCDEVPLIP, WRITE, struct_ifreq_sz); // the same as EQL_ENSLAVE 43*4882a593Smuzhiyun- _(CYGETDEFTHRESH, WRITE, sizeof(int)); 44*4882a593Smuzhiyun- _(CYGETDEFTIMEOUT, WRITE, sizeof(int)); 45*4882a593Smuzhiyun- _(CYGETMON, WRITE, struct_cyclades_monitor_sz); 46*4882a593Smuzhiyun- _(CYGETTHRESH, WRITE, sizeof(int)); 47*4882a593Smuzhiyun- _(CYGETTIMEOUT, WRITE, sizeof(int)); 48*4882a593Smuzhiyun- _(CYSETDEFTHRESH, NONE, 0); 49*4882a593Smuzhiyun- _(CYSETDEFTIMEOUT, NONE, 0); 50*4882a593Smuzhiyun- _(CYSETTHRESH, NONE, 0); 51*4882a593Smuzhiyun- _(CYSETTIMEOUT, NONE, 0); 52*4882a593Smuzhiyun _(EQL_EMANCIPATE, WRITE, struct_ifreq_sz); 53*4882a593Smuzhiyun _(EQL_ENSLAVE, WRITE, struct_ifreq_sz); 54*4882a593Smuzhiyun _(EQL_GETMASTRCFG, WRITE, struct_ifreq_sz); 55*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp 56*4882a593Smuzhiyunindex aa845df4dde..badf6a401cc 100644 57*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp 58*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp 59*4882a593Smuzhiyun@@ -130,7 +130,6 @@ typedef struct user_fpregs elf_fpregset_t; 60*4882a593Smuzhiyun # include <sys/procfs.h> 61*4882a593Smuzhiyun #endif 62*4882a593Smuzhiyun #include <sys/user.h> 63*4882a593Smuzhiyun-#include <linux/cyclades.h> 64*4882a593Smuzhiyun #include <linux/if_eql.h> 65*4882a593Smuzhiyun #include <linux/if_plip.h> 66*4882a593Smuzhiyun #include <linux/lp.h> 67*4882a593Smuzhiyun@@ -443,7 +442,6 @@ unsigned struct_ElfW_Phdr_sz = sizeof(Elf_Phdr); 68*4882a593Smuzhiyun 69*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID 70*4882a593Smuzhiyun unsigned struct_ax25_parms_struct_sz = sizeof(struct ax25_parms_struct); 71*4882a593Smuzhiyun- unsigned struct_cyclades_monitor_sz = sizeof(struct cyclades_monitor); 72*4882a593Smuzhiyun #if EV_VERSION > (0x010000) 73*4882a593Smuzhiyun unsigned struct_input_keymap_entry_sz = sizeof(struct input_keymap_entry); 74*4882a593Smuzhiyun #else 75*4882a593Smuzhiyun@@ -809,15 +807,6 @@ unsigned struct_ElfW_Phdr_sz = sizeof(Elf_Phdr); 76*4882a593Smuzhiyun #endif // SANITIZER_LINUX 77*4882a593Smuzhiyun 78*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID 79*4882a593Smuzhiyun- unsigned IOCTL_CYGETDEFTHRESH = CYGETDEFTHRESH; 80*4882a593Smuzhiyun- unsigned IOCTL_CYGETDEFTIMEOUT = CYGETDEFTIMEOUT; 81*4882a593Smuzhiyun- unsigned IOCTL_CYGETMON = CYGETMON; 82*4882a593Smuzhiyun- unsigned IOCTL_CYGETTHRESH = CYGETTHRESH; 83*4882a593Smuzhiyun- unsigned IOCTL_CYGETTIMEOUT = CYGETTIMEOUT; 84*4882a593Smuzhiyun- unsigned IOCTL_CYSETDEFTHRESH = CYSETDEFTHRESH; 85*4882a593Smuzhiyun- unsigned IOCTL_CYSETDEFTIMEOUT = CYSETDEFTIMEOUT; 86*4882a593Smuzhiyun- unsigned IOCTL_CYSETTHRESH = CYSETTHRESH; 87*4882a593Smuzhiyun- unsigned IOCTL_CYSETTIMEOUT = CYSETTIMEOUT; 88*4882a593Smuzhiyun unsigned IOCTL_EQL_EMANCIPATE = EQL_EMANCIPATE; 89*4882a593Smuzhiyun unsigned IOCTL_EQL_ENSLAVE = EQL_ENSLAVE; 90*4882a593Smuzhiyun unsigned IOCTL_EQL_GETMASTRCFG = EQL_GETMASTRCFG; 91*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h 92*4882a593Smuzhiyunindex d82fd5e4005..dc6423bc297 100644 93*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h 94*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h 95*4882a593Smuzhiyun@@ -974,7 +974,6 @@ extern unsigned struct_vt_mode_sz; 96*4882a593Smuzhiyun 97*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID 98*4882a593Smuzhiyun extern unsigned struct_ax25_parms_struct_sz; 99*4882a593Smuzhiyun-extern unsigned struct_cyclades_monitor_sz; 100*4882a593Smuzhiyun extern unsigned struct_input_keymap_entry_sz; 101*4882a593Smuzhiyun extern unsigned struct_ipx_config_data_sz; 102*4882a593Smuzhiyun extern unsigned struct_kbdiacrs_sz; 103*4882a593Smuzhiyun@@ -1319,15 +1318,6 @@ extern unsigned IOCTL_VT_WAITACTIVE; 104*4882a593Smuzhiyun #endif // SANITIZER_LINUX 105*4882a593Smuzhiyun 106*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID 107*4882a593Smuzhiyun-extern unsigned IOCTL_CYGETDEFTHRESH; 108*4882a593Smuzhiyun-extern unsigned IOCTL_CYGETDEFTIMEOUT; 109*4882a593Smuzhiyun-extern unsigned IOCTL_CYGETMON; 110*4882a593Smuzhiyun-extern unsigned IOCTL_CYGETTHRESH; 111*4882a593Smuzhiyun-extern unsigned IOCTL_CYGETTIMEOUT; 112*4882a593Smuzhiyun-extern unsigned IOCTL_CYSETDEFTHRESH; 113*4882a593Smuzhiyun-extern unsigned IOCTL_CYSETDEFTIMEOUT; 114*4882a593Smuzhiyun-extern unsigned IOCTL_CYSETTHRESH; 115*4882a593Smuzhiyun-extern unsigned IOCTL_CYSETTIMEOUT; 116*4882a593Smuzhiyun extern unsigned IOCTL_EQL_EMANCIPATE; 117*4882a593Smuzhiyun extern unsigned IOCTL_EQL_ENSLAVE; 118*4882a593Smuzhiyun extern unsigned IOCTL_EQL_GETMASTRCFG; 119*4882a593Smuzhiyun-- 120*4882a593Smuzhiyun2.31.1 121*4882a593Smuzhiyun 122