1*4882a593SmuzhiyunFrom 29210b168cc458480f71b242ad964ecd79214e38 Mon Sep 17 00:00:00 2001
2*4882a593SmuzhiyunFrom: Tamar Christina <tamar.christina@arm.com>
3*4882a593SmuzhiyunDate: Fri, 21 May 2021 12:16:56 +0100
4*4882a593SmuzhiyunSubject: [PATCH] libsanitizer: Remove cyclades from libsanitizer
5*4882a593Smuzhiyun
6*4882a593SmuzhiyunThe Linux kernel has removed the interface to cyclades from
7*4882a593Smuzhiyunthe latest kernel headers[1] due to them being orphaned for the
8*4882a593Smuzhiyunpast 13 years.
9*4882a593Smuzhiyun
10*4882a593Smuzhiyunlibsanitizer uses this header when compiling against glibc, but
11*4882a593Smuzhiyunglibcs itself doesn't seem to have any references to cyclades.
12*4882a593Smuzhiyun
13*4882a593SmuzhiyunFurther more it seems that the driver is broken in the kernel and
14*4882a593Smuzhiyunthe firmware doesn't seem to be available anymore.
15*4882a593Smuzhiyun
16*4882a593SmuzhiyunAs such since this is breaking the build of libsanitizer (and so the
17*4882a593SmuzhiyunGCC bootstrap[2]) I propose to remove this.
18*4882a593Smuzhiyun
19*4882a593Smuzhiyun[1] https://lkml.org/lkml/2021/3/2/153
20*4882a593Smuzhiyun[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100379
21*4882a593Smuzhiyun
22*4882a593Smuzhiyunlibsanitizer/ChangeLog:
23*4882a593Smuzhiyun
24*4882a593Smuzhiyun	PR sanitizer/100379
25*4882a593Smuzhiyun	* sanitizer_common/sanitizer_common_interceptors_ioctl.inc: Cherry-pick
26*4882a593Smuzhiyun	llvm-project revision f7c5351552387bd43f6ca3631016d7f0dfe0f135.
27*4882a593Smuzhiyun	* sanitizer_common/sanitizer_platform_limits_posix.cc: Likewise.
28*4882a593Smuzhiyun	* sanitizer_common/sanitizer_platform_limits_posix.h: Likewise.
29*4882a593Smuzhiyun
30*4882a593SmuzhiyunSigned-off-by: Maxim Kochetkov <fido_max@inbox.ru>
31*4882a593Smuzhiyun---
32*4882a593Smuzhiyun .../sanitizer_common_interceptors_ioctl.inc           |  9 ---------
33*4882a593Smuzhiyun .../sanitizer_platform_limits_posix.cc                | 11 -----------
34*4882a593Smuzhiyun .../sanitizer_platform_limits_posix.h                 | 10 ----------
35*4882a593Smuzhiyun 3 files changed, 30 deletions(-)
36*4882a593Smuzhiyun
37*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc b/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc
38*4882a593Smuzhiyunindex a68534c5a0a..85ab53e7430 100755
39*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc
40*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc
41*4882a593Smuzhiyun@@ -361,15 +361,6 @@ static void ioctl_table_fill() {
42*4882a593Smuzhiyun
43*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID
44*4882a593Smuzhiyun   // _(SIOCDEVPLIP, WRITE, struct_ifreq_sz); // the same as EQL_ENSLAVE
45*4882a593Smuzhiyun-  _(CYGETDEFTHRESH, WRITE, sizeof(int));
46*4882a593Smuzhiyun-  _(CYGETDEFTIMEOUT, WRITE, sizeof(int));
47*4882a593Smuzhiyun-  _(CYGETMON, WRITE, struct_cyclades_monitor_sz);
48*4882a593Smuzhiyun-  _(CYGETTHRESH, WRITE, sizeof(int));
49*4882a593Smuzhiyun-  _(CYGETTIMEOUT, WRITE, sizeof(int));
50*4882a593Smuzhiyun-  _(CYSETDEFTHRESH, NONE, 0);
51*4882a593Smuzhiyun-  _(CYSETDEFTIMEOUT, NONE, 0);
52*4882a593Smuzhiyun-  _(CYSETTHRESH, NONE, 0);
53*4882a593Smuzhiyun-  _(CYSETTIMEOUT, NONE, 0);
54*4882a593Smuzhiyun   _(EQL_EMANCIPATE, WRITE, struct_ifreq_sz);
55*4882a593Smuzhiyun   _(EQL_ENSLAVE, WRITE, struct_ifreq_sz);
56*4882a593Smuzhiyun   _(EQL_GETMASTRCFG, WRITE, struct_ifreq_sz);
57*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
58*4882a593Smuzhiyunindex 5c720b2e700..17f2c78b389 100644
59*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
60*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
61*4882a593Smuzhiyun@@ -157,7 +157,6 @@ typedef struct user_fpregs elf_fpregset_t;
62*4882a593Smuzhiyun # include <sys/procfs.h>
63*4882a593Smuzhiyun #endif
64*4882a593Smuzhiyun #include <sys/user.h>
65*4882a593Smuzhiyun-#include <linux/cyclades.h>
66*4882a593Smuzhiyun #include <linux/if_eql.h>
67*4882a593Smuzhiyun #include <linux/if_plip.h>
68*4882a593Smuzhiyun #include <linux/lp.h>
69*4882a593Smuzhiyun@@ -464,7 +463,6 @@ unsigned struct_ElfW_Phdr_sz = sizeof(Elf_Phdr);
70*4882a593Smuzhiyun
71*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID
72*4882a593Smuzhiyun   unsigned struct_ax25_parms_struct_sz = sizeof(struct ax25_parms_struct);
73*4882a593Smuzhiyun-  unsigned struct_cyclades_monitor_sz = sizeof(struct cyclades_monitor);
74*4882a593Smuzhiyun #if EV_VERSION > (0x010000)
75*4882a593Smuzhiyun   unsigned struct_input_keymap_entry_sz = sizeof(struct input_keymap_entry);
76*4882a593Smuzhiyun #else
77*4882a593Smuzhiyun@@ -831,15 +829,6 @@ unsigned struct_ElfW_Phdr_sz = sizeof(Elf_Phdr);
78*4882a593Smuzhiyun #endif // SANITIZER_LINUX || SANITIZER_FREEBSD
79*4882a593Smuzhiyun
80*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID
81*4882a593Smuzhiyun-  unsigned IOCTL_CYGETDEFTHRESH = CYGETDEFTHRESH;
82*4882a593Smuzhiyun-  unsigned IOCTL_CYGETDEFTIMEOUT = CYGETDEFTIMEOUT;
83*4882a593Smuzhiyun-  unsigned IOCTL_CYGETMON = CYGETMON;
84*4882a593Smuzhiyun-  unsigned IOCTL_CYGETTHRESH = CYGETTHRESH;
85*4882a593Smuzhiyun-  unsigned IOCTL_CYGETTIMEOUT = CYGETTIMEOUT;
86*4882a593Smuzhiyun-  unsigned IOCTL_CYSETDEFTHRESH = CYSETDEFTHRESH;
87*4882a593Smuzhiyun-  unsigned IOCTL_CYSETDEFTIMEOUT = CYSETDEFTIMEOUT;
88*4882a593Smuzhiyun-  unsigned IOCTL_CYSETTHRESH = CYSETTHRESH;
89*4882a593Smuzhiyun-  unsigned IOCTL_CYSETTIMEOUT = CYSETTIMEOUT;
90*4882a593Smuzhiyun   unsigned IOCTL_EQL_EMANCIPATE = EQL_EMANCIPATE;
91*4882a593Smuzhiyun   unsigned IOCTL_EQL_ENSLAVE = EQL_ENSLAVE;
92*4882a593Smuzhiyun   unsigned IOCTL_EQL_GETMASTRCFG = EQL_GETMASTRCFG;
93*4882a593Smuzhiyundiff --git a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
94*4882a593Smuzhiyunindex 9c1429623ab..9f05c4e9ea7 100644
95*4882a593Smuzhiyun--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
96*4882a593Smuzhiyun+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
97*4882a593Smuzhiyun@@ -1004,7 +1004,6 @@ struct __sanitizer_cookie_io_functions_t {
98*4882a593Smuzhiyun
99*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID
100*4882a593Smuzhiyun   extern unsigned struct_ax25_parms_struct_sz;
101*4882a593Smuzhiyun-  extern unsigned struct_cyclades_monitor_sz;
102*4882a593Smuzhiyun   extern unsigned struct_input_keymap_entry_sz;
103*4882a593Smuzhiyun   extern unsigned struct_ipx_config_data_sz;
104*4882a593Smuzhiyun   extern unsigned struct_kbdiacrs_sz;
105*4882a593Smuzhiyun@@ -1349,15 +1348,6 @@ struct __sanitizer_cookie_io_functions_t {
106*4882a593Smuzhiyun #endif  // SANITIZER_LINUX || SANITIZER_FREEBSD
107*4882a593Smuzhiyun
108*4882a593Smuzhiyun #if SANITIZER_LINUX && !SANITIZER_ANDROID
109*4882a593Smuzhiyun-  extern unsigned IOCTL_CYGETDEFTHRESH;
110*4882a593Smuzhiyun-  extern unsigned IOCTL_CYGETDEFTIMEOUT;
111*4882a593Smuzhiyun-  extern unsigned IOCTL_CYGETMON;
112*4882a593Smuzhiyun-  extern unsigned IOCTL_CYGETTHRESH;
113*4882a593Smuzhiyun-  extern unsigned IOCTL_CYGETTIMEOUT;
114*4882a593Smuzhiyun-  extern unsigned IOCTL_CYSETDEFTHRESH;
115*4882a593Smuzhiyun-  extern unsigned IOCTL_CYSETDEFTIMEOUT;
116*4882a593Smuzhiyun-  extern unsigned IOCTL_CYSETTHRESH;
117*4882a593Smuzhiyun-  extern unsigned IOCTL_CYSETTIMEOUT;
118*4882a593Smuzhiyun   extern unsigned IOCTL_EQL_EMANCIPATE;
119*4882a593Smuzhiyun   extern unsigned IOCTL_EQL_ENSLAVE;
120*4882a593Smuzhiyun   extern unsigned IOCTL_EQL_GETMASTRCFG;
121*4882a593Smuzhiyun--
122*4882a593Smuzhiyun2.31.1
123*4882a593Smuzhiyun
124