1From 4a1aa5917595650efbd46b581368c470ebee42ab Mon Sep 17 00:00:00 2001
2From: Darren Kenny <darren.kenny@oracle.com>
3Date: Mon, 7 Dec 2020 14:44:47 +0000
4Subject: [PATCH] gfxmenu/gui_list: Remove code that coverity is flagging as
5 dead
6
7The test of value for NULL before calling grub_strdup() is not required,
8since the if condition prior to this has already tested for value being
9NULL and cannot reach this code if it is.
10
11Fixes: CID 73659
12
13Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
14Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
15Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
16---
17 grub-core/gfxmenu/gui_list.c | 2 +-
18 1 file changed, 1 insertion(+), 1 deletion(-)
19
20diff --git a/grub-core/gfxmenu/gui_list.c b/grub-core/gfxmenu/gui_list.c
21index 01477cd..df334a6 100644
22--- a/grub-core/gfxmenu/gui_list.c
23+++ b/grub-core/gfxmenu/gui_list.c
24@@ -771,7 +771,7 @@ list_set_property (void *vself, const char *name, const char *value)
25         {
26           self->need_to_recreate_boxes = 1;
27           grub_free (self->selected_item_box_pattern);
28-          self->selected_item_box_pattern = value ? grub_strdup (value) : 0;
29+          self->selected_item_box_pattern = grub_strdup (value);
30           self->selected_item_box_pattern_inherit = 0;
31         }
32     }
33--
342.14.2
35
36