1*4882a593SmuzhiyunFrom 4a1aa5917595650efbd46b581368c470ebee42ab Mon Sep 17 00:00:00 2001
2*4882a593SmuzhiyunFrom: Darren Kenny <darren.kenny@oracle.com>
3*4882a593SmuzhiyunDate: Mon, 7 Dec 2020 14:44:47 +0000
4*4882a593SmuzhiyunSubject: [PATCH] gfxmenu/gui_list: Remove code that coverity is flagging as
5*4882a593Smuzhiyun dead
6*4882a593Smuzhiyun
7*4882a593SmuzhiyunThe test of value for NULL before calling grub_strdup() is not required,
8*4882a593Smuzhiyunsince the if condition prior to this has already tested for value being
9*4882a593SmuzhiyunNULL and cannot reach this code if it is.
10*4882a593Smuzhiyun
11*4882a593SmuzhiyunFixes: CID 73659
12*4882a593Smuzhiyun
13*4882a593SmuzhiyunSigned-off-by: Darren Kenny <darren.kenny@oracle.com>
14*4882a593SmuzhiyunReviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
15*4882a593SmuzhiyunSigned-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
16*4882a593Smuzhiyun---
17*4882a593Smuzhiyun grub-core/gfxmenu/gui_list.c | 2 +-
18*4882a593Smuzhiyun 1 file changed, 1 insertion(+), 1 deletion(-)
19*4882a593Smuzhiyun
20*4882a593Smuzhiyundiff --git a/grub-core/gfxmenu/gui_list.c b/grub-core/gfxmenu/gui_list.c
21*4882a593Smuzhiyunindex 01477cd..df334a6 100644
22*4882a593Smuzhiyun--- a/grub-core/gfxmenu/gui_list.c
23*4882a593Smuzhiyun+++ b/grub-core/gfxmenu/gui_list.c
24*4882a593Smuzhiyun@@ -771,7 +771,7 @@ list_set_property (void *vself, const char *name, const char *value)
25*4882a593Smuzhiyun         {
26*4882a593Smuzhiyun           self->need_to_recreate_boxes = 1;
27*4882a593Smuzhiyun           grub_free (self->selected_item_box_pattern);
28*4882a593Smuzhiyun-          self->selected_item_box_pattern = value ? grub_strdup (value) : 0;
29*4882a593Smuzhiyun+          self->selected_item_box_pattern = grub_strdup (value);
30*4882a593Smuzhiyun           self->selected_item_box_pattern_inherit = 0;
31*4882a593Smuzhiyun         }
32*4882a593Smuzhiyun     }
33*4882a593Smuzhiyun--
34*4882a593Smuzhiyun2.14.2
35*4882a593Smuzhiyun
36