1*4882a593SmuzhiyunFrom 95bc016dba94cab3d398dd74160665915cd08ad6 Mon Sep 17 00:00:00 2001 2*4882a593SmuzhiyunFrom: Darren Kenny <darren.kenny@oracle.com> 3*4882a593SmuzhiyunDate: Thu, 26 Nov 2020 15:31:53 +0000 4*4882a593SmuzhiyunSubject: [PATCH] syslinux: Fix memory leak while parsing 5*4882a593Smuzhiyun 6*4882a593SmuzhiyunIn syslinux_parse_real() the 2 points where return is being called 7*4882a593Smuzhiyundidn't release the memory stored in buf which is no longer required. 8*4882a593Smuzhiyun 9*4882a593SmuzhiyunFixes: CID 176634 10*4882a593Smuzhiyun 11*4882a593SmuzhiyunSigned-off-by: Darren Kenny <darren.kenny@oracle.com> 12*4882a593SmuzhiyunReviewed-by: Daniel Kiper <daniel.kiper@oracle.com> 13*4882a593SmuzhiyunSigned-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> 14*4882a593Smuzhiyun--- 15*4882a593Smuzhiyun grub-core/lib/syslinux_parse.c | 6 +++++- 16*4882a593Smuzhiyun 1 file changed, 5 insertions(+), 1 deletion(-) 17*4882a593Smuzhiyun 18*4882a593Smuzhiyundiff --git a/grub-core/lib/syslinux_parse.c b/grub-core/lib/syslinux_parse.c 19*4882a593Smuzhiyunindex 4afa992..3acc6b4 100644 20*4882a593Smuzhiyun--- a/grub-core/lib/syslinux_parse.c 21*4882a593Smuzhiyun+++ b/grub-core/lib/syslinux_parse.c 22*4882a593Smuzhiyun@@ -737,7 +737,10 @@ syslinux_parse_real (struct syslinux_menu *menu) 23*4882a593Smuzhiyun && grub_strncasecmp ("help", ptr3, ptr4 - ptr3) == 0)) 24*4882a593Smuzhiyun { 25*4882a593Smuzhiyun if (helptext (ptr5, file, menu)) 26*4882a593Smuzhiyun- return 1; 27*4882a593Smuzhiyun+ { 28*4882a593Smuzhiyun+ grub_free (buf); 29*4882a593Smuzhiyun+ return 1; 30*4882a593Smuzhiyun+ } 31*4882a593Smuzhiyun continue; 32*4882a593Smuzhiyun } 33*4882a593Smuzhiyun 34*4882a593Smuzhiyun@@ -757,6 +760,7 @@ syslinux_parse_real (struct syslinux_menu *menu) 35*4882a593Smuzhiyun } 36*4882a593Smuzhiyun fail: 37*4882a593Smuzhiyun grub_file_close (file); 38*4882a593Smuzhiyun+ grub_free (buf); 39*4882a593Smuzhiyun return err; 40*4882a593Smuzhiyun } 41*4882a593Smuzhiyun 42*4882a593Smuzhiyun-- 43*4882a593Smuzhiyun2.14.2 44*4882a593Smuzhiyun 45