Searched hist:"575 c146962d3462172ce09075dc83022ec38dd7d" (Results 1 – 1 of 1) sorted by relevance
| /rk3399_ARM-atf/drivers/auth/ |
| H A D | auth_mod.c | 575c146962d3462172ce09075dc83022ec38dd7d Thu Nov 09 13:26:42 UTC 2023 Sandrine Bailleux <sandrine.bailleux@arm.com> refactor(auth): remove return_if_error() macro
The usage of this macro hinders the accuracy of code coverage
data. Lines of code calling this macro always appear as covered because
the test condition within it always gets executed; however, the branch
is not necessarily taken. Consequently, we lose branch coverage
information on these error code paths.
Besides, it is debatable whether such a simple macro really improves
code readability or on the contrary obfuscates the code...
For these reasons, this patch inlines the macro code everywhere it was
called.
It also adds some error messages in all these places to help narrowing
down authentication failures. These messages only get displayed and
compiled into the binaries when building TF-A with 'LOG_VERBOSE' level
of verbosity. We use the same message string everywhere in order to
limit the memory footprint increase for 'LOG_VERBOSE' builds.
Signed-off-by: Sandrine Bailleux <sandrine.bailleux@arm.com>
Change-Id: I461078bb8c6fd6811d2cbefbe3614e17e83796f2
|