1From 3886219c5c1fdca114dd480b46ce211762e30742 Mon Sep 17 00:00:00 2001
2From: Li Zhou <li.zhou@windriver.com>
3Date: Tue, 30 Jun 2020 13:50:11 +0800
4Subject: [PATCH] ptpd: Solve memory leak for function NTPDCrequest
5
6Solve the memory leak in function NTPDCrequest detected by valgrind tool.
7
8Memory leak log example:
9==619== 21 bytes in 1 blocks are still reachable in loss record 1 of 3
10==619==    at 0x4A09DB0: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
11==619==    by 0x43512E: NTPDCrequest (ntpdcontrol.c:255)
12==619==    by 0x43512E: NTPDCquery.isra.1 (ntpdcontrol.c:683)
13==619==    by 0x4359EE: ntpdInControl (ntpdcontrol.c:807)
14==619==    by 0x4364F5: ntpServiceUpdate (timingdomain.c:622)
15==619==    by 0x436935: timingDomainUpdate (timingdomain.c:756)
16==619==    by 0x4334A7: protocol (protocol.c:263)
17==619==    by 0x402BAE: main (ptpd.c:131)
18
19Upstream-Status: Pending
20
21Signed-off-by: Li Zhou <li.zhou@windriver.com>
22---
23 src/dep/ntpengine/ntpdcontrol.c | 1 +
24 1 file changed, 1 insertion(+)
25
26diff --git a/src/dep/ntpengine/ntpdcontrol.c b/src/dep/ntpengine/ntpdcontrol.c
27index bfe0b5e..b1973cb 100644
28--- a/src/dep/ntpengine/ntpdcontrol.c
29+++ b/src/dep/ntpengine/ntpdcontrol.c
30@@ -271,6 +271,7 @@ NTPDCrequest(
31
32 	if (!auth) {
33 		qpkt.auth_seq = AUTH_SEQ(0, 0);
34+		free(key);
35 		return ntpSend(control, (Octet *)&qpkt, req_pkt_size);
36 	}
37
38--
391.9.1
40
41