1From d3fbf09787b9dd8a061b541cd931ffbf63e4d610 Mon Sep 17 00:00:00 2001
2From: Khem Raj <raj.khem@gmail.com>
3Date: Wed, 12 Jan 2022 10:48:36 -0800
4Subject: [PATCH] apply const trick to ptr_to_globals
5
6This was missing in the previous attempt to fix it via [1]
7
8This helps fix segfaults when compiling with clang ( seen on riscv64 )
9
10[  452.428349] less[270]: unhandled signal 11 code 0x1 at 0x000000000000000c in busybox.nosuid[2ab7491000+ba000]
11[  452.430246] CPU: 3 PID: 270 Comm: less Not tainted 5.15.13-yocto-standard #1
12[  452.431323] Hardware name: riscv-virtio,qemu (DT)
13[  452.431925] epc : 0000002ab74a19ee ra : 0000002ab74a19dc sp : 0000003fec6ec980
14[  452.432725]  gp : 0000002ab754dcb0 tp : 0000003f88783800 t0 : 0000003f8878d4a0
15[  452.433744]  t1 : 0000002ab749b00c t2 : 0000000000000000 s0 : 0000003fec6ecc38
16[  452.434732]  s1 : 000000000000004c a0 : 00000000ffffffff a1 : 0000002ab754dde0
17[  452.435861]  a2 : 0000000000000000 a3 : 0000000000000100 a4 : 0000002ab754f3a0
18[  452.436787]  a5 : 0000002ab754f3a0 a6 : 0000000000000000 a7 : 0000002ab754f2a0
19[  452.437974]  s2 : 0000000000000002 s3 : 0000002ab754b6c8 s4 : 0000002ab749b60e
20[  452.438781]  s5 : 0000000000000000 s6 : 0000002ab754b6c8 s7 : 0000003f88943060
21[  452.439723]  s8 : 0000003f88944050 s9 : 0000002ad8502e88 s10: 0000002ad8502de8
22[  452.440538]  s11: 0000000000000014 t3 : 0000003f887fceb6 t4 : 0000003f8893af0c
23[  452.441438]  t5 : 0000000000000000 t6 : 0000003f88923000
24
25[1] https://git.busybox.net/busybox/commit/?id=1f925038a
26
27Upstream-Status: Submitted [http://lists.busybox.net/pipermail/busybox/2022-January/089413.html]
28Signed-off-by: Khem Raj <raj.khem@gmail.com>
29---
30 include/libbb.h | 2 +-
31 1 file changed, 1 insertion(+), 1 deletion(-)
32
33diff --git a/include/libbb.h b/include/libbb.h
34index a487828..7b76335 100644
35--- a/include/libbb.h
36+++ b/include/libbb.h
37@@ -2281,7 +2281,7 @@ struct globals;
38 /* '*const' ptr makes gcc optimize code much better.
39  * Magic prevents ptr_to_globals from going into rodata.
40  * If you want to assign a value, use SET_PTR_TO_GLOBALS(x) */
41-extern struct globals *const ptr_to_globals;
42+extern struct globals *BB_GLOBAL_CONST ptr_to_globals;
43
44 #define barrier() asm volatile ("":::"memory")
45
46--
472.34.1
48
49