Home
last modified time | relevance | path

Searched hist:cfada897a5c8585742c1c5becfaef42879722877 (Results 1 – 2 of 2) sorted by relevance

/optee_os/core/drivers/
H A Dstm32_bsec.ccfada897a5c8585742c1c5becfaef42879722877 Mon Sep 06 15:11:07 UTC 2021 Alexandru Gagniuc <mr.nuke.me@gmail.com> plat-stm32mp1: Don't call get_embedded_dt() without CFG_EMBED_DT

Several pieces of stm32mp1 code call get_embedded_dt(), then use the
resulting pointer without checks, or initiate a panic if it is NULL.
Thus hitting this code results in a non-working binary. For example:

"PLATFORM=stm32mp1 CFG_DT=y"

The get_embedded_dt() uses were #ifdef'd out based on CFG_DT. However,
as shown, this is problematic, as the calls assumed a valid fdt must
be returned. A non-NULL fdt can be guaranteed with CFG_EMBED_DT, so
use this as the basis for the #ifdefs.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
/optee_os/core/arch/arm/plat-stm32mp1/
H A Dmain.ccfada897a5c8585742c1c5becfaef42879722877 Mon Sep 06 15:11:07 UTC 2021 Alexandru Gagniuc <mr.nuke.me@gmail.com> plat-stm32mp1: Don't call get_embedded_dt() without CFG_EMBED_DT

Several pieces of stm32mp1 code call get_embedded_dt(), then use the
resulting pointer without checks, or initiate a panic if it is NULL.
Thus hitting this code results in a non-working binary. For example:

"PLATFORM=stm32mp1 CFG_DT=y"

The get_embedded_dt() uses were #ifdef'd out based on CFG_DT. However,
as shown, this is problematic, as the calls assumed a valid fdt must
be returned. A non-NULL fdt can be guaranteed with CFG_EMBED_DT, so
use this as the basis for the #ifdefs.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>