Searched hist:a366cf931ded176e47e068087bddf0134b5a3fac (Results 1 – 2 of 2) sorted by relevance
| /rk3399_rockchip-uboot/arch/arm/mach-rockchip/ |
| H A D | boot_mode.c | a366cf931ded176e47e068087bddf0134b5a3fac Fri Nov 24 13:44:58 UTC 2017 Philipp Tomsich <philipp.tomsich@theobroma-systems.com> UPSTREAM: rockchip: fix turning off boot-mode via Kconfig
The ROCKCHIP_BOOT_MODE_REG option defaults to a hex value, so 0 will show as 0x0 if a default is provided and changed via Kconfig. However, it still will show as 0, if no default is given.
Consequently, the "is set to something other than 0" test in a Makefile is cumbersome. Instead this check can easily be performed in the C-code.
This removes the ifeq-check from mach-rockchip/Makefile, adds a matching #if-check to boot_mode.c and fixes resulting link issues (if boot_mode.o was not included due to the Makefile check) by defining a stub function (in case the functionality is not built in) for setup_boot_mode in boot_mode.c.
Fixes: e306779 (rockchip: make boot_mode related codes reused across all platforms) Change-Id: I5299469103d139a90b8c073779d872ef131c3b42 Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> (cherry picked from commit f07d76c00d1fe05baad1599d01d07a9226498923)
|
| H A D | Makefile | a366cf931ded176e47e068087bddf0134b5a3fac Fri Nov 24 13:44:58 UTC 2017 Philipp Tomsich <philipp.tomsich@theobroma-systems.com> UPSTREAM: rockchip: fix turning off boot-mode via Kconfig
The ROCKCHIP_BOOT_MODE_REG option defaults to a hex value, so 0 will show as 0x0 if a default is provided and changed via Kconfig. However, it still will show as 0, if no default is given.
Consequently, the "is set to something other than 0" test in a Makefile is cumbersome. Instead this check can easily be performed in the C-code.
This removes the ifeq-check from mach-rockchip/Makefile, adds a matching #if-check to boot_mode.c and fixes resulting link issues (if boot_mode.o was not included due to the Makefile check) by defining a stub function (in case the functionality is not built in) for setup_boot_mode in boot_mode.c.
Fixes: e306779 (rockchip: make boot_mode related codes reused across all platforms) Change-Id: I5299469103d139a90b8c073779d872ef131c3b42 Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> (cherry picked from commit f07d76c00d1fe05baad1599d01d07a9226498923)
|