Searched hist:"54 d68e9333ff65d135faac68fa01be4276f1371f" (Results 1 – 1 of 1) sorted by relevance
| /rk3399_rockchip-uboot/fs/ext4/ |
| H A D | ext4_common.c | 54d68e9333ff65d135faac68fa01be4276f1371f Wed Nov 18 17:42:53 UTC 2015 Thomas Fitzsimmons <fitzsim@cisco.com> fs: ext4: Prevent infinite loop in ext4fs_iterate_dir
If the ext3 journal gets out of sync with what is written on disk, for
example because of an unexpected power cut, ext4fs_read_file can
return an all-zero directory entry. In that case, ext4fs_iterate_dir
would infinite loop.
This patch detects when a directory entry's direntlen member is 0 and
returns a failure status, which breaks out of the infinite loop. As a
result, U-Boot will not find files that may subsequently be recovered
when the journal is replayed.
This is better behaviour than hanging in an infinite loop, but as a
further improvement maybe U-Boot could interpret the ext3 journal and
actually find the unsynced entries.
Signed-off-by: Thomas Fitzsimmons <fitzsim@cisco.com>
Reviewed-by: Stefan Roese <sr@denx.de>
|