Changes in Makefile

b5deac9a5cf05a421cd1b72c4a369efe471b53b6 - Merge changes from topic "comp_build_macro" into integration

Mon, 27 Oct 2025 10:36:51 +0000

Merge changes from topic "comp_build_macro" into integration* changes: feat(build): setting CRYPTO_LIB via CRYPTO_SUPPORT feat(build): set CRYPTO_SUPPORT macro per BL feat(build): create define macro to be used by BL List of files: /rk3399_ARM-atf/lib/romlib/Makefile

6e2fe623fbbf299b4584bc202520f60955633077 - feat(build): set CRYPTO_SUPPORT macro per BL

Fri, 06 Jun 2025 20:15:24 +0000

feat(build): set CRYPTO_SUPPORT macro per BLMoving the setting of CRYPTO_SUPPORT from the main Makefile toindividual component makefiles using the new build macromake_defines for each BL-specific CPPFLAGS.Rework romlib build command to use CRYPTO_LIB to determine mbedtls needinstead of CRYPTO_SUPPORT. If CRYPTO_SUPPORT is set for any component,then CRYPTO_LIB will be filled, romlib can use this instead.Add a convenience makefile macro for setting CRYPTO_SUPPORT fromcomponent specific makefiles, have components call the macro based onwhether authenication verification (NEED_AUTH) and/or hash calculation(NEED_HASH) is required for the specific boot stage.Signed-off-by: Lauren Wehrmeister Change-Id: I7e81fede74fb9c04694b022e8eebed460616565c List of files: /rk3399_ARM-atf/lib/romlib/Makefile

249fb06c3df6cd40ff2566f29c672366c0f0f863 - Merge "refactor(build): avoid implicit pattern rules" into integration

Thu, 09 Oct 2025 12:51:30 +0000

Merge "refactor(build): avoid implicit pattern rules" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

a4ac07c7a553b00a48219823e543c96828c99186 - refactor(build): avoid implicit pattern rules

Tue, 04 Jun 2024 11:56:00 +0000

refactor(build): avoid implicit pattern rulesThis change translates any implicit pattern rules into the equivalentstatic pattern rules, i.e. rules like: %.o: %.s ...... become: $(OBJS): %.o: %.s ...These behave similarly, but have some subtle differences. The formerdefines a rule "for any target matching %.o where there is not a morespecific rule", whereas the latter defines a rule "for these targets,which match %.o".Where possible it is better to use a static pattern rule as it reducesthe rule space that Make needs to search.Change-Id: Ifba4f44bcecf4e74980c31347e192cdf1e42003eSigned-off-by: Chris Kay List of files: /rk3399_ARM-atf/lib/romlib/Makefile

7c375410723deeb345cdb5ff8499a8ad7420102d - Merge "feat(romlib): add PSA Crypto ROMLIB support" into integration

Thu, 27 Feb 2025 10:21:11 +0000

Merge "feat(romlib): add PSA Crypto ROMLIB support" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

cf1b7fe657a3215423ab397363cc4fa1a0e6399f - feat(romlib): add PSA Crypto ROMLIB support

Tue, 18 Feb 2025 20:48:45 +0000

feat(romlib): add PSA Crypto ROMLIB supportAdding PSA Crypto MBedTLS specific jump table to allow use of ROMLIB, tobe included when PSA_CRYPTO=1 and enabled.Signed-off-by: Lauren Wehrmeister Change-Id: Iff7f0e3c5cba6b89f1732f6c80d3060498e3675d List of files: /rk3399_ARM-atf/lib/romlib/Makefile

62ed5aa0b68a69abbd5fbfe6ab7fc7246fdefa38 - Merge "fix(romlib): romlib build without MbedTLS" into integration

Fri, 13 Dec 2024 11:16:47 +0000

Merge "fix(romlib): romlib build without MbedTLS" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

e4a070e3d6dd0af0e74184333b9238e70c9a7075 - fix(romlib): romlib build without MbedTLS

Tue, 03 Dec 2024 21:46:51 +0000

fix(romlib): romlib build without MbedTLSThe ROMLIB build currently has a strong dependency on MbedTLS. Thispatch has been introduced to remove this dependency, making it moreflexible.Change-Id: If8c4cc7cf557687f40b235a4b8f931cfb70943fdSigned-off-by: Manish V Badarkhe List of files: /rk3399_ARM-atf/lib/romlib/Makefile

f340f3d891b7184e1ab790955137d508b45a63cd - Merge changes Ibe44f19e,I9e023edb,I96d655fc into integration

Wed, 27 Nov 2024 10:32:45 +0000

Merge changes Ibe44f19e,I9e023edb,I96d655fc into integration* changes: build: use parameters in calls to `MAKE_DEP` build: disable suffix rules globally build: use full paths for generated libraries List of files: /rk3399_ARM-atf/lib/romlib/Makefile

6e6228181e8721ca9422cf4547ab1ff4c2ffd056 - build: use full paths for generated libraries

Tue, 03 Sep 2024 12:36:33 +0000

build: use full paths for generated librariesThis change modifies the build rules for static libraries so thatindividual rules which use those libraries depend directly on thearchive files that are generated, rather than their phony target aliasesand `-lX` link flags.The goal of this is to clean up Make's view of the dependencies betweenfiles, avoiding phony targets (which do not honour timestamps) makingtheir way into intermediate dependencies.Change-Id: I96d655fcd94dc259ffa6e8970b2be7b8c7e11123Signed-off-by: Chris Kay List of files: /rk3399_ARM-atf/lib/romlib/Makefile

ffbc2b90df22d9a744109a80dbb666ddddadbdb4 - Merge "fix(romlib): prevent race condition on the build directory" into integration

Wed, 06 Nov 2024 16:46:42 +0000

Merge "fix(romlib): prevent race condition on the build directory" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

e01bcfb02c91db5590a380258f8900e8865b4ec9 - Merge "build: fix grouped targets on Make <= 4.2" into integration

Mon, 04 Nov 2024 14:22:35 +0000

Merge "build: fix grouped targets on Make <= 4.2" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

25cde5f810422867bf03b2c0e8354dcee2493e8a - fix(romlib): prevent race condition on the build directory

Wed, 30 Oct 2024 09:56:27 +0000

fix(romlib): prevent race condition on the build directoryWhen building with many cores (-j64), there's a good chance that therule to make the build directory is getting executed at the same time asthe rule for romlib.ldflags. On my machine, the former is slower,resulting in romlib_generator.py not being able to write the file as thedirectory doesn't exist yet.Add an explicit dependency on the build directory for the target.This ensures that we have a build directory before we start puttingstuff in it.Change-Id: I120b0dc66c692c759ab1046c735be405b41db87cSigned-off-by: Boyan Karatotev List of files: /rk3399_ARM-atf/lib/romlib/Makefile

a57b94ec7ca5d201b4d88d54dcc69a53b35ec7c0 - build: fix grouped targets on Make <= 4.2

Tue, 06 Aug 2024 15:32:57 +0000

build: fix grouped targets on Make <= 4.2Grouped targets are a feature introduced with GNU Make 4.3 which enablerules with multiple targets to communicate that all of the targets ofthat rule are built simultaneously, rather than independently.For example, without grouped targets the following rule may be executedtwice: a.txt b.txt: touch a.txt b.txt # $ remake -j2 a.txt b.txt # touch a.txt b.txt # touch a.txt b.txtIn this example, both `a.txt` and `b.txt` are touched twice, when therule should only be executed once. Instead, this rule can use a groupedtarget: a.txt b.txt &: touch a.txt b.txt # $ remake -j2 a.txt b.txt # touch a.txt b.txt # remake: 'b.txt' is up to date.In this case, both `a.txt` and `b.txt` are created once only, as Makenow knows that the recipe will create both files.Note that pattern rules with multiple targets always behave this way.Previously, we assumed that the grouped target feature was available,but on systems still packaging Make 4.2, most prominently Ubuntu 20.04,this is not the case. This change adds a check to ensure that we do notuse grouped targets if they are unavailable.Change-Id: Ifd9da35421ae11468d7a25d3cbc76f6036921749Signed-off-by: Chris Kay List of files: /rk3399_ARM-atf/lib/romlib/Makefile

1297a45d6ad8ff49b875fc60645d9c46ed099514 - Merge changes from topic "dynamic-toolchain" into integration

Wed, 25 Sep 2024 11:53:54 +0000

Merge changes from topic "dynamic-toolchain" into integration* changes: build: allow multiple toolchain defaults build: determine toolchain tools dynamically List of files: /rk3399_ARM-atf/lib/romlib/Makefile

3789c3c0009028bd7730c6cead64ef3f7d071bd6 - build: determine toolchain tools dynamically

Mon, 03 Jun 2024 11:10:11 +0000

build: determine toolchain tools dynamicallySince the introduction of the toolchain detection framework into thebuild system, we have done determination and identification of thetoolchain(s) used for the build at the initialization of the buildsystem.This incurs a large cost to the build every time - for every toolchainthat has been requested by the current makefile, we try to identify eachtool in the list of known tool classes, even if that tool doesn'tactually see any use.For the clean and check-like targets we worked around this by disablingmost of the toolchains if we detect these targets, but this isinflexible and not very reliable, and it still means that when buildingnormal targets we are incurring that cost for all tools whether they areused or not.This change instead modifies the toolchain detection framework to onlyinitialize a tool for a given toolchain when it is first used. This doesmean that we can no longer warn about an incorrectly-configuredtoolchain at the beginning of build system invocation, but it has theadvantage of substantially reducing build time and the complexity of*using* the framework (at the cost of an increase in complexity in theframework itself).Change-Id: I7f3d06b2eb58c1b26a846791a13b0037f32c8013Signed-off-by: Chris Kay List of files: /rk3399_ARM-atf/lib/romlib/Makefile

2d4f264ba5ffd8a08c99f54c02a103ca7c8ffa78 - Merge changes from topic "romlib-fixes" into integration

Sat, 17 Aug 2024 08:09:06 +0000

Merge changes from topic "romlib-fixes" into integration* changes: fix(romlib): wrap indirectly included functions fix(arm): remove duplicate jumptable entry List of files: /rk3399_ARM-atf/lib/romlib/Makefile

d95d56bd2bfc87951f35d2badde9db336c0a6489 - fix(romlib): wrap indirectly included functions

Mon, 22 Jul 2024 17:55:43 +0000

fix(romlib): wrap indirectly included functionsThe problem that this resolves is a bit involved; the followingmust be met at the same time for some function : * to_be_wrapped must be specified as part of the romlib * to_be_wrapped must _not_ be referenced by any translation unit in TF-A * to_be_wrapped must be referenced by a translation unit in a dependent library, mbedtls for example.Under these circumstances, to_be_wrapped will not be wrapped, andwill instead reference its original definition while simultaneouslyresiding in romlib.This is a side effect of two issues with romlib prior to this patch: 1 to_be_wrapped is expected to wrap by duplicating its definition. This causes any condition that links against both the base and wrapper functions to be a link error (duplicate symbol definition). 2 to_be_wrapped is in its own translation unit This causes the wrappers to be used by TF-A in an as needed.The duplicate function definitions can be worked around using thelinker's `--wrap` flag, which redirects all references to a symbolto resolve to `__wrap_` and the original symbol to beavailable as `__real_`. Most of the changes handle creatingthis arguments and passing them to the linker.Further, once you use the linker's wrap, you will encounter anotherissue: if TF-A does not use a function, its wrapper is not present.This causes link issues when a library and not TF-A uses the wrapper.Note that this issue would have been resolved previously by ignoringthe wrapper and using the base definition.This further issue is worked around by concatenating the assembly forall of the wrappers into a single translation unit. It's possible towork around this issue in a few other ways, including reordering thelibraries passed to the linker to place libwrapper.a last or groupingthe libraries so that symbols from later libraries may be resolvedwith prior libraries.I chose the translation unit concatenation approach as it revealedthat a jumptable has duplicate symbols within it.Change-Id: Ie57b5ae69bde2fc8705bdc7a93fae3ddb5341ed9Signed-off-by: Jimmy Brisson List of files: /rk3399_ARM-atf/lib/romlib/Makefile

0195bac19b9d150a138bb3eeb2b9d4d4f5097cbd - Merge "build: consolidate directory creation rules" into integration

Mon, 29 Jul 2024 13:54:46 +0000

Merge "build: consolidate directory creation rules" into integration List of files: /rk3399_ARM-atf/lib/romlib/Makefile

f4dd18c270c0a171c1c4a04b1c7e886516ccd235 - build: consolidate directory creation rules

Tue, 04 Jun 2024 00:04:48 +0000

build: consolidate directory creation rulesThis commit streamlines directory creation by introducing a singlepattern rule to automatically make directories for which there is adependency.We currently use several macros to generate rules to create directoriesupon dependence, which is a significant amount of code and a lot ofredundancy. The rule introduced by this change represents a catch-all:any rule dependency on a path ending in a forward slash is automaticallycreated.Now, rules can rely on an unordered dependency (`|`) on `$$(@D)/` which,when secondary expansion is enabled, expands to the directory of thetarget being built, e.g.: build/main.o: main.c | $$(@D)/ # automatically creates `build/`Change-Id: I7e554efa2ac850e779bb302fd9c7fbb239886c9fSigned-off-by: Chris Kay List of files: /rk3399_ARM-atf/lib/romlib/Makefile