Lines Matching +full:invert +full:- +full:interrupt
1 // SPDX-License-Identifier: GPL-2.0-only
17 #include <linux/interrupt.h>
119 { "irq-gpios", &pca953x_irq_gpios, 1, ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER },
131 ret = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(dev), "irq-gpios", 0); in pca953x_acpi_get_irq()
135 dev_info(dev, "ACPI interrupt quirk (IRQ %d)\n", ret); in pca953x_acpi_get_irq()
145 * relative. Since first controller (gpio-sch.c) and
146 * second (gpio-dwapb.c) are at the fixed bases, we may
168 #define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ)
174 int invert; member
181 .invert = PCA953X_INVERT,
188 .invert = PCA957X_INVRT,
217 return fls((chip->gpio_chip.ngpio - 1) / BANK_SZ); in pca953x_bank_shift()
240 * - Standard set, below 0x40, each port can be replicated up to 8 times
241 * - PCA953x standard
246 * - PCA957x with mixed up registers
253 * - Extended set, above 0x40, often chip specific.
254 * - PCAL6524/PCAL9555A with custom PCAL IRQ handling:
256 * Pull-up/pull-down enable reg 0x40 + 3 * bank_size RW
257 * Pull-up/pull-down select reg 0x40 + 4 * bank_size RW
258 * Interrupt mask register 0x40 + 5 * bank_size RW
259 * Interrupt status register 0x40 + 6 * bank_size R
261 * - Registers with bit 0x80 set, the AI bit
271 int offset = reg & (BIT(bank_shift) - 1); in pca953x_check_register()
275 if (!(chip->driver_data & PCA_PCAL)) in pca953x_check_register()
296 if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) { in pca953x_readable_register()
305 if (chip->driver_data & PCA_PCAL) { in pca953x_readable_register()
319 if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) { in pca953x_writeable_register()
327 if (chip->driver_data & PCA_PCAL) in pca953x_writeable_register()
340 if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) in pca953x_volatile_register()
345 if (chip->driver_data & PCA_PCAL) in pca953x_volatile_register()
402 ret = regmap_bulk_write(chip->regmap, regaddr, value, NBANK(chip)); in pca953x_write_regs()
404 dev_err(&chip->client->dev, "failed writing register\n"); in pca953x_write_regs()
417 ret = regmap_bulk_read(chip->regmap, regaddr, value, NBANK(chip)); in pca953x_read_regs()
419 dev_err(&chip->client->dev, "failed reading register\n"); in pca953x_read_regs()
432 u8 dirreg = pca953x_recalc_addr(chip, chip->regs->direction, off); in pca953x_gpio_direction_input()
436 mutex_lock(&chip->i2c_lock); in pca953x_gpio_direction_input()
437 ret = regmap_write_bits(chip->regmap, dirreg, bit, bit); in pca953x_gpio_direction_input()
438 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_direction_input()
446 u8 dirreg = pca953x_recalc_addr(chip, chip->regs->direction, off); in pca953x_gpio_direction_output()
447 u8 outreg = pca953x_recalc_addr(chip, chip->regs->output, off); in pca953x_gpio_direction_output()
451 mutex_lock(&chip->i2c_lock); in pca953x_gpio_direction_output()
453 ret = regmap_write_bits(chip->regmap, outreg, bit, val ? bit : 0); in pca953x_gpio_direction_output()
458 ret = regmap_write_bits(chip->regmap, dirreg, bit, 0); in pca953x_gpio_direction_output()
460 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_direction_output()
467 u8 inreg = pca953x_recalc_addr(chip, chip->regs->input, off); in pca953x_gpio_get_value()
472 mutex_lock(&chip->i2c_lock); in pca953x_gpio_get_value()
473 ret = regmap_read(chip->regmap, inreg, ®_val); in pca953x_gpio_get_value()
474 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_get_value()
484 u8 outreg = pca953x_recalc_addr(chip, chip->regs->output, off); in pca953x_gpio_set_value()
487 mutex_lock(&chip->i2c_lock); in pca953x_gpio_set_value()
488 regmap_write_bits(chip->regmap, outreg, bit, val ? bit : 0); in pca953x_gpio_set_value()
489 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_set_value()
495 u8 dirreg = pca953x_recalc_addr(chip, chip->regs->direction, off); in pca953x_gpio_get_direction()
500 mutex_lock(&chip->i2c_lock); in pca953x_gpio_get_direction()
501 ret = regmap_read(chip->regmap, dirreg, ®_val); in pca953x_gpio_get_direction()
502 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_get_direction()
519 mutex_lock(&chip->i2c_lock); in pca953x_gpio_get_multiple()
520 ret = pca953x_read_regs(chip, chip->regs->input, reg_val); in pca953x_gpio_get_multiple()
521 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_get_multiple()
525 bitmap_replace(bits, bits, reg_val, mask, gc->ngpio); in pca953x_gpio_get_multiple()
536 mutex_lock(&chip->i2c_lock); in pca953x_gpio_set_multiple()
537 ret = pca953x_read_regs(chip, chip->regs->output, reg_val); in pca953x_gpio_set_multiple()
541 bitmap_replace(reg_val, reg_val, bits, mask, gc->ngpio); in pca953x_gpio_set_multiple()
543 pca953x_write_regs(chip, chip->regs->output, reg_val); in pca953x_gpio_set_multiple()
545 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_set_multiple()
558 * pull-up/pull-down configuration requires PCAL extended in pca953x_gpio_set_pull_up_down()
561 if (!(chip->driver_data & PCA_PCAL)) in pca953x_gpio_set_pull_up_down()
562 return -ENOTSUPP; in pca953x_gpio_set_pull_up_down()
564 mutex_lock(&chip->i2c_lock); in pca953x_gpio_set_pull_up_down()
566 /* Configure pull-up/pull-down */ in pca953x_gpio_set_pull_up_down()
568 ret = regmap_write_bits(chip->regmap, pull_sel_reg, bit, bit); in pca953x_gpio_set_pull_up_down()
570 ret = regmap_write_bits(chip->regmap, pull_sel_reg, bit, 0); in pca953x_gpio_set_pull_up_down()
576 /* Disable/Enable pull-up/pull-down */ in pca953x_gpio_set_pull_up_down()
578 ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, 0); in pca953x_gpio_set_pull_up_down()
580 ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, bit); in pca953x_gpio_set_pull_up_down()
583 mutex_unlock(&chip->i2c_lock); in pca953x_gpio_set_pull_up_down()
599 return -ENOTSUPP; in pca953x_gpio_set_config()
607 gc = &chip->gpio_chip; in pca953x_setup_gpio()
609 gc->direction_input = pca953x_gpio_direction_input; in pca953x_setup_gpio()
610 gc->direction_output = pca953x_gpio_direction_output; in pca953x_setup_gpio()
611 gc->get = pca953x_gpio_get_value; in pca953x_setup_gpio()
612 gc->set = pca953x_gpio_set_value; in pca953x_setup_gpio()
613 gc->get_direction = pca953x_gpio_get_direction; in pca953x_setup_gpio()
614 gc->get_multiple = pca953x_gpio_get_multiple; in pca953x_setup_gpio()
615 gc->set_multiple = pca953x_gpio_set_multiple; in pca953x_setup_gpio()
616 gc->set_config = pca953x_gpio_set_config; in pca953x_setup_gpio()
617 gc->can_sleep = true; in pca953x_setup_gpio()
619 gc->base = chip->gpio_start; in pca953x_setup_gpio()
620 gc->ngpio = gpios; in pca953x_setup_gpio()
621 gc->label = dev_name(&chip->client->dev); in pca953x_setup_gpio()
622 gc->parent = &chip->client->dev; in pca953x_setup_gpio()
623 gc->owner = THIS_MODULE; in pca953x_setup_gpio()
624 gc->names = chip->names; in pca953x_setup_gpio()
634 clear_bit(hwirq, chip->irq_mask); in pca953x_irq_mask()
643 set_bit(hwirq, chip->irq_mask); in pca953x_irq_unmask()
652 atomic_inc(&chip->wakeup_path); in pca953x_irq_set_wake()
654 atomic_dec(&chip->wakeup_path); in pca953x_irq_set_wake()
656 return irq_set_irq_wake(chip->client->irq, on); in pca953x_irq_set_wake()
664 mutex_lock(&chip->irq_lock); in pca953x_irq_bus_lock()
675 if (chip->driver_data & PCA_PCAL) { in pca953x_irq_bus_sync_unlock()
676 /* Enable latch on interrupt-enabled inputs */ in pca953x_irq_bus_sync_unlock()
677 pca953x_write_regs(chip, PCAL953X_IN_LATCH, chip->irq_mask); in pca953x_irq_bus_sync_unlock()
679 bitmap_complement(irq_mask, chip->irq_mask, gc->ngpio); in pca953x_irq_bus_sync_unlock()
686 pca953x_read_regs(chip, chip->regs->direction, reg_direction); in pca953x_irq_bus_sync_unlock()
688 bitmap_or(irq_mask, chip->irq_trig_fall, chip->irq_trig_raise, gc->ngpio); in pca953x_irq_bus_sync_unlock()
689 bitmap_complement(reg_direction, reg_direction, gc->ngpio); in pca953x_irq_bus_sync_unlock()
690 bitmap_and(irq_mask, irq_mask, reg_direction, gc->ngpio); in pca953x_irq_bus_sync_unlock()
692 /* Look for any newly setup interrupt */ in pca953x_irq_bus_sync_unlock()
693 for_each_set_bit(level, irq_mask, gc->ngpio) in pca953x_irq_bus_sync_unlock()
694 pca953x_gpio_direction_input(&chip->gpio_chip, level); in pca953x_irq_bus_sync_unlock()
696 mutex_unlock(&chip->irq_lock); in pca953x_irq_bus_sync_unlock()
708 dev_err(&chip->client->dev, "irq %d: unsupported type %d\n", in pca953x_irq_set_type()
709 d->irq, type); in pca953x_irq_set_type()
710 return -EINVAL; in pca953x_irq_set_type()
713 assign_bit(hwirq, chip->irq_trig_fall, type & IRQ_TYPE_EDGE_FALLING); in pca953x_irq_set_type()
714 assign_bit(hwirq, chip->irq_trig_raise, type & IRQ_TYPE_EDGE_RISING); in pca953x_irq_set_type()
719 mutex_lock(&chip->i2c_lock); in pca953x_irq_set_type()
720 regmap_write_bits(chip->regmap, outreg, bit, bit); in pca953x_irq_set_type()
721 mutex_unlock(&chip->i2c_lock); in pca953x_irq_set_type()
732 clear_bit(hwirq, chip->irq_trig_raise); in pca953x_irq_shutdown()
733 clear_bit(hwirq, chip->irq_trig_fall); in pca953x_irq_shutdown()
738 struct gpio_chip *gc = &chip->gpio_chip; in pca953x_irq_pending()
746 if (chip->driver_data & PCA_PCAL) { in pca953x_irq_pending()
747 /* Read the current interrupt status from the device */ in pca953x_irq_pending()
752 /* Check latched inputs and clear interrupt status */ in pca953x_irq_pending()
753 ret = pca953x_read_regs(chip, chip->regs->input, cur_stat); in pca953x_irq_pending()
758 bitmap_replace(new_stat, chip->irq_trig_fall, chip->irq_trig_raise, cur_stat, gc->ngpio); in pca953x_irq_pending()
760 bitmap_and(pending, new_stat, trigger, gc->ngpio); in pca953x_irq_pending()
762 return !bitmap_empty(pending, gc->ngpio); in pca953x_irq_pending()
765 ret = pca953x_read_regs(chip, chip->regs->input, cur_stat); in pca953x_irq_pending()
770 pca953x_read_regs(chip, chip->regs->direction, reg_direction); in pca953x_irq_pending()
772 bitmap_copy(old_stat, chip->irq_stat, gc->ngpio); in pca953x_irq_pending()
774 bitmap_and(new_stat, cur_stat, reg_direction, gc->ngpio); in pca953x_irq_pending()
775 bitmap_xor(cur_stat, new_stat, old_stat, gc->ngpio); in pca953x_irq_pending()
776 bitmap_and(trigger, cur_stat, chip->irq_mask, gc->ngpio); in pca953x_irq_pending()
778 bitmap_copy(chip->irq_stat, new_stat, gc->ngpio); in pca953x_irq_pending()
780 if (bitmap_empty(trigger, gc->ngpio)) in pca953x_irq_pending()
783 bitmap_and(cur_stat, chip->irq_trig_fall, old_stat, gc->ngpio); in pca953x_irq_pending()
784 bitmap_and(old_stat, chip->irq_trig_raise, new_stat, gc->ngpio); in pca953x_irq_pending()
785 bitmap_or(new_stat, old_stat, cur_stat, gc->ngpio); in pca953x_irq_pending()
786 bitmap_and(pending, new_stat, trigger, gc->ngpio); in pca953x_irq_pending()
788 return !bitmap_empty(pending, gc->ngpio); in pca953x_irq_pending()
794 struct gpio_chip *gc = &chip->gpio_chip; in pca953x_irq_handler()
801 mutex_lock(&chip->i2c_lock); in pca953x_irq_handler()
803 mutex_unlock(&chip->i2c_lock); in pca953x_irq_handler()
808 for_each_set_bit(level, pending, gc->ngpio) { in pca953x_irq_handler()
809 int nested_irq = irq_find_mapping(gc->irq.domain, level); in pca953x_irq_handler()
812 dev_warn_ratelimited(gc->parent, "unmapped interrupt %d\n", level); in pca953x_irq_handler()
826 struct i2c_client *client = chip->client; in pca953x_irq_setup()
827 struct irq_chip *irq_chip = &chip->irq_chip; in pca953x_irq_setup()
834 ret = pca953x_acpi_get_irq(&client->dev); in pca953x_irq_setup()
836 client->irq = ret; in pca953x_irq_setup()
839 if (!client->irq) in pca953x_irq_setup()
842 if (irq_base == -1) in pca953x_irq_setup()
845 if (!(chip->driver_data & PCA_INT)) in pca953x_irq_setup()
848 ret = pca953x_read_regs(chip, chip->regs->input, irq_stat); in pca953x_irq_setup()
854 * interrupt. We have to rely on the previous read for in pca953x_irq_setup()
857 pca953x_read_regs(chip, chip->regs->direction, reg_direction); in pca953x_irq_setup()
858 bitmap_and(chip->irq_stat, irq_stat, reg_direction, chip->gpio_chip.ngpio); in pca953x_irq_setup()
859 mutex_init(&chip->irq_lock); in pca953x_irq_setup()
861 irq_chip->name = dev_name(&client->dev); in pca953x_irq_setup()
862 irq_chip->irq_mask = pca953x_irq_mask; in pca953x_irq_setup()
863 irq_chip->irq_unmask = pca953x_irq_unmask; in pca953x_irq_setup()
864 irq_chip->irq_set_wake = pca953x_irq_set_wake; in pca953x_irq_setup()
865 irq_chip->irq_bus_lock = pca953x_irq_bus_lock; in pca953x_irq_setup()
866 irq_chip->irq_bus_sync_unlock = pca953x_irq_bus_sync_unlock; in pca953x_irq_setup()
867 irq_chip->irq_set_type = pca953x_irq_set_type; in pca953x_irq_setup()
868 irq_chip->irq_shutdown = pca953x_irq_shutdown; in pca953x_irq_setup()
870 girq = &chip->gpio_chip.irq; in pca953x_irq_setup()
871 girq->chip = irq_chip; in pca953x_irq_setup()
873 girq->parent_handler = NULL; in pca953x_irq_setup()
874 girq->num_parents = 0; in pca953x_irq_setup()
875 girq->parents = NULL; in pca953x_irq_setup()
876 girq->default_type = IRQ_TYPE_NONE; in pca953x_irq_setup()
877 girq->handler = handle_simple_irq; in pca953x_irq_setup()
878 girq->threaded = true; in pca953x_irq_setup()
879 girq->first = irq_base; /* FIXME: get rid of this */ in pca953x_irq_setup()
881 ret = devm_request_threaded_irq(&client->dev, client->irq, in pca953x_irq_setup()
884 dev_name(&client->dev), chip); in pca953x_irq_setup()
886 dev_err(&client->dev, "failed to request irq %d\n", in pca953x_irq_setup()
887 client->irq); in pca953x_irq_setup()
898 struct i2c_client *client = chip->client; in pca953x_irq_setup()
900 if (client->irq && irq_base != -1 && (chip->driver_data & PCA_INT)) in pca953x_irq_setup()
901 dev_warn(&client->dev, "interrupt support not compiled in\n"); in pca953x_irq_setup()
907 static int device_pca95xx_init(struct pca953x_chip *chip, u32 invert) in device_pca95xx_init() argument
913 regaddr = pca953x_recalc_addr(chip, chip->regs->output, 0); in device_pca95xx_init()
914 ret = regcache_sync_region(chip->regmap, regaddr, in device_pca95xx_init()
915 regaddr + NBANK(chip) - 1); in device_pca95xx_init()
919 regaddr = pca953x_recalc_addr(chip, chip->regs->direction, 0); in device_pca95xx_init()
920 ret = regcache_sync_region(chip->regmap, regaddr, in device_pca95xx_init()
921 regaddr + NBANK(chip) - 1); in device_pca95xx_init()
926 if (invert) in device_pca95xx_init()
931 ret = pca953x_write_regs(chip, chip->regs->invert, val); in device_pca95xx_init()
936 static int device_pca957x_init(struct pca953x_chip *chip, u32 invert) in device_pca957x_init() argument
942 ret = device_pca95xx_init(chip, invert); in device_pca957x_init()
966 u32 invert = 0; in pca953x_probe() local
970 chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); in pca953x_probe()
972 return -ENOMEM; in pca953x_probe()
974 pdata = dev_get_platdata(&client->dev); in pca953x_probe()
976 irq_base = pdata->irq_base; in pca953x_probe()
977 chip->gpio_start = pdata->gpio_base; in pca953x_probe()
978 invert = pdata->invert; in pca953x_probe()
979 chip->names = pdata->names; in pca953x_probe()
983 chip->gpio_start = -1; in pca953x_probe()
987 * See if we need to de-assert a reset pin. in pca953x_probe()
989 * There is no known ACPI-enabled platforms that are in pca953x_probe()
993 reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", in pca953x_probe()
999 chip->client = client; in pca953x_probe()
1001 reg = devm_regulator_get(&client->dev, "vcc"); in pca953x_probe()
1003 return dev_err_probe(&client->dev, PTR_ERR(reg), "reg get err\n"); in pca953x_probe()
1007 dev_err(&client->dev, "reg en err: %d\n", ret); in pca953x_probe()
1010 chip->regulator = reg; in pca953x_probe()
1013 chip->driver_data = i2c_id->driver_data; in pca953x_probe()
1017 match = device_get_match_data(&client->dev); in pca953x_probe()
1019 ret = -ENODEV; in pca953x_probe()
1023 chip->driver_data = (uintptr_t)match; in pca953x_probe()
1028 pca953x_setup_gpio(chip, chip->driver_data & PCA_GPIO_MASK); in pca953x_probe()
1030 if (NBANK(chip) > 2 || PCA_CHIP_TYPE(chip->driver_data) == PCA957X_TYPE) { in pca953x_probe()
1031 dev_info(&client->dev, "using AI\n"); in pca953x_probe()
1034 dev_info(&client->dev, "using no AI\n"); in pca953x_probe()
1038 chip->regmap = devm_regmap_init_i2c(client, regmap_config); in pca953x_probe()
1039 if (IS_ERR(chip->regmap)) { in pca953x_probe()
1040 ret = PTR_ERR(chip->regmap); in pca953x_probe()
1044 regcache_mark_dirty(chip->regmap); in pca953x_probe()
1046 mutex_init(&chip->i2c_lock); in pca953x_probe()
1048 * In case we have an i2c-mux controlled by a GPIO provided by an in pca953x_probe()
1051 * subclass for chip->i2c_lock. in pca953x_probe()
1054 * false positives when the expander controlling the i2c-mux is on in pca953x_probe()
1060 * applied to all other i2c-controlled GPIO expanders (and potentially in pca953x_probe()
1061 * regmap-i2c). in pca953x_probe()
1063 lockdep_set_subclass(&chip->i2c_lock, in pca953x_probe()
1064 i2c_adapter_depth(client->adapter)); in pca953x_probe()
1070 if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) { in pca953x_probe()
1071 chip->regs = &pca953x_regs; in pca953x_probe()
1072 ret = device_pca95xx_init(chip, invert); in pca953x_probe()
1074 chip->regs = &pca957x_regs; in pca953x_probe()
1075 ret = device_pca957x_init(chip, invert); in pca953x_probe()
1084 ret = devm_gpiochip_add_data(&client->dev, &chip->gpio_chip, chip); in pca953x_probe()
1088 if (pdata && pdata->setup) { in pca953x_probe()
1089 ret = pdata->setup(client, chip->gpio_chip.base, in pca953x_probe()
1090 chip->gpio_chip.ngpio, pdata->context); in pca953x_probe()
1092 dev_warn(&client->dev, "setup failed, %d\n", ret); in pca953x_probe()
1098 regulator_disable(chip->regulator); in pca953x_probe()
1104 struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev); in pca953x_remove()
1108 if (pdata && pdata->teardown) { in pca953x_remove()
1109 ret = pdata->teardown(client, chip->gpio_chip.base, in pca953x_remove()
1110 chip->gpio_chip.ngpio, pdata->context); in pca953x_remove()
1112 dev_err(&client->dev, "teardown failed, %d\n", ret); in pca953x_remove()
1117 regulator_disable(chip->regulator); in pca953x_remove()
1133 regaddr = pca953x_recalc_addr(chip, chip->regs->direction, 0); in pca953x_regcache_sync()
1134 ret = regcache_sync_region(chip->regmap, regaddr, regaddr + NBANK(chip) - 1); in pca953x_regcache_sync()
1140 regaddr = pca953x_recalc_addr(chip, chip->regs->output, 0); in pca953x_regcache_sync()
1141 ret = regcache_sync_region(chip->regmap, regaddr, regaddr + NBANK(chip) - 1); in pca953x_regcache_sync()
1148 if (chip->driver_data & PCA_PCAL) { in pca953x_regcache_sync()
1150 ret = regcache_sync_region(chip->regmap, regaddr, in pca953x_regcache_sync()
1151 regaddr + NBANK(chip) - 1); in pca953x_regcache_sync()
1159 ret = regcache_sync_region(chip->regmap, regaddr, in pca953x_regcache_sync()
1160 regaddr + NBANK(chip) - 1); in pca953x_regcache_sync()
1176 mutex_lock(&chip->i2c_lock); in pca953x_suspend()
1177 regcache_cache_only(chip->regmap, true); in pca953x_suspend()
1178 mutex_unlock(&chip->i2c_lock); in pca953x_suspend()
1180 if (atomic_read(&chip->wakeup_path)) in pca953x_suspend()
1183 regulator_disable(chip->regulator); in pca953x_suspend()
1193 if (!atomic_read(&chip->wakeup_path)) { in pca953x_resume()
1194 ret = regulator_enable(chip->regulator); in pca953x_resume()
1201 mutex_lock(&chip->i2c_lock); in pca953x_resume()
1202 regcache_cache_only(chip->regmap, false); in pca953x_resume()
1203 regcache_mark_dirty(chip->regmap); in pca953x_resume()
1206 mutex_unlock(&chip->i2c_lock); in pca953x_resume()
1210 ret = regcache_sync(chip->regmap); in pca953x_resume()
1211 mutex_unlock(&chip->i2c_lock); in pca953x_resume()
1221 /* convenience to stop overlong match-table lines */