Revert "Fixed Build Failed - gcc 8.2.0"

This reverts commit c43947cfb1e6cbd1a4bdf163bec449cde8bdc777.

Merge pull request #38 from cmuellner/parser

parse_parameter: Continue parsing after 'mtdparts'.

Merge pull request #31 from KL-Yang/master

Fixed Build Failure - gcc 8.2.0

Fix compilation issue in split_item().

Recent compilers complain with the following message:

main.cpp: In function ‘void split_item(STRING_VECTOR&, char*)’:
main.cpp:2840:10: error: ‘char* strn

Fix compilation issue in split_item().

Recent compilers complain with the following message:

main.cpp: In function ‘void split_item(STRING_VECTOR&, char*)’:
main.cpp:2840:10: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length

This patch addresses this issue.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>

show more ...

parse_parameter: Continue parsing after 'mtdparts'.

The parse_paramter loop iterates over a parameter.txt file's contents
and parses that line-by-line. However, the current implementation
silently s

parse_parameter: Continue parsing after 'mtdparts'.

The parse_paramter loop iterates over a parameter.txt file's contents
and parses that line-by-line. However, the current implementation
silently stops after parsing 'mtdparts'. This is problematic if
a 'uuid' token is found in one of the following lines.

This patch addresses the problem, by simply continue to iterate
over the next lines after 'mtdparts'.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>

show more ...

Fixed Build Failed - gcc 8.2.0

ERROR:

main.cpp:2841:10: error: ‘char* strncpy(char*, const char*, size_t)’
output truncated before terminating nul copying as many bytes from
a string as its length

Fixed Build Failed - gcc 8.2.0

ERROR:

main.cpp:2841:10: error: ‘char* strncpy(char*, const char*, size_t)’
output truncated before terminating nul copying as many bytes from
a string as its length [-Werror=stringop-truncation]

Since the allocation is only 100*char, the reasonable fix would be
limit the strncpy to only (100-1)*char.

show more ...

Merge pull request #27 from gonzoua/freebsd_support

Fix iconv detection for FreeBSD

Fix iconv detection for FreeBSD

Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>

Merge pull request #19 from kgoger/pack_cmd_fix

Fix pack parsing

Merge pull request #23 from rtavs/master

rk3128: add rk3128 support

Merge pull request #26 from Ken-u/master

Adapt to CMake.

Adapt to CMake.

Test: build with OSX 10.11, use:
brew install libusb libiconv

Signed-off-by: BianJinChen <kenjc.bian@rock-chips.com>

rkdeveloptool: v1.3
1.add LD to list devices
2.add PRM to write parameter
3.change PGPT to PPT to support print parameter and GPT

Signed-off-by: liuyi <liuyi@rock-chips.com>

rk3128: add rk3128 support

Signed-off-by: Kaspter Ju <camus@rtavs.com>

Merge pull request #21 from owenchenww/master

rk3229: add 99-rk-rockusb.rules to run tool without sudo

rk3229: add 99-rk-rockusb.rules to run tool without sudo

Signed-off-by: Weiwen Chen <cww@rock-chips.com>

Fix pack parsing

The index needѕ to be incremented after a valid path was found. Otherwise
gOpts.loader[index].name will be out of of bound after the second
iteration.

Signed-off-by: Klaus Goger <k

Fix pack parsing

The index needѕ to be incremented after a valid path was found. Otherwise
gOpts.loader[index].name will be out of of bound after the second
iteration.

Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>

show more ...

Merge pull request #16 from kgoger/buildfixes

macos/openbsd fixes

fill cbwTransferLenght field with value during creating cbw

Signed-off-by: liuyi <liuyi@rock-chips.com>

wl to support sparse image

Signed-off-by: liuyi <liuyi@rock-chips.com>

rk303x: dd 99-rk-rockusb.rules to run tool without sudo

Signed-off-by: Caesar Wang <wxt@rock-chips.com>

cast emUsbType to uint when compared with uint

uiSupportType is type uint. emUsbType defaults to int.
A logical OR will result in a uint. Therefore cast emUsbType
to uint to prevent following error

cast emUsbType to uint when compared with uint

uiSupportType is type uint. emUsbType defaults to int.
A logical OR will result in a uint. Therefore cast emUsbType
to uint to prevent following error with clang on OpenBSD

cc1plus: warnings being treated as errors
main.cpp: In function 'bool check_device_type(STRUCT_RKDEVICE_DESC&, UINT)':
main.cpp:835: warning: comparison between signed and unsigned integer expressions
*** Error 1 in . (Makefile:461 'main.o')
*** Error 1 in /root/rkdeveloptool (Makefile:506 'all-recursive')

Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>

show more ...

use rm instead of $(RM) for clean targets

OpenBSD bsdmake does not define $(RM) like GNU Make.
As it's highly unlikely that anyone will ever want to override rm or has
as system where rm is not in t

use rm instead of $(RM) for clean targets

OpenBSD bsdmake does not define $(RM) like GNU Make.
As it's highly unlikely that anyone will ever want to override rm or has
as system where rm is not in the path, let us just use the command
directly for the sake of simplicity.

Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>

show more ...

Set CPPFLAGS and LDFLAGS for OpenBSD

On OpenBSD iconv headers were not found:

from gcc-local(1) on OpenBSD
gcc does not search under /usr/local for include files nor for
libraries: as a system

Set CPPFLAGS and LDFLAGS for OpenBSD

On OpenBSD iconv headers were not found:

from gcc-local(1) on OpenBSD
gcc does not search under /usr/local for include files nor for
libraries: as a system compiler, it only searches the system paths by
default.

Set CPPFLAGS and LDFLAGS based on os_host set by AC_CANONICAL_HOST.

Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>

show more ...

Search for iconv in configure script

macOS requires -liconv in the LDFLAGS to link correctly. So add a
search macro to the configure script to prevent following error:

g++ -g -O2 -o rkdeveloptoo

Search for iconv in configure script

macOS requires -liconv in the LDFLAGS to link correctly. So add a
search macro to the configure script to prevent following error:

g++ -g -O2 -o rkdeveloptool main.o crc.o RKBoot.o RKComm.o RKDevice.o
RKImage.o RKLog.o RKScan.o -L/usr/local/Cellar/libusb/1.0.21/lib -lusb-1.0
Undefined symbols for architecture x86_64:
"_iconv", referenced from:
StringToWideString(char*, wchar_t*&) in main.o
WideStringToString(wchar_t*, char*&) in main.o
"_iconv_close", referenced from:
StringToWideString(char*, wchar_t*&) in main.o
WideStringToString(wchar_t*, char*&) in main.o
"_iconv_open", referenced from:
StringToWideString(char*, wchar_t*&) in main.o
WideStringToString(wchar_t*, char*&) in main.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [rkdeveloptool] Error 1

show more ...