| e3fb0abe | 17-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
TFTP: rename STATE_RRQ to STATE_SEND_RRQ
With the upcoming TFTP server implementation, requests can be either outgoing or incoming, so avoid ambiguities.
Signed-off-by: Luca Ceresoli <luca.ceresoli
TFTP: rename STATE_RRQ to STATE_SEND_RRQ
With the upcoming TFTP server implementation, requests can be either outgoing or incoming, so avoid ambiguities.
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Acked-by: Detlev Zundel <dzu@denx.de>
show more ...
|
| 20478cea | 17-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
TFTP: replace "server" with "remote" in local variable names
With the upcoming TFTP server implementation, the remote node can be either a client or a server, so avoid ambiguities.
Signed-off-by: L
TFTP: replace "server" with "remote" in local variable names
With the upcoming TFTP server implementation, the remote node can be either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Acked-by: Detlev Zundel <dzu@denx.de>
show more ...
|
| 9bb0a1bf | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: do not initialise statics to 0 or NULL
This removes the following checkpatch issue: - ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Luca Ceresoli <luca.ceresol
net/tftp.c: cosmetic: do not initialise statics to 0 or NULL
This removes the following checkpatch issue: - ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| 0bdd8acc | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: fix indentation
This removes the following checkpatch issue: - WARNING: suspect code indent for conditional statements
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it>
net/tftp.c: cosmetic: fix indentation
This removes the following checkpatch issue: - WARNING: suspect code indent for conditional statements
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| 6d2231e8 | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: trailing statements should be on next line
This removes the following checkpatch issue: - ERROR: trailing statements should be on next line
Signed-off-by: Luca Ceresoli <luca
net/tftp.c: cosmetic: trailing statements should be on next line
This removes the following checkpatch issue: - ERROR: trailing statements should be on next line
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| 7bc325a1 | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: fix brace issues
This removes the following checkpatch issues: - WARNING: braces {} are not necessary for single statement blocks - WARNING: braces {} are not necessary for a
net/tftp.c: cosmetic: fix brace issues
This removes the following checkpatch issues: - WARNING: braces {} are not necessary for single statement blocks - WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| 2cb53608 | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: do not use assignment in if condition
This removes the following checkpatch issue: - ERROR: do not use assignment in if condition.
There is one such error left:
ERROR: do
net/tftp.c: cosmetic: do not use assignment in if condition
This removes the following checkpatch issue: - ERROR: do not use assignment in if condition.
There is one such error left:
ERROR: do not use assignment in if condition #239: FILE: tftp.c:239: + if (!ProhibitMcast + && (Bitmap = malloc(Mapsize)) + && eth_get_dev()->mcast) {
which would require an additional nested if to be fixed, resulting in longer and less readable code.
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| 2e320257 | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: fix pointer syntax issues
This removes the following checkpatch issues: - ERROR: "foo * bar" should be "foo *bar" - ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Luca C
net/tftp.c: cosmetic: fix pointer syntax issues
This removes the following checkpatch issues: - ERROR: "foo * bar" should be "foo *bar" - ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| c718b143 | 14-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/tftp.c: cosmetic: fix whitespace issues
This removes the following checkpatch issues: - ERROR: space prohibited before that close parenthesis ')' - ERROR: space required after that ';' (ctx:Bx
net/tftp.c: cosmetic: fix whitespace issues
This removes the following checkpatch issues: - ERROR: space prohibited before that close parenthesis ')' - ERROR: space required after that ';' (ctx:BxV) - ERROR: space required after that ',' (ctx:VxV) - ERROR: space required after that ';' (ctx:VxV) - ERROR: spaces required around that '<<=' (ctx:VxV) - ERROR: spaces required around that '<' (ctx:VxV) - ERROR: spaces required around that '=' (ctx:VxV) - ERROR: spaces required around that '+=' (ctx:VxV) - ERROR: spaces required around that '=' (ctx:VxW) - WARNING: please, no spaces at the start of a line - WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de>
show more ...
|
| ccb9ebef | 04-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: do not use assignment in if condition
This removes the following checkpatch issue: - ERROR: do not use assignment in if condition
Signed-off-by: Luca Ceresoli <luca.ceresoli@c
net/net.c: cosmetic: do not use assignment in if condition
This removes the following checkpatch issue: - ERROR: do not use assignment in if condition
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com>
show more ...
|
| c819abee | 04-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: fix indentation
This removes the following checkpatch issues: - ERROR: switch and case should be at the same indent - WARNING: suspect code indent for conditional statements
net/net.c: cosmetic: fix indentation
This removes the following checkpatch issues: - ERROR: switch and case should be at the same indent - WARNING: suspect code indent for conditional statements - WARNING: labels should not be indented
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com>
show more ...
|
| 92895de9 | 04-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: parentheses not required for return
This removes the following checkpatch issue: - ERROR: return is not a function, parentheses are not required
Signed-off-by: Luca Ceresoli <
net/net.c: cosmetic: parentheses not required for return
This removes the following checkpatch issue: - ERROR: return is not a function, parentheses are not required
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com>
show more ...
|
| 6b147d11 | 04-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: fix pointer syntax issues
This removes the following checkpatch issues: - ERROR: "foo * bar" should be "foo *bar" - ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Luca Ce
net/net.c: cosmetic: fix pointer syntax issues
This removes the following checkpatch issues: - ERROR: "foo * bar" should be "foo *bar" - ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com>
show more ...
|
| d3c65b01 | 04-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: fix brace issues
This removes the following checkpatch issues: - WARNING: braces {} are not necessary for single statement blocks - WARNING: braces {} are not necessary for an
net/net.c: cosmetic: fix brace issues
This removes the following checkpatch issues: - WARNING: braces {} are not necessary for single statement blocks - WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com>
show more ...
|
| 4f63acd0 | 11-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: fix whitespace issues
This removes the following checkpatch issues: - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close paren
net/net.c: cosmetic: fix whitespace issues
This removes the following checkpatch issues: - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' - ERROR: space prohibited after that open square bracket '[' - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: spaces required around that '=' (ctx:VxW) - ERROR: space required before the open parenthesis '(' - ERROR: space required after that ',' (ctx:VxV) - ERROR: need consistent spacing around '+' (ctx:WxV) - WARNING: unnecessary whitespace before a quoted newline - WARNING: please, no spaces at the start of a line - WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com> Cc: Mike Frysinger <vapier@gentoo.org>
show more ...
|
| c586ce6e | 11-May-2011 |
Luca Ceresoli <luca.ceresoli@comelit.it> |
net/net.c: cosmetic: variable initializations
This removes the following checkpatch errors: - ERROR: do not initialise globals to 0 or NULL - ERROR: spaces required around that '=' (ctx:VxV) - ER
net/net.c: cosmetic: variable initializations
This removes the following checkpatch errors: - ERROR: do not initialise globals to 0 or NULL - ERROR: spaces required around that '=' (ctx:VxV) - ERROR: that open brace { should be on the previous line
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it> Cc: Wolfgang Denk <wd@denx.de> Cc: Ben Warren <biggerbadderben@gmail.com> Cc: Mike Frysinger <vapier@gentoo.org>
show more ...
|