fastboot: fix compile warning

cb_flashing() should be in the same MACRO of cb_flash().

Change-Id: Ic5641a1bf1fb0ab53ad98bdececd028f1e75a5e2
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

treewide: replace with error() with pr_err()

U-Boot widely uses error() as a bit noisier variant of printf().

This macro causes name conflict with the following line in
include/linux/compiler-gcc.h

treewide: replace with error() with pr_err()

U-Boot widely uses error() as a bit noisier variant of printf().

This macro causes name conflict with the following line in
include/linux/compiler-gcc.h:

# define __compiletime_error(message) __attribute__((error(message)))

This prevents us from using __compiletime_error(), and makes it
difficult to fully sync BUILD_BUG macros with Linux. (Notice
Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)

Let's convert error() into now treewide-available pr_err().

Done with the help of Coccinelle, excluing tools/ directory.

The semantic patch I used is as follows:

// <smpl>
@@@@
-error
+pr_err
(...)
// </smpl>

Change-Id: I921807c1770d36a91e692c48ab477558bb2ed0b8
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
[trini: Re-run Coccinelle]
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
(cherry picked from commit 9b643e312d528f291966c1f30b0d90bf3b1d43dc)

show more ...

fastboot:support attestation commands

Change-Id: I984a107270991a9e9d60e907b9be4e0d0d462671
Signed-off-by: Andy Ye <andy.ye@rock-chips.com>

fastboot: support fuse at-perm-attr writting efuse

In the android things system, the command of fuse at-perm-attr
is used to program the permanent attributes and its hash.The
permanent attributes is

fastboot: support fuse at-perm-attr writting efuse

In the android things system, the command of fuse at-perm-attr
is used to program the permanent attributes and its hash.The
permanent attributes is written in eMMC RPMB, and its hash is
writen in efuse.

Change-Id: Ib0745100063d18b56e2dfcb638e0c9f7e2ef9b0a
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

show more ...

fastboot: usb: Add fastboot cmds to pass bootloadertest.

TEST:
python system/extra/tests/bootloader/bootloader.py --device-type iot

TODO:
"fastboot getvar all" is still NOT implemnted.
Functions sh

fastboot: usb: Add fastboot cmds to pass bootloadertest.

TEST:
python system/extra/tests/bootloader/bootloader.py --device-type iot

TODO:
"fastboot getvar all" is still NOT implemnted.
Functions should be implemented with actual state.

Change-Id: Ic757694622a5038a9766cedfde26c22935446347
Signed-off-by: Cody Xie <cody.xie@rock-chips.com>

show more ...

fastboot: add missing brace in cb_flash()

In the function cb_flash, we call avb_read_flash_lock_state
in the conditional judgement, but we do not add brackets after
the return.This cause the fastboo

fastboot: add missing brace in cb_flash()

In the function cb_flash, we call avb_read_flash_lock_state
in the conditional judgement, but we do not add brackets after
the return.This cause the fastboot can not work well.

Change-Id: Ib9bbd367d25bdc3e93e6db4444896caa114382a7
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

show more ...

fastboot: support oem fuse at-bootloader-vboot-key

Change-Id: Ifd5a0edeaf43cf1b359125db6168d7e102bcf0bf
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

lib: avb: change the prefix of some functions to make them coincident

Change-Id: Id876e6e49fb614e43d9f15cd9d24cee29aead223
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

fastboot: add new fastboot cmd

fastboot oem at-lock-vboot
fastboot oem at-unlock-vboot
fastboot oem at-disable-unlock-vboot

Change-Id: Id2ae9c64abab271fdc4abe385a68e7f156916e05
Signed-off-by: Jason

fastboot: add new fastboot cmd

fastboot oem at-lock-vboot
fastboot oem at-unlock-vboot
fastboot oem at-disable-unlock-vboot

Change-Id: Id2ae9c64abab271fdc4abe385a68e7f156916e05
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

show more ...

fastboot: support fastboot flashing lock/unlock

The new fastboot cmd add the lock/unlock state.
If the device is lock, fastboot can not flash
the device. The fastboot flash just can flash
the device

fastboot: support fastboot flashing lock/unlock

The new fastboot cmd add the lock/unlock state.
If the device is lock, fastboot can not flash
the device. The fastboot flash just can flash
the device if the device is unlock.

Change-Id: Ic1fb3a3c32c47f4c80e0e26c1b675b2d6a88c3f6
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

show more ...

fastboot: support fastboot oem fuse at-perm-attr

Change-Id: I82631a9edb69bd100bd676120fd07fbddbf34a2a
Signed-off-by: Jason Zhu <jason.zhu@rock-chips.com>

fastboot: add some new functions

1.add the support of 'set_active' command
2.add the support of 'get_staged' command
3.parse the command of 'oem' and 'flashing'

Change-Id: Ib890a938adfb65f537f5e1e2

fastboot: add some new functions

1.add the support of 'set_active' command
2.add the support of 'get_staged' command
3.parse the command of 'oem' and 'flashing'

Change-Id: Ib890a938adfb65f537f5e1e2d5ae8055cc99073c
Signed-off-by: Xu Hongfei <xuhf@rock-chips.com>

show more ...

Implement fastboot flash and erase.

Add function to respond to fastboot flash and erase. Flash writes the
previously downloaded image to indicated partition. Erase clears the
indicated partition. fb

Implement fastboot flash and erase.

Add function to respond to fastboot flash and erase. Flash writes the
previously downloaded image to indicated partition. Erase clears the
indicated partition. fb_flash and fb_erase are essentially wrappers
for fb_mmc_flash_write and fb_mmc_erase, which are implemented in
common/fb_mmc.c.

Added common/fb_common.c, where fastboot_okay/fail are implemented.
common/fb_mmc.c assumes fasboot_okay() and fastboot_fail() are
implemented, but they were tied to the fastboot USB implementation.
This refactor adds the response string as a parameter to
fastboot_okay/fail, instead of modifying a global.

Bug: 31887729
Test: FLASH:
- Create file "foo" containing 2048 chars = "-"
- Start "fastboot udp" on device and run
"fastboot -s udp:$RPI_IP flash misc foo" from host
- From U-boot console, read into memory the first 4 blocks from
misc partition, observe each byte is "-".

ERASE
- Start "fastboot udp" on device and run
"fastboot -s udp:$RPI_IP erase misc" from host
- From U-boot console, read into memory many blocks from misc
partition, observe each byte is 0x00

Configs that use fastboot USB implementation still build.

Change-Id: I5bd54868990bd9d5736d0969b3db240c2926eeec

show more ...

fastboot: Ensure we treat CONFIG_FASTBOOT_BUF_ADDR as long

Otherwise:
drivers/usb/gadget/f_fastboot.c:564:32: warning: format "%lx" expects
argument of type "long unsigned int", but argument 3 has t

fastboot: Ensure we treat CONFIG_FASTBOOT_BUF_ADDR as long

Otherwise:
drivers/usb/gadget/f_fastboot.c:564:32: warning: format "%lx" expects
argument of type "long unsigned int", but argument 3 has type "unsigned
int" [-Wformat=]

Signed-off-by: Tom Rini <trini@konsulko.com>

show more ...

Merge git://git.denx.de/u-boot-usb

fastboot: avoid printing invalid data

There is no guarantee that commands are null-terminated in the USB
request buffer, so limit the length of data that is printed.

Signed-off-by: John Keeping <jo

fastboot: avoid printing invalid data

There is no guarantee that commands are null-terminated in the USB
request buffer, so limit the length of data that is printed.

Signed-off-by: John Keeping <john@metanate.com>
Tested-by: Steve Rae <steve.rae@raedomain.com>

show more ...

Fix fastboot boot address

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
tells do_bootm() to look for an image at $loadaddr. This breaks if
CONFIG_FASTBOOT_BUF_ADDR is different

Fix fastboot boot address

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
tells do_bootm() to look for an image at $loadaddr. This breaks if
CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set
loadaddr.

Instead, tell do_bootm() to pick up the image where it was laoded.

Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
Reviewed-by: Tom Rini <trini@konsulko.com>
Acked-by: Steve Rae <steve.rae@raedomain.com>

show more ...

env: Rename getenv/_f() to env_get()

We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.

Quite a few place

env: Rename getenv/_f() to env_get()

We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.

Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.

Suggested-by: Wolfgang Denk <wd@denx.de>
Signed-off-by: Simon Glass <sjg@chromium.org>

show more ...

usb: gadget: avoid variable name clipping in cb_getvar

Hi,

A kind reminder to look at this patch (already reviewed by Marek and acked by Lukasz), and if possible to put it in the next pull list, or

usb: gadget: avoid variable name clipping in cb_getvar

Hi,

A kind reminder to look at this patch (already reviewed by Marek and acked by Lukasz), and if possible to put it in the next pull list, or the one after is timing is too short.

Thanks in advance for your time

Best Regards
Nicolas

-----Original Message-----
From: Nicolas LE BAYON
Sent: mardi 25 avril 2017 10:18
To: Nicolas LE BAYON <nicolas.le.bayon@st.com>; u-boot@lists.denx.de; lukma@denx.de; marex@denx.de
Cc: nlebayon@gmail.com; Patrice CHOTARD <patrice.chotard@st.com>; Jean-philippe ROMAIN <jean-philippe.romain@st.com>
Subject: [U-Boot][PATCH v7] usb: gadget: avoid variable name clipping in cb_getvar

From: Nicolas Le Bayon <nicolas.le.bayon@st.com>

Instead of using a fixed-size array to store variable name, preferring a dynamic allocation treats correctly all variable name lengths.
Variable names are growing through releases and features. By this way, name clipping is prevented.

Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Lukasz Majewski <lukma@denx.de>

show more ...

fastboot: sparse: resync common/image-sparse.c (part 2)

- update fastboot_okay() and fastboot_fail()

This file originally came from upstream code.

While retaining the storage abstraction feature,

fastboot: sparse: resync common/image-sparse.c (part 2)

- update fastboot_okay() and fastboot_fail()

This file originally came from upstream code.

While retaining the storage abstraction feature, this is the second
set of the changes required to resync with the
cmd_flash_mmc_sparse_img()
in the file
aboot.c
from
https://us.codeaurora.org/cgit/quic/la/kernel/lk/plain/app/aboot/aboot.c?h=LE.BR.1.2.1

Signed-off-by: Steve Rae <srae@broadcom.com>

show more ...

fastboot: sparse: remove session-id logic

This "session-id" alogrithm is not required, and currently corrupts
the stored image whenever more the one "session" is required.

Signed-off-by: Steve Rae

fastboot: sparse: remove session-id logic

This "session-id" alogrithm is not required, and currently corrupts
the stored image whenever more the one "session" is required.

Signed-off-by: Steve Rae <srae@broadcom.com>

show more ...

Merge branch 'master' of git://www.denx.de/git/u-boot-usb

fastboot: Clean up bulk-out logic

Just use ep->maxpacket to get the maxpacket size
and simplify the bulk-out maxpacket alignment.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Tested-by: Steve Rae <

fastboot: Clean up bulk-out logic

Just use ep->maxpacket to get the maxpacket size
and simplify the bulk-out maxpacket alignment.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Tested-by: Steve Rae <srae@broadcom.com>

show more ...

fastboot: Enable the respective speed endpoints at runtime

In a dual speed configuration we need to check at runtime if
we want to enable the Full-Speed or High-Speed endpoint.

Signed-off-by: Roger

fastboot: Enable the respective speed endpoints at runtime

In a dual speed configuration we need to check at runtime if
we want to enable the Full-Speed or High-Speed endpoint.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Steve Rae <srae@broadcom.com>
[Test HW: bcm235xx board]

show more ...

fastboot: Fix wMaxPacketSize for High-Speed IN endpoint

wMaxPacketSize for IN endpoing in High-Speed must be 512 and not 64.
While fixing that we do some clean ups like

- use cpu_to_le16(decimal_le

fastboot: Fix wMaxPacketSize for High-Speed IN endpoint

wMaxPacketSize for IN endpoing in High-Speed must be 512 and not 64.
While fixing that we do some clean ups like

- use cpu_to_le16(decimal_length) instead of hexadecimal length.
- No need to initialize bInterval to 0. Static variables are 0 initialized.
- Move descriptor setting from fastboot_add to to fastboot_bind.
- check for dual speed configuration before setting the high speed descriptors.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Tested-by: Steve Rae <srae@broadcom.com>
Tested-by: Steve Rae <srae@broadcom.com> [Test HW: bcm235xx board]

show more ...