Merge changes from topic "xlnx_versal_misra_fixes_series_3" into integration

* changes:
fix(xilinx): resolve misra rule 16.3 violations
fix(xilinx): resolve misra rule 2.5 violations
fix(xilin

Merge changes from topic "xlnx_versal_misra_fixes_series_3" into integration

* changes:
fix(xilinx): resolve misra rule 16.3 violations
fix(xilinx): resolve misra rule 2.5 violations
fix(xilinx): resolve misra rule 4.6 violations
fix(xilinx): resolve misra rule 12.2 violations
fix(xilinx): resolve misra rule 10.1 violations
fix(xilinx): resolve misra rule 8.13 violations
fix(xilinx): resolve misra rule 4.5 violations
fix(xilinx): resolve misra rule 16.4 violations

show more ...

fix(xilinx): resolve misra rule 16.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.16.3:
- An unconditional break statement shall terminate every switch-clause.
- Fix:

fix(xilinx): resolve misra rule 16.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.16.3:
- An unconditional break statement shall terminate every switch-clause.
- Fix:
- Added break statement in default clause to comply with MISRA.

Change-Id: Ie1ed38be671d5788096b2addba8e9a8fbcc4f2ec
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 2.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Removed unus

fix(xilinx): resolve misra rule 2.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.5:
- A project should not contain unused macro declarations.
- Fix:
- Removed unused macro declarations.

Change-Id: I2b9deda95d1a3927ab8b4e2c8a41bd85acb62be3
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 4.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.6:
- Typedefs that indicate size and signedness should be used in
place of the b

fix(xilinx): resolve misra rule 4.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.6:
- Typedefs that indicate size and signedness should be used in
place of the basic numerical types.
- Fix:
- Used typedefs that indicate size and signedness in place of basic
numerical types and updated return type of function wherever needed.

Change-Id: Ifde2379ee3f9d5ab30ef695d99f59591af575aba
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 12.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.12.2:
- The right hand operand of a shift operator shall lie in the range
zero to

fix(xilinx): resolve misra rule 12.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.12.2:
- The right hand operand of a shift operator shall lie in the range
zero to one less than the width in bits of the essential type of
the left hand operand.
- Fix:
- Type casted left operand to a larger width than shift.

Change-Id: I662ff57e52d1260e2f1a0de595f19a9143714892
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve violations generated with IPI_CRC_CHECK enabled

Fix below MISRA violations generated with IPI_CRC_CHECK enabled:
- MISRA-C rule 8.3
- Made same parameter names in function dec

fix(xilinx): resolve violations generated with IPI_CRC_CHECK enabled

Fix below MISRA violations generated with IPI_CRC_CHECK enabled:
- MISRA-C rule 8.3
- Made same parameter names in function declaration and definition.
- MISRA-C rule 12.2
- Type casted left operand to a larger width than shift.
- MISRA-C rule 15.6
- Added braces for if statements.

Change-Id: I90c5723e77431cc29b9896425ce1be94df44c042
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 10.1 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.1:
- Operands shall not be of an inappropriate essential type.
- Fix:
- Made ope

fix(xilinx): resolve misra rule 10.1 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.1:
- Operands shall not be of an inappropriate essential type.
- Fix:
- Made operands of the same type.

Change-Id: I30a01cc0938603defba7572e9f4dd9ebe6d74a9c
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 8.13 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever possible.
- Fix:

fix(xilinx): resolve misra rule 8.13 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.13:
- A pointer should point to a const-qualified type whenever possible.
- Fix:
- Made constant pointer wherever the object it points to doesn't change.

Change-Id: I16c87dcc2b3a49c70c1e60f25aa361f1f13bda13
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 4.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.5:
- Identifiers in the same name space with overlapping visibility should
be ty

fix(xilinx): resolve misra rule 4.5 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.4.5:
- Identifiers in the same name space with overlapping visibility should
be typographically unambiguous.
- Fix:
- Renamed PM_RET_ERROR_NOFEATURE to PM_RET_ERROR_IOCTL_NOT_SUPPORTED
and removed unnecessary macro definitions.

Change-Id: I6f03e619979685df7418fbccad7b0934d136776e
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 16.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.16.4:
- Every switch statement shall have a non-empty default label.
- Fix:
- Modif

fix(xilinx): resolve misra rule 16.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.16.4:
- Every switch statement shall have a non-empty default label.
- Fix:
- Modified logic to comply with MISRA guidelines.

Change-Id: Ifd5f27763481f532affad6eb39ce6319dd6e95fc
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

Merge changes from topic "xlnx_versal_misra_fixes" into integration

* changes:
fix(xilinx): resolve misra rule 2.3 violations
fix(xilinx): resolve misra rule 2.7 violations
fix(xilinx): resolv

Merge changes from topic "xlnx_versal_misra_fixes" into integration

* changes:
fix(xilinx): resolve misra rule 2.3 violations
fix(xilinx): resolve misra rule 2.7 violations
fix(xilinx): resolve misra rule 8.6 violations
fix(xilinx): resolve misra rule 11.3 violations
fix(xilinx): resolve misra rule 2.2 violations
fix(xilinx): resolve misra rule 15.7 violations

show more ...

refactor(zynqmp): refactor custom sip service

Refactored the custom SIP service code and relocated it to a
common directory to support additional platforms and enhance
code readability. Renamed ZYNQ

refactor(zynqmp): refactor custom sip service

Refactored the custom SIP service code and relocated it to a
common directory to support additional platforms and enhance
code readability. Renamed ZYNQMP_SIP_SVC_CUSTOM to a generic
SOC_SIP_SVC_CUSTOM for better with other across SoCs

Change-Id: Id114f717d0397e257a831c7d5b67104c2c766d09
Signed-off-by: Prasad Kummari <prasad.kummari@amd.com>

show more ...

Merge "fix(xilinx): resolve misra rule 8.4 violations" into integration

fix(xilinx): update tsp_early_platform_setup prototype

The prototype for tsp_early_platform_setup has been redefined. Update
the platform implementation to match the new function signature and
ensur

fix(xilinx): update tsp_early_platform_setup prototype

The prototype for tsp_early_platform_setup has been redefined. Update
the platform implementation to match the new function signature and
ensure compatibility with the updated TSP interface.

Change-Id: I428577c5e92911db3bc6f1ac81b127b44cb136e4
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>

show more ...

fix(xilinx): resolve misra rule 2.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.3:
- A project should not contain unused type declarations.
- Fix:
- Removed unuse

fix(xilinx): resolve misra rule 2.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.3:
- A project should not contain unused type declarations.
- Fix:
- Removed unused code.

Change-Id: Ica5982fe83485da79ac18d45b44e66f5f37fb6e7
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 2.7 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.7:
- There should be no unused parameters in functions.
- Fix:
- Type casted unuse

fix(xilinx): resolve misra rule 2.7 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.7:
- There should be no unused parameters in functions.
- Fix:
- Type casted unused parameters to void.

Change-Id: I940109631dbabfbd960c1bc7b183cf865ff312c9
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 8.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.6:
- An identifier with external linkage shall have exactly one external
definit

fix(xilinx): resolve misra rule 8.6 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.6:
- An identifier with external linkage shall have exactly one external
definition.
- Fix:
- Removed redundant function declarations since it is not defined.

Change-Id: If003efbfa08ee6ff4f545605ef34dfd16f33b664
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 11.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.11.3:
- A cast shall not be performed between a pointer to object type and a
poin

fix(xilinx): resolve misra rule 11.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.11.3:
- A cast shall not be performed between a pointer to object type and a
pointer to a different object type.
- Fix:
- Removed unnecessary cast of pointers.

Change-Id: Iba5dbec0784dcaa86e3a00bd213cbc2711d12029
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 2.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.2:
- There shall be no dead code.
- Fix:
- Moved code to macro protected section.

fix(xilinx): resolve misra rule 2.2 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.2.2:
- There shall be no dead code.
- Fix:
- Moved code to macro protected section.

Change-Id: I58b340aa452b67ba765dfe33ff7eb64a4eac8624
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 15.7 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.15.7:
- All if...else if constructs shall be terminated with an else statement.
- Fix

fix(xilinx): resolve misra rule 15.7 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.15.7:
- All if...else if constructs shall be terminated with an else statement.
- Fix:
- Convert the final else if into an else statement to comply with
MISRA guidelines

Change-Id: I1f54d955958538529a10f146a506ce2a3474f8d7
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 8.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.4:
- A compatible declaration shall be visible when an object or function
with e

fix(xilinx): resolve misra rule 8.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.4:
- A compatible declaration shall be visible when an object or function
with external linkage is defined.
- Fix:
- Declared variable as static.

Change-Id: I44a022de3d5a62d255e2481dc1f4d1e8df2c7eb0
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 8.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.3:
- All declarations of an object or function shall use the same names
and type

fix(xilinx): resolve misra rule 8.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.8.3:
- All declarations of an object or function shall use the same names
and type qualifiers.
- Fix:
- Made same name parameters and type qualifiers in function declaration
and definition.

Change-Id: Idb4f986cec957102bb4ba1ef22f2e7937aaeb54d
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 14.4 violation

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.14.4:
- The controlling expression of an if statement and the controlling
expressi

fix(xilinx): resolve misra rule 14.4 violation

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.14.4:
- The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean
type.
- Fix:
- Converted controlling expression of if statement into essential
Boolean type.

Change-Id: I2642ff4d6446bc0719d27cd95b1ad35c36f40211
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 10.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.4:
- Both operands of an operator in which the usual arithmetic conversions
ar

fix(xilinx): resolve misra rule 10.4 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.4:
- Both operands of an operator in which the usual arithmetic conversions
are performed shall have the same essential type category.
- Fix:
- Made data type same for both the operands.

Change-Id: I0cea19477f3c10265d95ea1d5d2ea151dbf174bb
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...

fix(xilinx): resolve misra rule 10.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.3:
- The value of an expression shall not be assigned to an object
with a narr

fix(xilinx): resolve misra rule 10.3 violations

Fixed below MISRA violation:
- MISRA Violation: MISRA-C:2012 R.10.3:
- The value of an expression shall not be assigned to an object
with a narrower essential type or of a different essential type
category.
- Fix:
- Explicitly type casted to narrower essential type or of a different
essential type category.

Change-Id: Ia4258d2d0655f7847f832804a13d182ac0a2a29b
Signed-off-by: Devanshi Chauhan Alpeshbhai <devanshi.chauhanalpeshbhai@amd.com>

show more ...