refactor(neoverse-rd): move defines out of platform_def.h

Presently, the second generation platforms have direct references to CSS
and ROS specific addresses within RD-N2's platform header file
(pla

refactor(neoverse-rd): move defines out of platform_def.h

Presently, the second generation platforms have direct references to CSS
and ROS specific addresses within RD-N2's platform header file
(platform_def.h). Moreover, there are platform port specific macros
defined within platform_def.h To enhance organization and
appropriateness, relocate these definitions to nrd_css_def2.h,
nrd_ros_def2.h and nrd_arm_platform_def1.h files accordingly. Reuse
these definitions within the platform_def.h files as needed.

Additionally, remove reference to the unused PLAT_ARM_GICC_BASE macro
from the individual platform_def.h file.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I9a237c3ae28d7e209188e2c37c8494b4a420ee83

show more ...

refactor(neoverse-rd): add defines for ROM, SRAM and DRAM2

In the current setup, the base and size of the ROM, SRAM, and DRAM2
regions are directly defined in the nrd_fw_def2.h file for N2 CPU based

refactor(neoverse-rd): add defines for ROM, SRAM and DRAM2

In the current setup, the base and size of the ROM, SRAM, and DRAM2
regions are directly defined in the nrd_fw_def2.h file for N2 CPU based
platforms. To enhance modularity and appropriateness, introduce macros
for these definitions in the respective css file (nrd_css_def2.h). While
the maximum sizes for ROM, SRAM, and DRAM2 are specified in the css
specification, the actual implementation sizes may vary. Consequently,
relocate the size macros to the platform-specific platform_def.h file
for individual platforms.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I30988bf63cf942f68188a70697cc43cb6af96a9c

show more ...

refactor(neoverse-rd): define naming convention for RoS macros

As part of the refactoring for the second generation platforms,
introduce a naming convention for macros within nrd_ros_def2.h and
nrd_

refactor(neoverse-rd): define naming convention for RoS macros

As part of the refactoring for the second generation platforms,
introduce a naming convention for macros within nrd_ros_def2.h and
nrd_ros_fw_def2.h. All macros, except those related to page table
entries, must adhere to the format NRD_ROS_<name>. Page table entry
macros are handled separately and are not part of this patch.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ifcdc30b1c80b9848b793de2013095fc98d57bec6

show more ...

refactor(neoverse-rd): define naming convention for CSS macros

As part of the refactoring for the second generation of platforms,
introduce a naming convention for macros within nrd_css_def2.h and
n

refactor(neoverse-rd): define naming convention for CSS macros

As part of the refactoring for the second generation of platforms,
introduce a naming convention for macros within nrd_css_def2.h and
nrd_css_fw_def2.h. All macros, except those related to page table
entries, must adhere to the format NRD_CSS_<name>. Page table entry
macros are handled separately and are not part of this patch.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ib168320e12f06cd034342c011909896de463ab27

show more ...

refactor(neoverse-rd): refactor mmap macro for RoS device memory region

There are two macros that define ROS device memory map range and
attributes - one for local chip and the other for remote chip

refactor(neoverse-rd): refactor mmap macro for RoS device memory region

There are two macros that define ROS device memory map range and
attributes - one for local chip and the other for remote chip. Refactor
these two macros into a single macro that uses the chip ID to identify
the local or the remote chip.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I58eb65c2f046b6074f848f1448cd10a7dcc37f74

show more ...

refactor(neoverse-rd): refactor mmap macro for CSS device memory region

There are two macros that define CSS device memory map range and
attributes - one for local chip and the other for remote chip

refactor(neoverse-rd): refactor mmap macro for CSS device memory region

There are two macros that define CSS device memory map range and
attributes - one for local chip and the other for remote chip. Refactor
these two macros into a single macro that uses the chip ID to identify
the local or the remote chip. While at it, rename the macro that defines
the memory map range and attributes for the remote shared RAM region.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ieddd5c81f6261490dbacb97160858903e56d327a

show more ...

refactor(neoverse-rd): set mmap naming convention

Presently, for the second generation platforms based on the N2 CPU,
macros related to page table entries lack a consistent naming
convention. This a

refactor(neoverse-rd): set mmap naming convention

Presently, for the second generation platforms based on the N2 CPU,
macros related to page table entries lack a consistent naming
convention. This absence may lead to potential mix-ups, such as css
definitions in soc files, and can contribute to decreased code clarity.
To address this, establish the following naming convention:

- NRD_CSS_<name>_MMAP for CSS related page table entries
- NRD_ROS_<name>_MMAP for ROS related page table entries

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I7bf1f9b0ddfd0444c802a23143de6a163f127731

show more ...

refactor(neoverse-rd): rename nrd_plat_v2.c to align with convention

Header files for N2 CPU based platforms currently use "2" as
a suffix. Rename the common source file, nrd_plat_v2.c used by these

refactor(neoverse-rd): rename nrd_plat_v2.c to align with convention

Header files for N2 CPU based platforms currently use "2" as
a suffix. Rename the common source file, nrd_plat_v2.c used by these
platforms to nrd_plat2.c to align with this convention.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I36b138a0a4dff8087e52f0f2cbc21abc03a793ad

show more ...

refactor(neoverse-rd): refactor nrd_soc_css_def_v2.h file

Continuing the refactoring of the various definition for platforms based
on N2/V2 CPU, refactor the definitions in the nrd_soc_css_def_v2.h

refactor(neoverse-rd): refactor nrd_soc_css_def_v2.h file

Continuing the refactoring of the various definition for platforms based
on N2/V2 CPU, refactor the definitions in the nrd_soc_css_def_v2.h file
into the following files as appropriate.

- nrd_ros_def2.h: includes RoS hardware related definitions
- nrd_plat_arm_def2.h: includes platform port related definitions

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ib447e67a0a42722735297b27b7f5017bc146156c

show more ...

refactor(neoverse-rd): refactor nrd_soc_platform_def_v2.h file

Continuing the refactoring of the various definitions for the second
generation platforms based on the N2/V2 CPU, refactor the definiti

refactor(neoverse-rd): refactor nrd_soc_platform_def_v2.h file

Continuing the refactoring of the various definitions for the second
generation platforms based on the N2/V2 CPU, refactor the definitions in
the nrd_soc_platform_def_v2.h file into the following files as
appropriate.

- nrd_ros_def2.h: includes RoS hardware related definitions
- nrd_ros_fw_def2.h: includes RoS firmware related definitions
- nrd_plat_arm_def2.h: includes platform port related definitions

RoS (Rest Of System) is used to refer to the part of the reference
design platform that excludes CSS. The file inclusions in the
platform_def.h file of the platforms have been updated accordingly.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I393e6f4a84be45f1781ea281bd55fa813803f6db

show more ...

refactor(neoverse-rd): refactor nrd_base_platform_def.h

The nrd_base_platform_def.h file includes CSS, RoS, firmware and
platform port related definitions. This approach of consolidating the
various

refactor(neoverse-rd): refactor nrd_base_platform_def.h

The nrd_base_platform_def.h file includes CSS, RoS, firmware and
platform port related definitions. This approach of consolidating the
various definitions for multiple generation of platforms into the
nrd_base_platform_def.h file is not scaling well.

So in preparation of moving away from the use of nrd_base_platform_def.h
file for the second generation platforms based on N2/V2 CPUs, split the
definitions in this file into multiple include files. The new files into
which the definitions are refactored are -

- nrd_css_def2.h: includes CSS hardware related definitions
- nrd_css_fw_def2.h: includes CSS firmware related definitions
- nrd_ros_fw_def2.h: includes RoS firmware related definitions
- nrd_plat_arm_def2.h: includes platform port elated definitions

RoS (Rest Of System) is used to refer to the part of the reference
design platform that excludes CSS. The definitions that are only
relavant to the aforementioned platforms have been refactored from the
nrd_base_platform_def.h file.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I45f680857328fa77f0977897490b225bdb29efe4

show more ...

refactor(neoverse-rd): header files for second generation platforms

Presently, platforms such as RD-N2, RD-N2-Cfg1, RD-N2-Cfg2 and RD-V2
utilize nrd_soc_platform_def_v2.h and nrd_soc_css_def_v2.h fo

refactor(neoverse-rd): header files for second generation platforms

Presently, platforms such as RD-N2, RD-N2-Cfg1, RD-N2-Cfg2 and RD-V2
utilize nrd_soc_platform_def_v2.h and nrd_soc_css_def_v2.h for all css
and soc-related defines. So move these two header files into a new
directory named 'nrd2'. This new directory will serve as the container
of header files that are specific to the former stated platforms.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I51ba0944dea91ae81e1840947d2e9af9b28d561d

show more ...

refactor(neoverse-rd): clean-up nrd_plat_arm_def1.h file

As the last step of refactoring the platform support of the first
generation of reference design platforms (A75/N1/V1), clean-up the
platform

refactor(neoverse-rd): clean-up nrd_plat_arm_def1.h file

As the last step of refactoring the platform support of the first
generation of reference design platforms (A75/N1/V1), clean-up the
platform port definitions listed in the nrd_plat_arm_def1.h file.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I73a9b94f1db22192398ea8211109d2e4aaf965e1

show more ...

refactor(neoverse-rd): move defines out of platform_def.h

Presently, A75/V1/N1 CPU based platforms have platform port specific
macros defined within their platform_def.h file. To enhance organizatio

refactor(neoverse-rd): move defines out of platform_def.h

Presently, A75/V1/N1 CPU based platforms have platform port specific
macros defined within their platform_def.h file. To enhance organization
and appropriateness, relocate these definitions to
nrd_arm_platform_def1.h.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I1f55192185df1509756bc2ef022e5aed0724dd05

show more ...

refactor(neoverse-rd): rename definitions in nrd_ros_fw_def1.h file

The newly introduced nrd_ros_fw_def1.h file contains definitions that
have been refactored from other files. For better clarity, t

refactor(neoverse-rd): rename definitions in nrd_ros_fw_def1.h file

The newly introduced nrd_ros_fw_def1.h file contains definitions that
have been refactored from other files. For better clarity, these
definitions are renamed appropriately with the prefix NRD_ROS to
denote that the definitions are for the rest of system (RoS) part
of the platform.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I4ecc76ca9250a68f7eca5d9a0d82c7674b34ca1d

show more ...

refactor(neoverse-rd): rename definitions in nrd_ros_def1.h file

The newly introduced nrd_ros_def1.h file contains definitions that
have been refactored from other files. For better clarity, these
d

refactor(neoverse-rd): rename definitions in nrd_ros_def1.h file

The newly introduced nrd_ros_def1.h file contains definitions that
have been refactored from other files. For better clarity, these
definitions are renamed appropriately with the prefix NRD_ROS to
denote that the definitions are for the rest of system (RoS) part
of the platform. While at it, cleanup the platform ID related
definitions as well.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I12f559c82c62f05b9eed67baf9dd69d89f83a4da

show more ...

refactor(neoverse-rd): rename definitions in nrd_css_fw_def1.h file

The newly introduced nrd_css_fw_def1.h file contains definitions that
have been refactored from other files. For better clarity, t

refactor(neoverse-rd): rename definitions in nrd_css_fw_def1.h file

The newly introduced nrd_css_fw_def1.h file contains definitions that
have been refactored from other files. For better clarity, these
definitions are renamed appropriately with the prefix NRD_CSS to denote
that the definitions are for the CSS.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I8b9e52b4beb42aba1117df2db53daff96a7994bb

show more ...

refactor(neoverse-rd): rename definitions in nrd_css_def1.h file

The newly introduced nrd_css_def1.h file contains definitions that have
been refactored from other files. For better clarity, these d

refactor(neoverse-rd): rename definitions in nrd_css_def1.h file

The newly introduced nrd_css_def1.h file contains definitions that have
been refactored from other files. For better clarity, these definitions
are renamed appropriately with the prefix NRD_CSS to denote that the
definitions are for the CSS.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ie8bb32f96273cfa102a03fba3290b58051dac747

show more ...

refactor(neoverse-rd): rewrite CSS and RoS device mmap macros

The CSS and RoS peripherals memory map macros have incorrect memory base
address and region size values. That is, the existing mmap defi

refactor(neoverse-rd): rewrite CSS and RoS device mmap macros

The CSS and RoS peripherals memory map macros have incorrect memory base
address and region size values. That is, the existing mmap definitions
are -

CSS peripherals mmap - Base address (0x20000000) and size (0x20000000)
RoS peripherals mmap - Base address (0x40000000) and size (0x40000000)

The corrected peripherals memory map definitions are -

CSS peripherals mmap - Base address (0x20000000) and size (0x40000000)
RoS peripherals mmap - Base address (0x60000000) and size (0x20000000)

While these macros are being updated, it is a good opportunity to rename
them appropriately. That is, the new macros are named as

NRD_CSS_PERIPH_MMAP - for mmap macro for CSS peripherals memory region
NRD_ROS_PERIPH_MMAP - for mmap macro for RoS peripherals memory region

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ic2d12d7904922660a03efe6bc83ca8df2eb5a8d4

show more ...

refactor(neoverse-rd): refactor mmap macro for RoS device memory region

There are two macros that define ROS device memory map range and
attributes - one for local chip and the other for remote chip

refactor(neoverse-rd): refactor mmap macro for RoS device memory region

There are two macros that define ROS device memory map range and
attributes - one for local chip and the other for remote chip. Refactor
these two macros into a single macro that uses the chip ID to identify
the local or the remote chip.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Iceb87f5fc319efa37105d66bb1c88b622a2bb366

show more ...

refactor(neoverse-rd): refactor mmap macro for CSS device memory region

There are two macros that define CSS device memory map range and
attributes - one for local chip and the other for remote chip

refactor(neoverse-rd): refactor mmap macro for CSS device memory region

There are two macros that define CSS device memory map range and
attributes - one for local chip and the other for remote chip. Refactor
these two macros into a single macro that uses the chip ID to identify
the local or the remote chip.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I8c5374587391839260079f49f66c3307cf7118a9

show more ...

refactor(neoverse-rd): migrate mmap entry from nrd_plat1.c

As per the ongoing refactoring, page table entry mappings should be part
of nrd_css_fw_def1.h, nrd_ros_fw_def1.h or nrd_plat_arm_def1.h.
Th

refactor(neoverse-rd): migrate mmap entry from nrd_plat1.c

As per the ongoing refactoring, page table entry mappings should be part
of nrd_css_fw_def1.h, nrd_ros_fw_def1.h or nrd_plat_arm_def1.h.
Therefore, migrate any page table entries which are part of nrd_plat1.c
file.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: Ia3318b4a10b9379486cefb83b0efe2f12d545a09

show more ...

refactor(neoverse-rd): rename nrd_plat.c file

The source file nrd_plat.c file is used only by the first generation of
reference design platforms (A75/N1/V1). So, rename this file as
nrd_plat1.c file

refactor(neoverse-rd): rename nrd_plat.c file

The source file nrd_plat.c file is used only by the first generation of
reference design platforms (A75/N1/V1). So, rename this file as
nrd_plat1.c file to denote that this file is used only by the first
generation of reference design platforms. In addition to this, remove
any unused code in this file.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I15aa9465260789b02a3e8f82af9e26a97092cebf

show more ...

refactor(neoverse-rd): refactor nrd_soc_css_def.h file

Continuing the refactoring of the various definitions for the first
generation of platforms (A75/N1/V1), refactor the definitions in the
nrd_so

refactor(neoverse-rd): refactor nrd_soc_css_def.h file

Continuing the refactoring of the various definitions for the first
generation of platforms (A75/N1/V1), refactor the definitions in the
nrd_soc_css_def.h file into the following files as appropriate.

- nrd_ros_def1.h: includes RoS hardware related definitions
- nrd_plat_arm_def1.h: includes platform port related definitions

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I791a5cfbccdbdf19083f9b482b51d60f832aafd6

show more ...

refactor(neoverse-rd): refactor nrd_soc_platform_def.h file

Continuing the refactoring of the various definitions for the first
generation of platforms (A75/N1/V1), refactor the definitions in the
n

refactor(neoverse-rd): refactor nrd_soc_platform_def.h file

Continuing the refactoring of the various definitions for the first
generation of platforms (A75/N1/V1), refactor the definitions in the
nrd_soc_platform_def.h file into the following files as appropriate.

- nrd_ros_def1.h: includes RoS hardware related definitions
- nrd_ros_fw_def1.h: includes RoS firmware related definitions
- nrd_plat_arm_def1.h: includes platform port related definitions

RoS (Rest Of System) is used to refer to the part of the reference
design platform that excludes CSS.

The file inclusions in the platform_def.h file of the platforms have
been updated accordingly.

Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
Change-Id: I081d2a225a32c15f65d8d86f81104ba12d284406

show more ...