Fail recovery in encrypted file system

- File will be deleted if the file content of a new created file
cannot be successfully encrypted and write back to normal world
file system.

Signed-off-b

Fail recovery in encrypted file system

- File will be deleted if the file content of a new created file
cannot be successfully encrypted and write back to normal world
file system.

Signed-off-by: James Kung <james.kung@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: SY Chiu <sy.chiu@linaro.org>
Tested-by: James Kung <james.kung@linaro.org> (QEMU)
Tested-by: SY Chiu <sy.chiu@linaro.org> (QEMU)
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)

show more ...

Enhancing Secure Storage

- Implement encrypted file system key manager
* Key generation for SSK, FEK
* Provide helper APIs to do file encryption/decryption
* Finished key manager test cases fo

Enhancing Secure Storage

- Implement encrypted file system key manager
* Key generation for SSK, FEK
* Provide helper APIs to do file encryption/decryption
* Finished key manager test cases for file encryption/decryption tests

- Implements encrypted file system operations file-based operation
* file content is encrypted and MACed before storing
on normal world file system.
* file hole is not implemented because this is
meaningless in the context of secure storage.

Signed-off-by: SY Chiu <sy.chiu@linaro.org>
Signed-off-by: James Kung <james.kung@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: SY Chiu <sy.chiu@linaro.org> (QEMU)
Tested-by: James Kung <james.kung@linaro.org> (QEMU)
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)

show more ...

Fix unaligned lo and hi in tee_mm_init

Fixes #304

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

build: remove conf-file from cleanvars.mk

conf-file and conf-mk-file are valid for core and lib
compilation. These variables are set only once, when
starting the building.

Without this patch, the v

build: remove conf-file from cleanvars.mk

conf-file and conf-mk-file are valid for core and lib
compilation. These variables are set only once, when
starting the building.

Without this patch, the variables are cleaned when
compiling the libs. This affects the rules
$(objs): $(conf-file)
which forces the conf-file generation.
In case of parallel build, if libs are compiled before the
core, then conf-file is not created, which results in a
compilation error.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Fix objdump warning

If version.o is compiled with -g3, which is the case for several platforms
since commit c974c7ddc7d8 ("plat-stm: use generic linker script") which
introduces the use of $(platfor

Fix objdump warning

If version.o is compiled with -g3, which is the case for several platforms
since commit c974c7ddc7d8 ("plat-stm: use generic linker script") which
introduces the use of $(platform-cflags) when compiling version.o, objdump
produces a warning:

$ make PLATFORM=vexpress-qemu_virt
<...>
OBJDUMP out/arm-plat-vexpress/core/tee.dmp
BFD: Dwarf Error: mangled line number section.

The object file does not look right (or objdump does not decode it
properly?):

$ arm-linux-gnueabihf-objdump -W out/arm-plat-vexpress/core/version.o \
>/dev/null
arm-linux-gnueabihf-objdump: Warning: Badly formed extended line op
encountered!

Just remove the offending flag to workaround the issue.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix pager

Commit c974c7ddc7d8 ("plat-stm: use generic linker script") breaks
CFG_WITH_PAGER=y because it adds $(platform-cflags) to the C flags for
version.o. This is correct, otherwise the compiler

Fix pager

Commit c974c7ddc7d8 ("plat-stm: use generic linker script") breaks
CFG_WITH_PAGER=y because it adds $(platform-cflags) to the C flags for
version.o. This is correct, otherwise the compiler may generate code
that is not suitable for the platform (such as floating-point
instructions when we don't expect them).

However, compiling version.o with $(platform-cflags) brings in
-fdata-sections which has an unfortunate side effect: the object is not
included in the non-pageable code unless we add it explicitely.
This is what this commit does.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Build: fix silent mode with make 3.8x

With make 3.8x, in case of 'make all -s -w', MAKEFLAGS equals 'ws'
This patch correctly catches the flag 's'

Reviewed-by: Jerome Forissier <jerome.forissier@li

Build: fix silent mode with make 3.8x

With make 3.8x, in case of 'make all -s -w', MAKEFLAGS equals 'ws'
This patch correctly catches the flag 's'

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

plat-stm: use generic linker script

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.o

plat-stm: use generic linker script

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

plat-stm: CFG_GENERIC_BOOT=y

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)
Tested-by: Pascal Brand <pascal.brand@linaro.org

plat-stm: CFG_GENERIC_BOOT=y

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)
Tested-by: Pascal Brand <pascal.brand@linaro.org> (QEMU platform)
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

plat-stm: tz_sinit.c becomes very close to generic_entry_a32.S

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

Doc: Adding ftrace documentation

Adding a section in the debug.md file that explains how to enable ftrace
and use it for debugging the kernel module for OP-TEE.

Signed-off-by: Joakim Bech <joakim.b

Doc: Adding ftrace documentation

Adding a section in the debug.md file that explains how to enable ftrace
and use it for debugging the kernel module for OP-TEE.

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU, Hikey)
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

build: use $(cmd-echo-silent) when linking TAs

With this commit, make -s is also silent when building TAs.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <p

build: use $(cmd-echo-silent) when linking TAs

With this commit, make -s is also silent when building TAs.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix possible TA build error with make -j: "Directory nonexistent"

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens

Fix possible TA build error with make -j: "Directory nonexistent"

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

Out of memory check fix for tee_mm_alloc

This is to address issue #304 where tee_mm_alloc has an
incorrect check for out of memory condition.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Rev

Out of memory check fix for tee_mm_alloc

This is to address issue #304 where tee_mm_alloc has an
incorrect check for out of memory condition.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Youssef Esmat <youssef.esmat@microsoft.com>

show more ...

hikey: enable SHA1 and SHA256 crypto extensions by default on aarch32

This results in a 3.4x speed improvement on a mixed SHA1 and SHA256 test.
I used xtest 4001, modified to run 2 test loops (one f

hikey: enable SHA1 and SHA256 crypto extensions by default on aarch32

This results in a 3.4x speed improvement on a mixed SHA1 and SHA256 test.
I used xtest 4001, modified to run 2 test loops (one for SHA1 and one for
SHA256) on a 32 KiB buffer. The buffer is hashed 10,000 times in each
loop. I measured the total elapsed time for a test run.
aarch64 numbers are given for comparison although crypto extensions are
not supported in this case.

Test case # runs min avg max stddev relative
(s) (s) (s) (%) speed
-------------- ------ ----- ----- ----- ------ ---------
aarch32, no CE 10 18.65 18.86 19.49 1.7 1.00
aarch32, CE 10 5.49 5.60 5.67 1.0 3.37
aarch64 10 22.02 22.14 22.83 1.2 0.85

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix compile error

Some versions of GCC produce a "may be used uninitialized" error when
DEBUG=0 CFG_TEE_CORE_LOG_LEVEL=3.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by:

Fix compile error

Some versions of GCC produce a "may be used uninitialized" error when
DEBUG=0 CFG_TEE_CORE_LOG_LEVEL=3.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

TEE_HANDLE_FLAG_INITIALIZED cleared in tee_svc_cryp_obj_reset()

Signed-off-by: Pascal Brand <pascal.brand@st.com>
Reviewed-by: Jean-Michel DELORME <jean-michel.delorme@st.com>
Reviewed-by: Joakim Be

TEE_HANDLE_FLAG_INITIALIZED cleared in tee_svc_cryp_obj_reset()

Signed-off-by: Pascal Brand <pascal.brand@st.com>
Reviewed-by: Jean-Michel DELORME <jean-michel.delorme@st.com>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Move SMALL_PAGE_* defines to core_mmu.h

Moves SMALL_PAGE_* to core_mmu.h and removes
core/arch/arm/include/mm/tee_mm_def.h

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pas

Move SMALL_PAGE_* defines to core_mmu.h

Moves SMALL_PAGE_* to core_mmu.h and removes
core/arch/arm/include/mm/tee_mm_def.h

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

Add HiKey build instructions to README.md

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@lina

Add HiKey build instructions to README.md

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

GP Internal Core API v1.1 : TEE configuration properties

Signed-off-by: Cedric Chaumont <cedric.chaumont@st.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier

GP Internal Core API v1.1 : TEE configuration properties

Signed-off-by: Cedric Chaumont <cedric.chaumont@st.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Cedric Chaumont <cedric.chaumont@linaro.org> (STM boards)
Tested-by: Cedric Chaumont <cedric.chaumont@linaro.org> (ARM Juno board)

show more ...

Remove RTT0 and RTT1 support

Removes the support for RTT0 and RTT1 as we don't have a port to any
hardware with RTT0 and RTT1.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by:

Remove RTT0 and RTT1 support

Removes the support for RTT0 and RTT1 as we don't have a port to any
hardware with RTT0 and RTT1.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

Update README and setup script for Mediatek Platform

Signed-off-by: James Kung <james.kung@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linar

Update README and setup script for Mediatek Platform

Signed-off-by: James Kung <james.kung@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (MT8173)

show more ...

Add sparse support [C=1]

Adds support to check source files with sparse when C=1 on the command
line. Only files that are recompiled are checked.

Note that sparse isn't very useful at this stage si

Add sparse support [C=1]

Adds support to check source files with sparse when C=1 on the command
line. Only files that are recompiled are checked.

Note that sparse isn't very useful at this stage since the source code
need changes to be more sparse friendly.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

Fix CFG_TEE_CORE_EMBED_INTERNAL_TESTS macro

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.br

Fix CFG_TEE_CORE_EMBED_INTERNAL_TESTS macro

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Clean/simplify supplicant RPC parameters

Tested on HiKey with 32-bit and 64-bit TEE Core.

Note: this commit depends on:
https://github.com/OP-TEE/optee_client/pull/32
https://github.com/OP-TEE/op

Clean/simplify supplicant RPC parameters

Tested on HiKey with 32-bit and 64-bit TEE Core.

Note: this commit depends on:
https://github.com/OP-TEE/optee_client/pull/32
https://github.com/OP-TEE/optee_linuxdriver/pull/22

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...