libutils malloc: fix alignment for arm64

Alignment of returned buffer was prior to this patch set to 8 for all
platforms. This isn't enough for arm64 where some buffers need to be 16
byte aligned i

libutils malloc: fix alignment for arm64

Alignment of returned buffer was prior to this patch set to 8 for all
platforms. This isn't enough for arm64 where some buffers need to be 16
byte aligned instead.

This patch sets required alignment for returned buffers to 8 for ILP32
platforms and 16 for LP64 platforms.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

get rid of platform_flags.mk

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@l

get rid of platform_flags.mk

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU, FVP)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Travis: cache files downloaded from Sourceforge

Sourceforge has been quite unreliable recently, and we have had a
number of build failures due to Tcl or Expect failing to download.
This patch adds t

Travis: cache files downloaded from Sourceforge

Sourceforge has been quite unreliable recently, and we have had a
number of build failures due to Tcl or Expect failing to download.
This patch adds the files to the Travis cache so that they will not
need to be downloaded again unless the cache is purged.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: RPMB (Replay Protected Memory Block) filesystem support

This is an update to the RPMB filesystem implementation so that the
persistent object API may use RPMB rather than the REE filesystem.
T

core: RPMB (Replay Protected Memory Block) filesystem support

This is an update to the RPMB filesystem implementation so that the
persistent object API may use RPMB rather than the REE filesystem.
This feature is enabled with CFG_RPMB_FS=y.
Note that this implementation requires support from the non-secure side
to actually access the RPMB partition, as there is no eMMC driver here.
Also, the code is currently not compatible with CFG_ENC_FS (file
encryption), which must be set to 'n'. Encryption will be added later.

Signed-off-by: Youssef Esmat <youssef.esmat@microsoft.com>
Signed-off-by: Paul Swan <Paul.Swan@microsoft.com>
[Rebased onto master, Linux driver/tee-supplicant support]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

plat-vexpress: Change UART1_BASE and IT_UART1

This is required to move OP-TEE to upstream QEMU.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@lina

plat-vexpress: Change UART1_BASE and IT_UART1

This is required to move OP-TEE to upstream QEMU.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

Remove useless directives -Dxxx in ta_dev_kit.mk

No need to defines CFG_TA_FLOAT_SUPPORT, CFG_TEE_TA_MALLOC_DEBUG and
CFG_TEE_CORE_USER_MEM_DEBUG as not used in .h files of user libraries

Reviewed-

Remove useless directives -Dxxx in ta_dev_kit.mk

No need to defines CFG_TA_FLOAT_SUPPORT, CFG_TEE_TA_MALLOC_DEBUG and
CFG_TEE_CORE_USER_MEM_DEBUG as not used in .h files of user libraries

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Compiles user library using conf.h

Compilation of user libraries now includes conf.h
This makes the definition of CFG_xxx macro more reliable, without
the need of adding specific -D directives in ta

Compiles user library using conf.h

Compilation of user libraries now includes conf.h
This makes the definition of CFG_xxx macro more reliable, without
the need of adding specific -D directives in ta/ta.mk

Note that conf.h and conf.mk are no more generated in the out/core
directory.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Fix final step in SSK generation

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Collin Elhossari <collin.elhossari@

Fix final step in SSK generation

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Collin Elhossari <collin.elhossari@gmail.com>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Replace CFG_TEE_IMPL_VERSION with TEE_IMPL_VERSION

Replaces CFG_TEE_IMPL_VERSION with TEE_IMPL_VERSION to avoid updating
<out-dir>/core/include/generated/conf.h each time description of the current

Replace CFG_TEE_IMPL_VERSION with TEE_IMPL_VERSION

Replaces CFG_TEE_IMPL_VERSION with TEE_IMPL_VERSION to avoid updating
<out-dir>/core/include/generated/conf.h each time description of the current
git commit is changed.

This avoids full recompiles that can't even be cached just because some
files has changed in an updated commit.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: split struct tee_ta_ctx

Moves user ta specific parts into struct user_ta_ctx and static ta
specific parts into struct static_ta_ctx.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested

core: split struct tee_ta_ctx

Moves user ta specific parts into struct user_ta_ctx and static ta
specific parts into struct static_ta_ctx.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM platform)
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: split tee_ta_manager.c

Isolates static and user TA specifics into separate files. Almost no change
in behaviour, except some changes for static TA to be more consistent.

Reviewed-by: Pascal B

core: split tee_ta_manager.c

Isolates static and user TA specifics into separate files. Almost no change
in behaviour, except some changes for static TA to be more consistent.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Add __rodata_unpaged macro

Adds a __rodata_unpaged macro that will put the object in the unpaged
rodata section.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jen

Add __rodata_unpaged macro

Adds a __rodata_unpaged macro that will put the object in the unpaged
rodata section.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: Add KEEP_PAGER() and KEEP_INIT() macros

Adds KEEP_PAGER(sym) and KEEP_INIT(sym) macros which makes supplied
symbol available for pager or init code respectively.

Reviewed-by: Joakim Bech <joa

core: Add KEEP_PAGER() and KEEP_INIT() macros

Adds KEEP_PAGER(sym) and KEEP_INIT(sym) macros which makes supplied
symbol available for pager or init code respectively.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Release notes

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

FSL-LS1021A platform is publicly available

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

README: update toolchain versions

As suggested by https://github.com/oliviermartin in #597,
toolchain versions to be used are updated.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by:

README: update toolchain versions

As suggested by https://github.com/oliviermartin in #597,
toolchain versions to be used are updated.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

doc: remove references to big lock

Big lock is not used in the source any more, remove it from
documentation too.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Signed-off-by: Jens Wiklander <

doc: remove references to big lock

Big lock is not used in the source any more, remove it from
documentation too.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Remove unused functions

After finding a set of functions potentially not used anywhere (using
gcc -Wl,--print-gc-sections) I did grep'd for those functions and the
ones that couldn't be found to be

Remove unused functions

After finding a set of functions potentially not used anywhere (using
gcc -Wl,--print-gc-sections) I did grep'd for those functions and the
ones that couldn't be found to be used anywhere has been deleted
(although utility functions, LibTomCrypt etc hasn't been touched).

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU)
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Adjust the optional flags according to TA_FLAG_INSTANCE_KEEP_ALIVE

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand

Adjust the optional flags according to TA_FLAG_INSTANCE_KEEP_ALIVE

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Paul Swan <paswan@microsoft.com>
Tested-by: Youssef Esmat <Youssef.Esmat@microsoft.com>
Signed-off-by: Paul Swan <paswan@microsoft.com>

show more ...

core config: generate conf.mk preserves CFG_xxx=n

The generated conf.mk configuration file no more replaces
CFG_xxx=n with commented configuration settings "# CFG_xxx is
not set" and preserve the CF

core config: generate conf.mk preserves CFG_xxx=n

The generated conf.mk configuration file no more replaces
CFG_xxx=n with commented configuration settings "# CFG_xxx is
not set" and preserve the CFG_xxx=n setting.

This allows one to fully reuse the generated conf.mk as an
input configuration to regenerate the firmware with the
same configuration directive.

Reviewed-by: Etienne CARRIERE <etienne.carriere@st.com>
Tested-by: Etienne CARRIERE <etienne.carriere@st.com>
Reviewed-by: Pascal BRAND <pascal.brand@st.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU)

show more ...

core: trace_syscall(): print the syscall name in addition to its number

When CFG_TEE_CORE_LOG_LEVEL >= 4, a debug trace is printed whenever a
system call is entered. Currently it just prints the sys

core: trace_syscall(): print the syscall name in addition to its number

When CFG_TEE_CORE_LOG_LEVEL >= 4, a debug trace is printed whenever a
system call is entered. Currently it just prints the syscall number,
which is not very convenient. This commit adds the name of the syscall
function to the trace.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

arm32: tee_svc_do_call() must preserve r5 and r6

Since the assembly function tee_svc_do_call() uses registers r5 and r6,
it must push them on entry and restore them on exit.

Signed-off-by: Jerome F

arm32: tee_svc_do_call() must preserve r5 and r6

Since the assembly function tee_svc_do_call() uses registers r5 and r6,
it must push them on entry and restore them on exit.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix 64-bit build errors when CFG_TEE_TA_LOG_LEVEL == TRACE_FLOW (4)

$ make -j9 PLATFORM=hikey CFG_ARM64_core=y \
CROSS_COMPILE_core=aarch64-linux-gnu- \
CROSS_COMPILE_ta_arm64=aarch64-linux-gnu-

Fix 64-bit build errors when CFG_TEE_TA_LOG_LEVEL == TRACE_FLOW (4)

$ make -j9 PLATFORM=hikey CFG_ARM64_core=y \
CROSS_COMPILE_core=aarch64-linux-gnu- \
CROSS_COMPILE_ta_arm64=aarch64-linux-gnu- \
CFG_TEE_TA_LOG_LEVEL=4
[...]
lib/libutee/tee_user_mem.c: In function ‘heap_inc’:
lib/libutee/tee_user_mem.c:195:2: error: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘size_t’ [-Werror=format=]
INMSG("%d", size);
^

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

ltc: mutex support, in case of no mutex

Some platforms, other than arm, may not support multiple
threads, or may have other support than the LTC_OPTEE_THREAD
thread scheme.

This patch defines LTC_O

ltc: mutex support, in case of no mutex

Some platforms, other than arm, may not support multiple
threads, or may have other support than the LTC_OPTEE_THREAD
thread scheme.

This patch defines LTC_OPTEE_THREAD for arm only platform,
and defines the no mutex mechanism in libtomcrypt

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (QEMU)
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Secure Storage: fixed potential error while creating persistent object

Following is the issue description:

If we failed to create meta file while creating a new persistent
object. We will leave a e

Secure Storage: fixed potential error while creating persistent object

Following is the issue description:

If we failed to create meta file while creating a new persistent
object. We will leave a empty tee folder in ree filesystem.

Next time when we want to create tee file when the same object id,
it will fail because the folder is already existed.

The patch solves this issue by checking if meta file is existed,
instead of just checking if the folder is existed.

Signed-off-by: SY Chiu <sy.chiu@linaro.org>
Tested-by: SY Chiu <sy.chiu@linaro.org> (MT8173)
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...