core: fix build error with CFG_TEE_CORE_DEBUG=y

Fixes build error when CFG_TEE_CORE_DEBUG=y and CFG_WITH_PAGER=y are set
by adding ing CORE_MMU_PGDIR_SIZE and CORE_MMU_PGDIR_MASK.

Reviewed-by: Pasc

core: fix build error with CFG_TEE_CORE_DEBUG=y

Fixes build error when CFG_TEE_CORE_DEBUG=y and CFG_WITH_PAGER=y are set
by adding ing CORE_MMU_PGDIR_SIZE and CORE_MMU_PGDIR_MASK.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix potential memory corruptions in elf_load.c when loading TAs

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Jaso

Fix potential memory corruptions in elf_load.c when loading TAs

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Jason Lin <Jason.Lin@microsoft.com>
Suggested-by: Paul Swan <Paul.Swan@microsoft.com>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

docs: Remove modprobe instruction

Since we no longer use a dynamically loadable module as the TEE driver
we have removed that from the README.md file.

Signed-off-by: Joakim Bech <joakim.bech@linaro

docs: Remove modprobe instruction

Since we no longer use a dynamically loadable module as the TEE driver
we have removed that from the README.md file.

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

plat-ls: tested with Release 2.0.0

Signed-off-by: Pascal Brand <pascal.brand@st.com>

Release Notes 2.0.0

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

Fix wrong comment syntax

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

ARM Juno GP testsuite support note

Signed-off-by: Cedric Chaumont <cedric.chaumont@st.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

Update Juno documentation

Updates Juno documentation and removes obsolete scripts and patches.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Cedric Chaumont <cedric.chaumont@lina

Update Juno documentation

Updates Juno documentation and removes obsolete scripts and patches.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Cedric Chaumont <cedric.chaumont@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

juno: bug fix initialize TCR_EL1

Prior to this patch TCR_EL1 was incorrectly initialized with bit 32 set
to 0. On Cortex-A57 this bit is RES1 so this bit should always be set to
1, this patch fixes

juno: bug fix initialize TCR_EL1

Prior to this patch TCR_EL1 was incorrectly initialized with bit 32 set
to 0. On Cortex-A57 this bit is RES1 so this bit should always be set to
1, this patch fixes that.

This is related to errata 822227
"Using unsupported 16K translation granules might cause Cortex-A57 to
incorrectly trigger a domain fault"

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (Juno)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Validate the TA signed header's img_size

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Jason Lin <Jason.Lin@microsoft.com>
Suggested-by: Paul Swan <Paul.Swan@microsoft.com>
S

Validate the TA signed header's img_size

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Suggested-by: Jason Lin <Jason.Lin@microsoft.com>
Suggested-by: Paul Swan <Paul.Swan@microsoft.com>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

stm,vexpress: increase shared memory size from 1 to 2 MiB

This is needed to run the latest "generic driver" configuration.
When the shared memory pool is 1 MiB, xtest 7633 fails with a TA panic
due

stm,vexpress: increase shared memory size from 1 to 2 MiB

This is needed to run the latest "generic driver" configuration.
When the shared memory pool is 1 MiB, xtest 7633 fails with a TA panic
due to memory allocation error. This commit increases the size of the
shared memory pool so that the test will pass.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

core: arm: pager: lock shared accesses

Uses the pager spin-lock for all shared accesses to pager resources.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Jerome Forissier <jerome.f

core: arm: pager: lock shared accesses

Uses the pager spin-lock for all shared accesses to pager resources.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU FVP)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

optee_msg: add OPTEE_MSG_RPC_CMD_SHM_FREE

Buffers allocated with OPTEE_MSG_RPC_CMD_SHM_ALLOC must be freed
with OPTEE_MSG_RPC_CMD_SHM_FREE to help normal world driver to
route the message correctly.

optee_msg: add OPTEE_MSG_RPC_CMD_SHM_FREE

Buffers allocated with OPTEE_MSG_RPC_CMD_SHM_ALLOC must be freed
with OPTEE_MSG_RPC_CMD_SHM_FREE to help normal world driver to
route the message correctly.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

libtomcrypt: mpa_desc.c: check return status of allocations

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal

libtomcrypt: mpa_desc.c: check return status of allocations

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

fs: do not call thread_rpc_free() when allocation fails

When thread_rpc_alloc_payload() fails, the cookie is not valid, so
thread_rpc_free() must not be called. This fixes a crash in xtest
7633 when

fs: do not call thread_rpc_free() when allocation fails

When thread_rpc_alloc_payload() fails, the cookie is not valid, so
thread_rpc_free() must not be called. This fixes a crash in xtest
7633 when shared memory is not large enough.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

hikey: increase shared memory size from 1 to 2 MiB

This is needed to run the latest "generic driver" configuration.
When the shared memory pool is 1 MiB, xtest 7633 fails with a TA panic
due to memo

hikey: increase shared memory size from 1 to 2 MiB

This is needed to run the latest "generic driver" configuration.
When the shared memory pool is 1 MiB, xtest 7633 fails with a TA panic
due to memory allocation error. This commit increases the size of the
shared memory pool so that the test will pass.
Note that UEFI (EDK2) reserves the top 32 MiB of the physical address
space (0x3E000000-0x3FFFFFFF) for OP-TEE, so we still have 14 MiB unused
(0x3E000000-0x3EDFFFFF).

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

mk/config.mk: hardcode CFG_OPTEE_REVISION_{MAJOR,MINOR}

There is really no guarantee that the values of CFG_OPTEE_REVISION_MAJOR
and CFG_OPTEE_REVISION_MINOR can be extracted from Git (think about
b

mk/config.mk: hardcode CFG_OPTEE_REVISION_{MAJOR,MINOR}

There is really no guarantee that the values of CFG_OPTEE_REVISION_MAJOR
and CFG_OPTEE_REVISION_MINOR can be extracted from Git (think about
building from a tarball or "git clone --depth=1"), so let's just hardcode
them into the configuration.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>

show more ...

LTC: no definition of LTC_NO_FAST

LTC_NO_FAST resets LTC_FAST if the latter has been set.
Indeed, LTC_FAST is never set on ARM architecture,
so LTC_NO_FAST has no effect

Reviewed-by: Jerome Forissi

LTC: no definition of LTC_NO_FAST

LTC_NO_FAST resets LTC_FAST if the latter has been set.
Indeed, LTC_FAST is never set on ARM architecture,
so LTC_NO_FAST has no effect

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

CFG_CRYPTO_SIZE_OPTIMIZATION?=y by default

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.bra

CFG_CRYPTO_SIZE_OPTIMIZATION?=y by default

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

Rename libtomcrypt_with_optimize_size in CFG_CRYPTO_SIZE_OPTIMIZATION

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-b

Rename libtomcrypt_with_optimize_size in CFG_CRYPTO_SIZE_OPTIMIZATION

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...

arm: sm: [bugfix] save/restore fiq core registers

Currently there's a security problem with the FIQ registers for armv7
targets, both with leaking information and that normal world can change
stack

arm: sm: [bugfix] save/restore fiq core registers

Currently there's a security problem with the FIQ registers for armv7
targets, both with leaking information and that normal world can change
stack pointer for FIQ mode. This patch fixes this problem.

Saves and restores FIQ core registers (spsr, sp, lr) when switching
secre/non-secure state.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Tested-by: Pascal Brand <pascal.brand@linaro.org> (STM)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (modified QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: add build target for minimal OP-TEE

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.foriss

travis: add build target for minimal OP-TEE

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Minimal OP-TEE without user TAs

Hide all user TA related code under CFG_WITH_USER_TA. When compiled
with:
CFG_WITH_USER_TA=n
CFG_CRYPTO=n
CFG_ENC_FS=n
CFG_SE_API=n
CFG_PCSC_PASSTHRU_READER_DRV=n

Sk

Minimal OP-TEE without user TAs

Hide all user TA related code under CFG_WITH_USER_TA. When compiled
with:
CFG_WITH_USER_TA=n
CFG_CRYPTO=n
CFG_ENC_FS=n
CFG_SE_API=n
CFG_PCSC_PASSTHRU_READER_DRV=n

Skips building in static TA tests for features not enabled.

The size of OP-TEE is reduced to one third of its original size.

Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU xtest 1001)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Travis: QEMU check: use travis.xml manifest to speed up repo download

travis.xml clones the Git repositories with depth 1, thereby reducing
the duration of the "repo sync" step from 4-6 minutes down

Travis: QEMU check: use travis.xml manifest to speed up repo download

travis.xml clones the Git repositories with depth 1, thereby reducing
the duration of the "repo sync" step from 4-6 minutes down to about 1
min.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Pascal Brand <pascal.brand@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

arm: fix stack size

According to GP Internal API, TA_STACK_SIZE corresponds to the stack
size used by the TA code itself and does not include stack space
possibly used by the Trusted Core Framework.

arm: fix stack size

According to GP Internal API, TA_STACK_SIZE corresponds to the stack
size used by the TA code itself and does not include stack space
possibly used by the Trusted Core Framework.
Hence, stack_size which is the size of the stack to use,
must be enlarged.

Without this patch, on FVP, xtest 1012, based on ta/sims, fails because
TA_STACK_SIZE is defined as 1024, which is too low.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Pascal Brand <pascal.brand@st.com>

show more ...