plat-stm: discard orly2 flavor

stm default plavor is 96board_c2.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: J

plat-stm: discard orly2 flavor

stm default plavor is 96board_c2.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

plat-stm: beautify platform config

Move platform config to platfom_config.h.
Remove local system_config.mk.

Add generic SCU SAC/NSAC registers bit fields definition.
Add generic PL310 control regis

plat-stm: beautify platform config

Move platform config to platfom_config.h.
Remove local system_config.mk.

Add generic SCU SAC/NSAC registers bit fields definition.
Add generic PL310 control register enable bit fields definition.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

plat-stm: beautify source code

Move plat_cpu_reset_late() to C-source.
Move arm_cl2_config() to C-source.
Beautify main.c and rng_support.c.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro

plat-stm: beautify source code

Move plat_cpu_reset_late() to C-source.
Move arm_cl2_config() to C-source.
Beautify main.c and rng_support.c.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

syscall_log: do not prepend TEE core prefix

Fixes the debug output of Trusted Applications. For example:
- Previous output:
ERROR: TEE-CORE: DEBUG: USER-TA:TA_CreateEntryPoint:41: Blah
- New out

syscall_log: do not prepend TEE core prefix

Fixes the debug output of Trusted Applications. For example:
- Previous output:
ERROR: TEE-CORE: DEBUG: USER-TA:TA_CreateEntryPoint:41: Blah
- New output:
DEBUG: USER-TA:TA_CreateEntryPoint:41: Blah

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU)
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ta_dev_kit.mk: get optional flags from $(CFLAGS_$(sm))/$(CPPFLAGS_$(sm))

This provides an easy way to append some flags to the TA build, for
instance: `make CFLAGS_ta_arm64=-O0' to disable optimizat

ta_dev_kit.mk: get optional flags from $(CFLAGS_$(sm))/$(CPPFLAGS_$(sm))

This provides an easy way to append some flags to the TA build, for
instance: `make CFLAGS_ta_arm64=-O0' to disable optimizations in 64-bit
TAs.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

doc: Update documentation/rpi3.md

updating to correct manifest.

Signed-off-by: Arun Jayadharan <arunjr@gmail.com>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

doc: Add NFS boot and TFTP instructions for RPi3

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

core: mmu: avoid panic in check_pa_matches_va()

If check_pa_matches_va() is called before the user va range has been
defined with CFG_WITH_LPAE=y it will cause a panic during boot. This
change adds

core: mmu: avoid panic in check_pa_matches_va()

If check_pa_matches_va() is called before the user va range has been
defined with CFG_WITH_LPAE=y it will cause a panic during boot. This
change adds a function to test that user va range is defined before
reading it.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: avoid panic in thread_addr_is_in_stack()

Avoids panic in thread_addr_is_in_stack() by returning false
if there's no current thread.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

core: avoid panic in thread_addr_is_in_stack()

Avoids panic in thread_addr_is_in_stack() by returning false
if there's no current thread.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: workaround false positive in code checking tool

Workaround a checkpatch bug [1] by creating a non-empty file
const_structs.checkpatch. By adding the name of a struct that cannot
appear in va

travis: workaround false positive in code checking tool

Workaround a checkpatch bug [1] by creating a non-empty file
const_structs.checkpatch. By adding the name of a struct that cannot
appear in valid code, we avoid the false warning (which occurs only
when no name is given) and this can't produce any unwanted side-effect.

[1] https://www.spinics.net/lists/kernel/threads.html#2364905

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove CFG_ENC_FS

Removes CFG_ENC_FS, encryption is always enabled in the file systems from
now on.

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey 32/64 GP)
Tested-by: Etien

core: remove CFG_ENC_FS

Removes CFG_ENC_FS, encryption is always enabled in the file systems from
now on.

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey 32/64 GP)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu_v8/b2260, reefs/sqlfs, gp testsuite)
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: remove CFG_ENC_FS

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: remove object checks in syscall_storage_start_enum()

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: remove unneeded calls to tee_obj_verify()

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: tee_fs_rpc: hide internal definitions

Moves internal definitions in tee_fs_rpc.h to tee_fs_rpc.c.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <je

core: tee_fs_rpc: hide internal definitions

Moves internal definitions in tee_fs_rpc.h to tee_fs_rpc.c.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add RPC FS cache for payload data

Adds an RPC FS cache for payload data. Allocated RPC FS payload data isn't
free until the thread exits the current command. This allows reuse of the
memory al

core: add RPC FS cache for payload data

Adds an RPC FS cache for payload data. Allocated RPC FS payload data isn't
free until the thread exits the current command. This allows reuse of the
memory allocation, avoiding many needless entries of tee-supplicant.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: optimize tee_svc_storage_read_head()

Optimizes tee_svc_storage_read_head() by leaving the file descriptor
open in the struct tee_obj.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.or

core: optimize tee_svc_storage_read_head()

Optimizes tee_svc_storage_read_head() by leaving the file descriptor
open in the struct tee_obj.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_obj_alloc() initialize file descriptor

tee_obj_alloc() initializes file descriptor in struct tee_obj to -1
to mark it invalid.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

core: tee_obj_alloc() initialize file descriptor

tee_obj_alloc() initializes file descriptor in struct tee_obj to -1
to mark it invalid.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_obj_close() close all persistent objects

tee_obj_close() closes all persistent objects regardless of the 'fd'
field. The 'close' operation is only called if 'fd' is positive.

Reviewed-by:

core: tee_obj_close() close all persistent objects

tee_obj_close() closes all persistent objects regardless of the 'fd'
field. The 'close' operation is only called if 'fd' is positive.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm: kern.ld.S: put the RO sections together

By putting all the ro sections together, we can easily mark them
as RO.

Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
Reviewed-by: Jens Wikla

core: arm: kern.ld.S: put the RO sections together

By putting all the ro sections together, we can easily mark them
as RO.

Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core_mmu: fix the ttb pa address setting

Using the real physic address to set the mmu ttbr, and don't rely on the
plat mapping.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-

core_mmu: fix the ttb pa address setting

Using the real physic address to set the mmu ttbr, and don't rely on the
plat mapping.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
[Rebased on top of master]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

plat-stm/plat-imx: fix SCR initialization

Secure Configuration Register shall be initialized for all cores.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander

plat-stm/plat-imx: fix SCR initialization

Secure Configuration Register shall be initialized for all cores.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: run "make check" with CFG_TEE_CORE_DEBUG=y to enable assertions

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

crypto: ltc: add missing CBC_MAC algorithms to cipher_final()

Make sure that all the code paths leading to cipher_final() are
properly handled. Then, the 'default:' case cannot occur; add an
assert(

crypto: ltc: add missing CBC_MAC algorithms to cipher_final()

Make sure that all the code paths leading to cipher_final() are
properly handled. Then, the 'default:' case cannot occur; add an
assert() there. Fixes an assertion failure with xtest 4002 when
CFG_TEE_CORE_DEBUG=y.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: Zeng Tao <prime.zeng@hisilicon.com>
Fixes: 287359f44187 ("crypto: fix incorrect algo passed to cipher.final()")
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Zeng Tao <prime.zeng@hisilicon.com>

show more ...

build: include submodule in name of per-library variables

Because a library may be built several times for different submodules
(for example, libutils.a is built differently for kernel and user
mode

build: include submodule in name of per-library variables

Because a library may be built several times for different submodules
(for example, libutils.a is built differently for kernel and user
mode), the names of the variables that hold library-specific flags
have to uniquely identify the instance of the library that's being
built.

Example use case: to build libutils with flag FOO for the core and
flag BAR for the user mode, add this to lib/libutils/sub.mk:

ifeq ($(sm),core)
cppflags-lib-y += -DFOO
else
cppflags-lib-y += -DBAR
endif

Without this fix, the above would fail because all the flags would
be added to all the builds of libutils.

Fixes: 3d34e125a253 ("Add support for $(cflags-lib-y)")
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...