travis: add CFG_CORE_SANITIZE_{UNDEFINED,KADDRESS}

Adds test compiles for QEMU virt with CFG_CORE_SANITIZE_UNDEFINED and
CFG_CORE_SANITIZE_KADDRESS.

Reviewed-by: Etienne Carriere <etienne.carriere@

travis: add CFG_CORE_SANITIZE_{UNDEFINED,KADDRESS}

Adds test compiles for QEMU virt with CFG_CORE_SANITIZE_UNDEFINED and
CFG_CORE_SANITIZE_KADDRESS.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add support for kernel address sanitizer

Adds support for kernel address sanitizer.
Currently only for plat-vexpress-qemu_virt.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tes

core: add support for kernel address sanitizer

Adds support for kernel address sanitizer.
Currently only for plat-vexpress-qemu_virt.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU v7)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add .early_bss section

Adds .early_bss to be used for variables that would normally land in
.bss, but must not since they are updated before .bss is cleared. This
section replaces earlier work

core: add .early_bss section

Adds .early_bss to be used for variables that would normally land in
.bss, but must not since they are updated before .bss is cleared. This
section replaces earlier workarounds using __data for such variables.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm: rename _end symbol to __end

Renames the _end symbol to __end for consistency with other linker
symbols.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wi

core: arm: rename _end symbol to __end

Renames the _end symbol to __end for consistency with other linker
symbols.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ltc: sync from official develop branch

All source files under src directory and header files under include
directory have been synced, but have not added all macros newly added
in official develop b

ltc: sync from official develop branch

All source files under src directory and header files under include
directory have been synced, but have not added all macros newly added
in official develop branch and the last synced SHA1 in official
develop branch is 6ad52252688bb34f90b5e79da4830a927e87b81f

Signed-off-by: Matt Ma <matt.ma@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Reviewed-by: David Brown <david.brown@linaro.org>

show more ...

trace.h: add macros to unwind and print the call stack (kernel only)

Adds [EIDF]PRINT_STACK() for debugging purposes. Depends on
CFG_CORE_UNWIND=y.
As a side-effect, also adds a few things that may

trace.h: add macros to unwind and print the call stack (kernel only)

Adds [EIDF]PRINT_STACK() for debugging purposes. Depends on
CFG_CORE_UNWIND=y.
As a side-effect, also adds a few things that may be useful on their
own: __always_inline, read_pc(), read_fp(), read_lr().

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm64: SMC handler: initialize frame pointer to 0

init_regs() should set the frame pointer (x29) to zero to indicate the
end of the frame record chain, as required by the Aarch64 AAPCS.
Withou

core: arm64: SMC handler: initialize frame pointer to 0

init_regs() should set the frame pointer (x29) to zero to indicate the
end of the frame record chain, as required by the Aarch64 AAPCS.
Without this, there is no guarantee that unwind_stack() will terminate.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: run coding style tool on each commit in a pull request

`git format-patch --stdout -1` do not work as expected. In addition to
checking only one commit (as opposed to all the commits in a PR)

travis: run coding style tool on each commit in a pull request

`git format-patch --stdout -1` do not work as expected. In addition to
checking only one commit (as opposed to all the commits in a PR), it
may pick the wrong commit. For instance, when the PR contains several
commits, it shows the tip of the target branch instead of the tip of
the PR branch. So we have to modify the way the commits are selected.

There are two reasons why a Travis build is triggered: either a pull
request, or a branch is pushed to a monitored repository. One can tell
the two cases appart thanks to the $TRAVIS_PULL_REQUEST environment
variable.

- In the first case (pull request), HEAD is always a merge commit
between the development branch and the target branch. Use `git
rev-list` to expand the list of commits in HEAD^1..HEAD^2 (those that
are in the dev branch but not in the target branch) and ask
format-patch to show exactly those commits with `-1 <commit-sha1>`.
As a result, all the patches will be checked individually.
- In the second case (not a pull request), HEAD is typically not a
merge, it is simply the tip of the development branch being monitored.
Using '-1 HEAD' is fine.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

storage: sqlfs: save memory when sql_fs_ftruncate() extends a file

There is no need to actually allocate a buffer filled with zeroes in
sql_fs_ftruncate(). Instead, update write_block_partial() so t

storage: sqlfs: save memory when sql_fs_ftruncate() extends a file

There is no need to actually allocate a buffer filled with zeroes in
sql_fs_ftruncate(). Instead, update write_block_partial() so that a
NULL data pointer means all null bytes. This eliminates a large (4K)
temporary allocation.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

libutils: promote mdbg_check() messages to TRACE_INFO from TRACE_DEBUG

The memory tracing feature enabled by CFG_TEE_CORE_MALLOC_DEBUG=y or
CFG_TEE_TA_MALLOC_DEBUG=y is quite convenient to track mem

libutils: promote mdbg_check() messages to TRACE_INFO from TRACE_DEBUG

The memory tracing feature enabled by CFG_TEE_CORE_MALLOC_DEBUG=y or
CFG_TEE_TA_MALLOC_DEBUG=y is quite convenient to track memory leaks or
other shortages. Unfortunately, the allocation summary is dumped with
the TRACE_DEBUG severity so it is easily burried in lots of debug
output. In addition, tracking memory leaks frequently involves running
code in a loop, so that the leak better stands out from other
allocations. Doing so with debug logs enabled tends to slow things down
more than necessary.

Therefore this commit promotes the mdbg_check() message to TRACE_INFO.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: build with CFG_TEE_CORE_MALLOC_DEBUG=y

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wikla

travis: build with CFG_TEE_CORE_MALLOC_DEBUG=y

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix compile error when CFG_TEE_CORE_MALLOC_DEBUG=y

When CFG_TEE_CORE_MALLOC_DEBUG is enabled, but CFG_TEE_CORE_DEBUG is
not, the compiler complains about unused parameters/functions. Fix them

core: fix compile error when CFG_TEE_CORE_MALLOC_DEBUG=y

When CFG_TEE_CORE_MALLOC_DEBUG is enabled, but CFG_TEE_CORE_DEBUG is
not, the compiler complains about unused parameters/functions. Fix them
by adding __maybe_unused qualifiers.

lib/libutils/isoc/bget_malloc.c: In function ‘assert_header’:
lib/libutils/isoc/bget_malloc.c:688:44: error: unused parameter ‘hdr’ [-Werror=unused-parameter]
static void assert_header(struct mdbg_hdr *hdr)
^
lib/libutils/isoc/bget_malloc.c: At top level:
lib/libutils/isoc/bget_malloc.c:595:16: error: ‘bget_buf_size’ defined but not used [-Werror=unused-function]
static bufsize bget_buf_size(void *buf)
^
cc1: all warnings being treated as errors

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

rpmb: move rpmb_mutex to fs layer

In rpmb_fs_write(), if other session write RPMB between read_fat() and
tee_rpmb_write(), it may write to the same address. So move rpmb_mutex
to fs layer for concur

rpmb: move rpmb_mutex to fs layer

In rpmb_fs_write(), if other session write RPMB between read_fat() and
tee_rpmb_write(), it may write to the same address. So move rpmb_mutex
to fs layer for concurrency scenarios.

Signed-off-by: Lijianhui (Airbak) <airbak.li@hisilicon.com>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add memory type MEM_AREA_RAM_SEC, MEM_AREA_RAM_NSEC

replace memory type MEM_AREA_KEYVAULT with MEM_AREA_RAM_SEC
MEM_AREA_RAM_SEC: for cached, secure memory
MEM_AREA_RAM_NSEC: for cached, nonse

core: add memory type MEM_AREA_RAM_SEC, MEM_AREA_RAM_NSEC

replace memory type MEM_AREA_KEYVAULT with MEM_AREA_RAM_SEC
MEM_AREA_RAM_SEC: for cached, secure memory
MEM_AREA_RAM_NSEC: for cached, nonsecure memory

Signed-off-by: Pengguang Zhu <zpghao@163.com>
Reviewed-by: etienne carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: fix coding style path exclusion

Commit 0bbd70a5c13c ("travis: exclude some paths when running the
coding style tool") is broken in several ways:

- It will not properly exclude the specified

travis: fix coding style path exclusion

Commit 0bbd70a5c13c ("travis: exclude some paths when running the
coding style tool") is broken in several ways:

- It will not properly exclude the specified paths from the diff output
because the exclamation mark (!) is not correctly protected when
setting $_CP_EXCL. Let's use ":(exclude)" instead of ":!".
- Even with the above fixed, Travis runs an older version of Git that
does not support pathspec magic ":!" or ":(exclude)". Address that by
compiling Git 2.9.3 from source. This adds about 60-75 seconds to the
build time with a cold cache, 8 seconds when the cache is warm.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

rsa_verify_hash: fix possible bleichenbacher signature attack

Fixes CVE-2016-6129

cherry-picked from:
https://github.com/libtom/libtomcrypt/commit/5eb9743410ce4657e9d54fef26a2ee31a1b5dd09

Acked-by

rsa_verify_hash: fix possible bleichenbacher signature attack

Fixes CVE-2016-6129

cherry-picked from:
https://github.com/libtom/libtomcrypt/commit/5eb9743410ce4657e9d54fef26a2ee31a1b5dd09

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

travis: build rcar platform

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globallogic.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissi

travis: build rcar platform

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globallogic.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

Add RCAR H3 platform support

Added support for Renesas RCAR devices. Initially RCAR H3 is supported.

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globallogic.com>
Reviewed-by: Jens Wiklander

Add RCAR H3 platform support

Added support for Renesas RCAR devices. Initially RCAR H3 is supported.

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globallogic.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

drivers: add SCIF driver

SCIF stands for "Serial Communication Interface with FIFO".
It is an UART device used on different Renesas SoCs.

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globall

drivers: add SCIF driver

SCIF stands for "Serial Communication Interface with FIFO".
It is an UART device used on different Renesas SoCs.

Signed-off-by: Volodymyr Babchuk <volodymyr.babchuk@globallogic.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

libfdt: undef sanitizer fix fdt_setprop()

Fixes undefined sanitizer problem in fdt_setprop().

The compiler (gcc 5.3) issues some runtime checks with
-fsanitize=undefined which is triggered if for i

libfdt: undef sanitizer fix fdt_setprop()

Fixes undefined sanitizer problem in fdt_setprop().

The compiler (gcc 5.3) issues some runtime checks with
-fsanitize=undefined which is triggered if for instance any of the
pointers supplied to memcpy() is NULL as val can be in fdt_setprop() if
there's no value.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMUv7)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: build for PLATFORM=stm and default flavor

This would previously fail. Fixed by parent commit.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.

travis: build for PLATFORM=stm and default flavor

This would previously fail. Fixed by parent commit.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Fix invalid default value of $(PLATFORM_FLAVOR)

Fixes the following error:

$ make -s PLATFORM=stm
core/arch/arm/plat-stm/system_config.mk:20:
*** PLATFORM_FLAVOR=qemu_virt is not supporte

Fix invalid default value of $(PLATFORM_FLAVOR)

Fixes the following error:

$ make -s PLATFORM=stm
core/arch/arm/plat-stm/system_config.mk:20:
*** PLATFORM_FLAVOR=qemu_virt is not supported. Stop.

(one would expect PLATFORM_FLAVOR to default to 'orly2').
This patch does the following:

- Do not set "PLATFORM_FLAVOR ?= qemu_virt" in the main Makefile. The
default value for PLATFORM_FLAVOR has to be defined by each platform in
plat-*/conf.mk.
- Consistent with the above, "PLATFORM_FLAVOR_$(PLATFORM_FLAVOR) := y"
is moved to core/core.mk, after $(platform-dir)/conf.mk has been
included, i.e., where $(PLATFORM_FLAVOR) can be relied upon.
- All definitions of "PLATFORM_FLAVOR_$(PLATFORM_FLAVOR) := y"
are removed from platform files, since it is already taken care of in
core/core.mk.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

build: add PLATFORM_FLAVOR for BUILD_OPTEE_OS

fix build error:
In file included from core/arch/arm/kernel/thread.c:29:0:
core/arch/arm/plat-aquila/./platform_config.h:51:2: error: #error "Unknown pl

build: add PLATFORM_FLAVOR for BUILD_OPTEE_OS

fix build error:
In file included from core/arch/arm/kernel/thread.c:29:0:
core/arch/arm/plat-aquila/./platform_config.h:51:2: error: #error "Unknown platform flavor"
#error "Unknown platform flavor"

Signed-off-by: Zhizhou Zhang <zhizhou.zh@gmail.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

Fix static TA memory leak

The static TA context allocated in tee_ta_init_static_ta_session() is
never freed. Do it in static_ta_destroy().

Test case:
while [ true ]; do \
xtest 1001 >/dev/nul

Fix static TA memory leak

The static TA context allocated in tee_ta_init_static_ta_session() is
never freed. Do it in static_ta_destroy().

Test case:
while [ true ]; do \
xtest 1001 >/dev/null 2>&1 || break; \
i=$(($i+1)); \
if [ $(($i % 10)) -eq 0 ]; then echo $i; fi; \
done

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: JunLin Quan <junlin.quan@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

[Review] Oops, stc might still be used after free

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: arm64: fix masking exceptions on normal exit

Before this patch debug and asynchronous abort wasn't masked
when doing a normal return from call. This patch fixes that.

Reviewed-by: Etienne Car

core: arm64: fix masking exceptions on normal exit

Before this patch debug and asynchronous abort wasn't masked
when doing a normal return from call. This patch fixes that.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMUv8)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...