core: Add default CFG_CORE_HEAP_SIZE

Adds a CFG_CORE_HEAP_SIZE replacing the defined HEAP_SIZE in each
platform_config.h. Default value is defined in mk/config.mk as 64 kB.
This is larger than most

core: Add default CFG_CORE_HEAP_SIZE

Adds a CFG_CORE_HEAP_SIZE replacing the defined HEAP_SIZE in each
platform_config.h. Default value is defined in mk/config.mk as 64 kB.
This is larger than most of the previous values at 24 kB or just above.

Platforms with a previous heap size defined larger than 64 kB overrides
the mk/config.mk setting with a $(platform-dir)/conf.mk setting using the
previous value.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (Hikey pager)
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU v7 pager)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (FVP Aarch32 pager)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add default CFG_CORE_TZSRAM_EMUL_SIZE

Adds a CFG_CORE_TZSRAM_EMUL_SIZE replacing the previous value directly
defined in TZSRAM_SIZE in each platform_config.h. Default value is
defined in core/

core: add default CFG_CORE_TZSRAM_EMUL_SIZE

Adds a CFG_CORE_TZSRAM_EMUL_SIZE replacing the previous value directly
defined in TZSRAM_SIZE in each platform_config.h. Default value is
defined in core/arch/arm/arm.mk as 300 kB. This is larger than most of
the previous values.

Platforms with TZSRAM_SIZE defined larger than 200 kB overrides the
core/arch/arm/arm.mk setting with a $(platform-dir)/conf.mk setting
using the previous value.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

scripts: Add tee_bin_parser.py

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

scripts: gen_hashed_bin.py Python 3.x support

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

scripts: render_font.py for Python 2.x and 3.x

Verified that the output is identical on Python 2.7.12 and Python 3.5.2.

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Foris

scripts: render_font.py for Python 2.x and 3.x

Verified that the output is identical on Python 2.7.12 and Python 3.5.2.

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

Add the i.MX6 Quad SABRE board support (PLATFORM=imx)

Signed-off-by: Yan Yan <yan.yan@windriver.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.for

Add the i.MX6 Quad SABRE board support (PLATFORM=imx)

Signed-off-by: Yan Yan <yan.yan@windriver.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>

show more ...

doc: Add documentation for OP-TEE verification

Gives a brief description on how to enable the verification for OP-TEE
using the authentication framework in ATF

Signed-off-by: Matt Ma <matt.ma@linar

doc: Add documentation for OP-TEE verification

Gives a brief description on how to enable the verification for OP-TEE
using the authentication framework in ATF

Signed-off-by: Matt Ma <matt.ma@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

travis: Add RPi3 target

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

syscall storage_obj_seek: fix sign extension

Fixes problem with sign extension (or lack thereof) for the syscall
storage_obj_seek. Updates the general rules of arguments for syscalls to
use signed 3

syscall storage_obj_seek: fix sign extension

Fixes problem with sign extension (or lack thereof) for the syscall
storage_obj_seek. Updates the general rules of arguments for syscalls to
use signed 32-bit parameters when a signed parameter is needed.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU and FVP)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ltc: remove test related source files

Test related source files have not been built into OP-TEE image all the
time, so we remove them permanently.

Signed-off-by: Matt Ma <matt.ma@linaro.org>
Review

ltc: remove test related source files

Test related source files have not been built into OP-TEE image all the
time, so we remove them permanently.

Signed-off-by: Matt Ma <matt.ma@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

travis: build all FS code in 64-bit mode

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

Fix 64-bit compile error in tee_sql_fs.c

$ make PLATFORM=hikey CFG_SQL_FS=y CFG_ARM64_core=y
[snip]
core/tee/tee_sql_fs.c: In function ‘sql_fs_read’:
core/tee/tee_sql_fs.c:740:41: error: comparison

Fix 64-bit compile error in tee_sql_fs.c

$ make PLATFORM=hikey CFG_SQL_FS=y CFG_ARM64_core=y
[snip]
core/tee/tee_sql_fs.c: In function ‘sql_fs_read’:
core/tee/tee_sql_fs.c:740:41: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if ((fdp->pos + len) < len || fdp->pos > fdp->meta.length)
^
cc1: all warnings being treated as errors

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: bugfix reading beyond end of file

Bugfix for reading beyond end of a persistent object when the file
position is larger the the size of the data stream. Applies to both REE
FS and SQL FS.

Rev

core: bugfix reading beyond end of file

Bugfix for reading beyond end of a persistent object when the file
position is larger the the size of the data stream. Applies to both REE
FS and SQL FS.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ta-dev-kit: Remove use of platform_flags.mk

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU)
Reviewed-by: Jerome Forissier <jerome.forissier

ta-dev-kit: Remove use of platform_flags.mk

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org> (QEMU)
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

plat-rpi3: Initial support for RPi3

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro

plat-rpi3: Initial support for RPi3

Signed-off-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

storage: SQL FS concurrency

Allow concurrent access by multi-session/multi-instance TA.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@lin

storage: SQL FS concurrency

Allow concurrent access by multi-session/multi-instance TA.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

storage: REE FS concurrency

Allow concurrent access by multi-session/multi-instance TA.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@lin

storage: REE FS concurrency

Allow concurrent access by multi-session/multi-instance TA.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

storage: protect TA directory with a mutex

There is a race condition in the code that creates and deletes trusted
storage. If multiple threads invoke a multi-session TA to create and
delete differen

storage: protect TA directory with a mutex

There is a race condition in the code that creates and deletes trusted
storage. If multiple threads invoke a multi-session TA to create and
delete different files (such as xtest 6016), the following can occur:

Thread 1 (create file1) | Thread 2 (delete file2)
|
| unlink("/TA_dir/file2");
mkdir("/TA_dir"); |
| rmdir("/TA_dir");
create("/TA_dir/file1"); |
=> ENOENT |

Add a mutex to prevent this race condition.

Note: the bug is currently not triggered by xtest 1016 because the test
is run for RPMB FS only, and because directory operations are no-ops in
the RPMB implementation. The fix will be needed when enabling single-TA
concurrency with the REE and SQL backends.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

travis: be quieter when checking coding rules

Reduce verbosity of checkpatch.pl while still allowing warnings and
errors.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by:

travis: be quieter when checking coding rules

Reduce verbosity of checkpatch.pl while still allowing warnings and
errors.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

travis: improve the display of commits

When running checkpatch.pl, show the abbreviated SHA1 and the commit
subject instead of the full SHA1 only.

Signed-off-by: Jerome Forissier <jerome.forissier@

travis: improve the display of commits

When running checkpatch.pl, show the abbreviated SHA1 and the commit
subject instead of the full SHA1 only.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

travis: also check whole diff when pull request has several commits

Address a common situation when a pull request is reviewed. Suppose a
PR contains one commit, which causes checkpatch warnings. Th

travis: also check whole diff when pull request has several commits

Address a common situation when a pull request is reviewed. Suppose a
PR contains one commit, which causes checkpatch warnings. The author
pushes a new commit to fix the warnings. Travis will still complain
because it checks every commit in the PR, and the author has no way to
make sure the fix is actually correct.
To alleviate this problem, add a call to checkpatch that will process
the whole diff added by the PR branch to the target branch (i.e., git
diff HEAD^1...HEAD^2). In the above example, the Travis status will
still be fail until all commits actually comply with the rules, but the
PR author can check that his/her contribution is OK as a whole.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

core: arm: add no-map property to res mem

Adds a "no-map" property to the optee@xxx node. Before this patch the node
looked like:
optee@78000000 {
reg = <0x78000000 0x800000>;
};
With this patch

core: arm: add no-map property to res mem

Adds a "no-map" property to the optee@xxx node. Before this patch the node
looked like:
optee@78000000 {
reg = <0x78000000 0x800000>;
};
With this patch it becomes:
optee@78000000 {
reg = <0x78000000 0x800000>;
no-map;
};

This makes it clear to the Linux kernel that it must leave it to the
OP-TEE driver to map the reserved memory.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

hikey: increase heap size from 24 KiB to 32 KiB

The current heap size is not enough to run `xtest` when the newly
added SQLite FS is enabled (CFG_SQL_FS=y). Let's increase it a bit.

Signed-off-by:

hikey: increase heap size from 24 KiB to 32 KiB

The current heap size is not enough to run `xtest` when the newly
added SQLite FS is enabled (CFG_SQL_FS=y). Let's increase it a bit.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

tee_mm_get_pool_stats(): fix reset of max_allocated

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklan

tee_mm_get_pool_stats(): fix reset of max_allocated

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add heap allocation failure statistics

Adds the following statistics to the heap allocator and export then via
the static TA `core/arch/arm/sta/stats.c` (all of them can be reset):

- num_all

core: add heap allocation failure statistics

Adds the following statistics to the heap allocator and export then via
the static TA `core/arch/arm/sta/stats.c` (all of them can be reset):

- num_alloc_fail: number of calls to malloc()/calloc()/realloc() that
returned NULL
- biggest_alloc_fail: the size in bytes of the largest allocation
request that resulted in a failure
- biggest_alloc_fail_used: the number of bytes that were allocated at
that time

Depends on CFG_WITH_STATS=y.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...