core: beautify generic_entry_a32.S

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere

core: beautify generic_entry_a32.S

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)

show more ...

core: fix generic ARMv7/AArch32 boot against SMP

This change flushes cache before primary releases secondary core
to insure they find the right data in memory.

Case CFG_PL310_LOCK: wait all seconda

core: fix generic ARMv7/AArch32 boot against SMP

This change flushes cache before primary releases secondary core
to insure they find the right data in memory.

Case CFG_PL310_LOCK: wait all secondary cores have completed their
inits before locking PL310 lines.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)

show more ...

core: fix generic ARMv7/AArch32 boot against PL310

Follow ARM recommendation for PL310 outer cache maintenance.
- caches invalidate: invalidate L2 then L1.
- caches flush: clean L1 then flush L2, th

core: fix generic ARMv7/AArch32 boot against PL310

Follow ARM recommendation for PL310 outer cache maintenance.
- caches invalidate: invalidate L2 then L1.
- caches flush: clean L1 then flush L2, then flush L1.

To ease main sequence, define macros of cache operations.

inval/flush_cache_vrange() with PL310 in early boot requires va=pa.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)

show more ...

core: fix pager against SMP on non A-TF booted op-tee

plat_cpu_reset_late() must be moved to the unpaged sections. It is
called by secondary core when entering core after primary core inits
are done

core: fix pager against SMP on non A-TF booted op-tee

plat_cpu_reset_late() must be moved to the unpaged sections. It is
called by secondary core when entering core after primary core inits
are done, hence 'init' section may have been unmapped.

Cleanup: move plat_cpu_reset_early/_late() out of generic_entry_a32.S.

Change CFG_PL310_LOCKED sequence: flush content instead of rude
full invalidation. This is required since core inits may write outside
TEE RAM and PL310 must not discard new content.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)

show more ...

plat-stm: fix flavor 'cannes'

Fixes: 8cd89706f19c ("plat-stm: beautify platform config")

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@l

plat-stm: fix flavor 'cannes'

Fixes: 8cd89706f19c ("plat-stm: beautify platform config")

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

scripts: add wrapper script for checkpatch

Add auxilary wrapper for convenient check of commit/
changes in staging area/multiple commits with checkpatch.pl
Put common functions for .travis.yml and c

scripts: add wrapper script for checkpatch

Add auxilary wrapper for convenient check of commit/
changes in staging area/multiple commits with checkpatch.pl
Put common functions for .travis.yml and checkpatch.sh into a
separate file

Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core_mmu.h: align comments with code

Comment mentions MEM_AREA_NS_SHM which does not exists. Instead
there are MEM_AREA_NSEC_SHM.
Also there was different order of memory areas in comment and
in enu

core_mmu.h: align comments with code

Comment mentions MEM_AREA_NS_SHM which does not exists. Instead
there are MEM_AREA_NSEC_SHM.
Also there was different order of memory areas in comment and
in enum definition.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

doc: update README.md, add info about VirtFS

Add info about using VirtFS folder sharing feature in QEMU/QEMUv8

Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
Reviewed-by: Joakim Bech <joakim

doc: update README.md, add info about VirtFS

Add info about using VirtFS folder sharing feature in QEMU/QEMUv8

Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

mk/checkconf.mk: allow spaces and double quotes in CFG_ config variables

Fixes issues with the check-conf-h and check-conf-mk functions, which
would error out or generate incorrect output on strings

mk/checkconf.mk: allow spaces and double quotes in CFG_ config variables

Fixes issues with the check-conf-h and check-conf-mk functions, which
would error out or generate incorrect output on strings containing spaces
and/or double quotes.

The single quote character is used in the shell commands that builds
the list of values, instead of the double quote, so that there is no
conflict with double quotes appearing in the variables themselves. As a
consequence, single quotes cannot appear anywhere in the output string.
So remove the comments that contained quotes, and which were not that
useful anyway.

Test case:

$ grep CFG_TEST core/arch/arm/plat-vexpress/conf.mk
CFG_TEST1 ?= "test string"
CFG_TEST2 ?= test string
CFG_TEST3 ?= "test"
CFG_TEST4 ?= test
$ make -s
$ grep CFG_TEST out/arm-plat-vexpress/conf.mk
CFG_TEST1="test string"
CFG_TEST2=test string
CFG_TEST3="test"
CFG_TEST4=test
$ grep CFG_TEST out/arm-plat-vexpress/include/generated/conf.h
#define CFG_TEST1 "test string"
#define CFG_TEST2 test string
#define CFG_TEST3 "test"
#define CFG_TEST4 test

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Zeng Tao <prime.zeng@hisilicon.com>

show more ...

core: TA private memory does not include the memref parameters

This change limits ta_private_vmem_end to TA segments defined when
TA is loaded.

Currently 'ta_private_vmem_end' only used to prevent

core: TA private memory does not include the memref parameters

This change limits ta_private_vmem_end to TA segments defined when
TA is loaded.

Currently 'ta_private_vmem_end' only used to prevent a TA from exposing
its code/data/stack memory to another TA it invokes. A shared memory
buffer passed as TA invocation parameter is obviously not inside the TA
private memory an can be exposed to another TA.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu, GP tests)

show more ...

core: SQL FS: use new RPC directory functions

Uses the new RPC functions for directory listings instead of the old
legacy version.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested

core: SQL FS: use new RPC directory functions

Uses the new RPC functions for directory listings instead of the old
legacy version.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU, FVP)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: REE FS: use new RPC directory functions

Uses the new RPC functions for directory listings instead of the old
legacy version.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed

core: REE FS: use new RPC directory functions

Uses the new RPC functions for directory listings instead of the old
legacy version.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: FS: remove FOP access

Removes all calls to FOP access and the FOP itself.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: FS: FOP rename checks for existing file

Simplify renaming of file by moving the check for existing files into the
rename FOP.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signe

core: FS: FOP rename checks for existing file

Simplify renaming of file by moving the check for existing files into the
rename FOP.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: FS: remove rmdir and mkdir

Removes explicit rmdir and mkdir. It's not needed for SQL FS and RPMB
FS. REE FS does rmdir and mkdir when needed directly inside
tee-supplicant instead.

Reviewed-b

core: FS: remove rmdir and mkdir

Removes explicit rmdir and mkdir. It's not needed for SQL FS and RPMB
FS. REE FS does rmdir and mkdir when needed directly inside
tee-supplicant instead.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

libutee: remove unused TEE_ERROR_FILE_NOT_FOUND

Removes unused proprietary TEE_Result code TEE_ERROR_FILE_NOT_FOUND.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens

libutee: remove unused TEE_ERROR_FILE_NOT_FOUND

Removes unused proprietary TEE_Result code TEE_ERROR_FILE_NOT_FOUND.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: RPMB FS: consistent error codes

* Updates error code from rpmb_fs_mkdir() to TEE_ERROR_ITEM_NOT_FOUND
when a directory is empty.
* Replaces error code TEE_ERROR_FILE_NOT_FOUND with
TEE_ERR

core: RPMB FS: consistent error codes

* Updates error code from rpmb_fs_mkdir() to TEE_ERROR_ITEM_NOT_FOUND
when a directory is empty.
* Replaces error code TEE_ERROR_FILE_NOT_FOUND with
TEE_ERROR_ITEM_NOT_FOUND

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Remove legacy tee_common_unpg.h

Removes legacy file core/include/kernel/tee_common_unpg.h
and updates with new types etc as needed.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Teste

Remove legacy tee_common_unpg.h

Removes legacy file core/include/kernel/tee_common_unpg.h
and updates with new types etc as needed.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix mem leak in tee_fs_rpc_new_closedir()

Fixes memory leakage in tee_fs_rpc_new_closedir().

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklan

core: fix mem leak in tee_fs_rpc_new_closedir()

Fixes memory leakage in tee_fs_rpc_new_closedir().

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix buffer overrun in syscall_log()

Fixes out of bounds update of the buffer used for user TA logging.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklande

core: fix buffer overrun in syscall_log()

Fixes out of bounds update of the buffer used for user TA logging.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: FS: change to new FOP interface

Changes the FOP interface to use TEE_Result as the primary return code to
harmonize better with the rest of the code.

Reviewed-by: Joakim Bech <joakim.bech@lin

core: FS: change to new FOP interface

Changes the FOP interface to use TEE_Result as the primary return code to
harmonize better with the rest of the code.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: SQL FS: prepare for new FOP interface

Prepares SQL FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etien

core: SQL FS: prepare for new FOP interface

Prepares SQL FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: REE FS: prepare for new FOP interface

Prepares REE FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etien

core: REE FS: prepare for new FOP interface

Prepares REE FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: RPMB FS: prepare for new FOP interface

Prepares RPMB FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <eti

core: RPMB FS: prepare for new FOP interface

Prepares RPMB FS implementation for the (coming) new FOP interface.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: FS: remove unused legacy RPC functions

Removes unused legacy wrapper functions for FS RPC operations.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <

core: FS: remove unused legacy RPC functions

Removes unused legacy wrapper functions for FS RPC operations.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...