core: remove vm_info_get_user_range()

Removes the now unused function vm_info_get_user_range().

Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260/pager/GP)
Reviewed-by: Etienne Carri

core: remove vm_info_get_user_range()

Removes the now unused function vm_info_get_user_range().

Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260/pager/GP)
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: document struct user_ta_ctx

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

core: mm: support map update to active context

Adds support in vm_map() to update an active context. vm_set_prot() is
also updated, but still requires a call to tee_mmu_set_ctx() for the
changes to

core: mm: support map update to active context

Adds support in vm_map() to update an active context. vm_set_prot() is
also updated, but still requires a call to tee_mmu_set_ctx() for the
changes to be effective.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_mmu.c: add internal umap_remove_region()

Adds an internal helper function umap_remove_region() to remove and free
a region from a struct vm_info.

Reviewed-by: Etienne Carriere <etienne.ca

core: tee_mmu.c: add internal umap_remove_region()

Adds an internal helper function umap_remove_region() to remove and free
a region from a struct vm_info.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: remove tee_mmu_map_init()

Removes tee_mmu_map_init() and adds the map_kinit() call to
vm_info_init().

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <j

core: remove tee_mmu_map_init()

Removes tee_mmu_map_init() and adds the map_kinit() call to
vm_info_init().

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: load_elf(): use vm_set_prot()

Rewrite load_elf() to use vm_set_prot() to finalize the TA mapping
instead of remapping the TA again.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

core: load_elf(): use vm_set_prot()

Rewrite load_elf() to use vm_set_prot() to finalize the TA mapping
instead of remapping the TA again.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add vm_set_prot()

Adds vm_set_prot() to update the protection bits of an already registered
region.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <

core: add vm_set_prot()

Adds vm_set_prot() to update the protection bits of an already registered
region.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: more flexible ta mapping

Replaces the current fixed array of TA map entries where some indexes
have a special meaning. The new structures and functions dealing with this
has a vm_ prefix inste

core: more flexible ta mapping

Replaces the current fixed array of TA map entries where some indexes
have a special meaning. The new structures and functions dealing with this
has a vm_ prefix instead of the old tee_mmu_ prefix.

struct tee_ta_region is replaced by struct vm_region, which is now
stored in a linked list using the new TEE_MATTR-bits to identify special
regions.

struct tee_mmu_info is replaced by vm_info, which now keeps the head of
the linked list of regions.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add new TEE_MATTR defines

Adds TEE_MATTR_EPHEMERAL to tag TA mappings which are only used during a
single call (open session or invoke parameters).

Adds TEE_MATTR_PERMANENT to tag TA mappings

core: add new TEE_MATTR defines

Adds TEE_MATTR_EPHEMERAL to tag TA mappings which are only used during a
single call (open session or invoke parameters).

Adds TEE_MATTR_PERMANENT to tag TA mappings that must not be removed
(kernel mappings while in user mode).

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_mmu_types.h: define TEE_MATTR_* with BIT

Uses the BIT() macro to define the TEE_MATTR_* macros.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <

core: tee_mmu_types.h: define TEE_MATTR_* with BIT

Uses the BIT() macro to define the TEE_MATTR_* macros.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: mobj_seccpy_shm: remove unused pgdir_offset

Removes assignment of the otherwise unused pgdir_offset field in struct
mobj_seccpy_shm and the field itself.

Reviewed-by: Etienne Carriere <etienn

core: mobj_seccpy_shm: remove unused pgdir_offset

Removes assignment of the otherwise unused pgdir_offset field in struct
mobj_seccpy_shm and the field itself.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_mmu_add_rwmem(): remove pgdir_offset

Removes the pgdir_offset parameter from the tee_mmu_add_rwmem(). The
function is only called from one place and then with pgdir_offset as -1.

Reviewed

core: tee_mmu_add_rwmem(): remove pgdir_offset

Removes the pgdir_offset parameter from the tee_mmu_add_rwmem(). The
function is only called from one place and then with pgdir_offset as -1.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: REE FS: temporary block allocation

Large memory allocations with malloc() can fail due to a fragmented
heap. This is especially a problem when configured with pager as the
heap is kept as smal

core: REE FS: temporary block allocation

Large memory allocations with malloc() can fail due to a fragmented
heap. This is especially a problem when configured with pager as the
heap is kept as small as possible in that configuration for obvious
reasons.

This patch allocates the temporary block needed for reading and writing
in REE FS tee_pager_alloc() instead when the pager is enabled.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: tee_tadb_ta_read(): reduce tmp buffer

Large memory allocations with malloc() can fail due to a fragmented
heap. The easiest way to avoid such failures is obviously to allocate
smaller buffers.

core: tee_tadb_ta_read(): reduce tmp buffer

Large memory allocations with malloc() can fail due to a fragmented
heap. The easiest way to avoid such failures is obviously to allocate
smaller buffers.

Reduces the size of the temporary buffer used in tee_tadb_ta_read() when
skipping over bytes in the payload. Instead of max 4k use 256 bytes.
Impact on performance should be minimal as not much data are skipped in
the payload.

Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

Documentation: add abort_dumps.rst

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

README.md: fix broken link to MAINTAINERS file

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: Ohad Netz <ohad.netz@arm.com>
Reviewed-by: Jens Wiklander <jens.wiklander@li

README.md: fix broken link to MAINTAINERS file

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reported-by: Ohad Netz <ohad.netz@arm.com>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

doc: add a note on PRNG weakness

Adds a note on the software PRNG weakness in the porting guidelines.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wi

doc: add a note on PRNG weakness

Adds a note on the software PRNG weakness in the porting guidelines.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: arm: imx7d: add low power cpuidle support

Add Low power cpuidle support.

The hard point is two cores could runs into low power idle
at any time. So need to do protection. Here
we could not us

core: arm: imx7d: add low power cpuidle support

Add Low power cpuidle support.

The hard point is two cores could runs into low power idle
at any time. So need to do protection. Here
we could not use cpu_spin_lock, because
we need lock in c code and unlock in asm code, and in asm
code, SMP is turned off.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

core: imx: use a dedicated sub.mk for pm

Use a dedicated sub.mk for the directory holding power related
source code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jerome Forissier <jerome

core: imx: use a dedicated sub.mk for pm

Use a dedicated sub.mk for the directory holding power related
source code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: imx: implement psci_system_off

Implement psci_system_off.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wi

core: imx: implement psci_system_off

Implement psci_system_off.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: syscall_authenc_enc_final() initialize tlen

Fixes problem with possibly leaking uninitialized stack content via
tlen.

Fixes: https://github.com/OP-TEE/optee_os/issues/2214
Reviewed-by: Jerome

core: syscall_authenc_enc_final() initialize tlen

Fixes problem with possibly leaking uninitialized stack content via
tlen.

Fixes: https://github.com/OP-TEE/optee_os/issues/2214
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ltc: ctr: improve performance

When accel_ctr_encrypt() is not used, accel_ecb_encrypt() is used via
ecb_encrypt() instead. The accel_ecb_encrypt() is frequently called at
every single block process.

ltc: ctr: improve performance

When accel_ctr_encrypt() is not used, accel_ecb_encrypt() is used via
ecb_encrypt() instead. The accel_ecb_encrypt() is frequently called at
every single block process. VFP assembly code called from the
accel_ecb_encrypt() is protected by
tomcrypt_arm_neon_enable()/disable(). FIQ enable/disable and VFP
register save/restore (64bitx32 registers!) to/from memory are done in
the tomcrypt_arm_neon_enable()/disable(). These overhead exist in each
single block process cause the degradation of system performance
eventually. Cases where h/w accelerated AES-CTR did not show any effects
or showed less performance than pure software processing have been
observed.

This patch resolves the issue by increasing utilization rate of
accel_ctr_encrypt().

Signed-off-by: Tetsuya Yoshizaki <yoshizaki.tetsuya@socionext.com>
Signed-off-by: Victor Chong <victor.chong@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

README.md: Mediatek MT8173 EVB is not maintained anymore

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

MAINTAINERS: mark Mediatek MT8173 EVB as Orphan

Mediatek MT8173 EVB is not used on a regular basis for OP-TEE by anyone
we know, so mark is as Orphan. I'm not getting rid of the platform code
becaus

MAINTAINERS: mark Mediatek MT8173 EVB as Orphan

Mediatek MT8173 EVB is not used on a regular basis for OP-TEE by anyone
we know, so mark is as Orphan. I'm not getting rid of the platform code
because is is small and quite trivial, so there is not much to be
gained by removing it.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

ci: .travis.yml: track latest manifest again

Now that build files support GCC 4.9 [1] and "make check" supports the
buildroot environment [2], revert commit 793884e19284
("ci: .travis.yml: clone sta

ci: .travis.yml: track latest manifest again

Now that build files support GCC 4.9 [1] and "make check" supports the
buildroot environment [2], revert commit 793884e19284
("ci: .travis.yml: clone stable version (3.0.0)") and set
COMPILE_LEGACY=y to instruct the build system to download and use the
legacy compiler (gcc-linaro-4.9-2015.02-3-x86_64_arm-linux-gnueabihf).

[1] commit 92582b57dd45 ("Support legacy compiler")
https://github.com/OP-TEE/build/commit/92582b57dd45
[2] commit 4763adc5b75a ("qemu-check.exp: fix expected prompts")
https://github.com/OP-TEE/build/commit/4763adc5b75a

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...