core: driver: generic resources for crypto cipher driver

Add a generic cryptographic Cipher driver interface connecting
TEE Crypto generic APIs to HW driver interface

To make Cipher HW driver gener

core: driver: generic resources for crypto cipher driver

Add a generic cryptographic Cipher driver interface connecting
TEE Crypto generic APIs to HW driver interface

To make Cipher HW driver generic and to reduce the amount of function
parameters, add structure data for the initialization and update
function driver call.
Checks the Cipher operation's parameter in the generic part before
calling the HW driver.

Signed-off-by: Cedric Neveux <cedric.neveux@nxp.com>
Signed-off-by: Clement Faure <clement.faure@nxp.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

ta: pkcs11: fix token flags as per specification

Fix the token flags position that are expected to match the PKCS#11
specification and did not.

Fixes: a67dc424ff106 ("ta: pkcs11: API for slot/token

ta: pkcs11: fix token flags as per specification

Fix the token flags position that are expected to match the PKCS#11
specification and did not.

Fixes: a67dc424ff106 ("ta: pkcs11: API for slot/token information")
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in select_va_in_range()

Fixes possible overflow when calculating begin_va and end_va in
select_va_in_range().

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerom

core: fix overflow in select_va_in_range()

Fixes possible overflow when calculating begin_va and end_va in
select_va_in_range().

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in vm_unmap()

Fixes a possible overflow in vm_unmap() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@fo

core: fix overflow in vm_unmap()

Fixes a possible overflow in vm_unmap() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add overflow guard in system_unmap()

Adds an early overflow guard in system_unmap() against large va or sz
values.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Foriss

core: add overflow guard in system_unmap()

Adds an early overflow guard in system_unmap() against large va or sz
values.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: wipe user data in system_derive_ta_unique_key()

Before system_derive_ta_unique_key() returns wipe the supplied user data
from the heap as a precaution.

Reviewed-by: Joakim Bech <joakim.bech@l

core: wipe user data in system_derive_ta_unique_key()

Before system_derive_ta_unique_key() returns wipe the supplied user data
from the heap as a precaution.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add overflow guard in system_set_prot()

Adds an early overflow guard in system_set_prot() against large va or sz
values.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome

core: add overflow guard in system_set_prot()

Adds an early overflow guard in system_set_prot() against large va or sz
values.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in merge_vm_range()

Fixes a possible overflow in merge_vm_range() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissie

core: fix overflow in merge_vm_range()

Fixes a possible overflow in merge_vm_range() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in tee_pager_merge_um_region()

Fixes a possible overflow in tee_pager_merge_um_region() where len is a
very large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Review

core: fix overflow in tee_pager_merge_um_region()

Fixes a possible overflow in tee_pager_merge_um_region() where len is a
very large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in split_vm_range()

Fixes a possible overflow in split_vm_range() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissie

core: fix overflow in split_vm_range()

Fixes a possible overflow in split_vm_range() where len is a very large
number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix typo in system_set_prot()

Fixes a typo in system_set_prot() where a "," was used instead of a ";".
This fix should not change the behaviour of the function.

Reviewed-by: Joakim Bech <joak

core: fix typo in system_set_prot()

Fixes a typo in system_set_prot() where a "," was used instead of a ";".
This fix should not change the behaviour of the function.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in va_range_is_contiguous()

Fixes a possible overflow in va_range_is_contiguous() where len is a
very large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by:

core: fix overflow in va_range_is_contiguous()

Fixes a possible overflow in va_range_is_contiguous() where len is a
very large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in binh_copy_to()

Fixes overflows in binh_copy_to() when num_bytes or offs_bytes are very
large numbers.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome For

core: fix overflow in binh_copy_to()

Fixes overflows in binh_copy_to() when num_bytes or offs_bytes are very
large numbers.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in read_uncompressed()

Fixes overflow in read_uncompressed() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome

core: fix overflow in read_uncompressed()

Fixes overflow in read_uncompressed() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in buf_ta_read()

Fixes overflow in buf_ta_read() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <

core: fix overflow in buf_ta_read()

Fixes overflow in buf_ta_read() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix overflow in ree_fs_ta_read()

Fixes overflow in ree_fs_ta_read() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Foris

core: fix overflow in ree_fs_ta_read()

Fixes overflow in ree_fs_ta_read() where the len parameter is a very
large number.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix potential overflow in system_map_ta_binary()

Fixes potential overflows when calculating required sizes for mapping a
part of a fobj.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Revi

core: fix potential overflow in system_map_ta_binary()

Fixes potential overflows when calculating required sizes for mapping a
part of a fobj.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix handle return in system_open_ta_binary()

Prior to this patch system_open_ta_binary() was not updating the
params[0].value.a out parameter used to carry a handle of the opened
binary. Fix t

core: fix handle return in system_open_ta_binary()

Prior to this patch system_open_ta_binary() was not updating the
params[0].value.a out parameter used to carry a handle of the opened
binary. Fix this by assigning the value to the handle to
params[0].value.a.

Note that if only one binary is opened at a time the handle will be 0
and ldelf will still work even without this fix.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: fix potential overflow in system_map_zi()

Fixes a potential overflow when calculating required page size for a
fobj allocation. This is fixed by using the new ROUNDUP_DIV() macro
instead of ro

core: fix potential overflow in system_map_zi()

Fixes a potential overflow when calculating required page size for a
fobj allocation. This is fixed by using the new ROUNDUP_DIV() macro
instead of rounding up and the dividing.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

util.h: add ROUNDUP_DIV(x, y) macro

Adds the ROUNDUP_DIV(x, y) macro which Rounds up to the nearest multiple
of y and then divides by y. Safe against overflow, y has to be a
multiple of 2 just as in

util.h: add ROUNDUP_DIV(x, y) macro

Adds the ROUNDUP_DIV(x, y) macro which Rounds up to the nearest multiple
of y and then divides by y. Safe against overflow, y has to be a
multiple of 2 just as in the other two ROUNDUP*() macros.

This macro is intended to be used to convert from "number of bytes" to
"number of pages" or similar units. Example:
num_pages = ROUNDUP_DIV(num_bytes, SMALL_PAGE_SIZE);

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: parameter check in system_rng_reseed()

Removes confusing comment in system_rng_reseed(). Removes the max limit
on input buffer size, that's handled inside crypto_rng_add_event(). Also
checks t

core: parameter check in system_rng_reseed()

Removes confusing comment in system_rng_reseed(). Removes the max limit
on input buffer size, that's handled inside crypto_rng_add_event(). Also
checks that the supplied buffer isn't NULL.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: gprof: check that PC sampling is idle before starting

In gprof_start_pc_sampling() check that PC sampling isn't started yet,
or have been stopped before starting again. This avoids memory leak

core: gprof: check that PC sampling is idle before starting

In gprof_start_pc_sampling() check that PC sampling isn't started yet,
or have been stopped before starting again. This avoids memory leakage
by s->sbuf being overwritten with a pointer to a new buffer.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

drivers: bnxt: add overflow check in bnxt_copy_crash_dump()

Adds a check that offset + len doesn't overflow when checking that the
resulting size is still less than BNXT_CRASH_LEN.

Reviewed-by: Joa

drivers: bnxt: add overflow check in bnxt_copy_crash_dump()

Adds a check that offset + len doesn't overflow when checking that the
resulting size is still less than BNXT_CRASH_LEN.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

core: add overflow check in SHDR_GET_SIZE()

Adds overflow check in SHDR_GET_SIZE(), 0 which never can be a correct
size is returned in case of overflow.

Reviewed-by: Joakim Bech <joakim.bech@linaro

core: add overflow check in SHDR_GET_SIZE()

Adds overflow check in SHDR_GET_SIZE(), 0 which never can be a correct
size is returned in case of overflow.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
Reported-by: Bastien Simondi <bsimondi@netflix.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

mk/lib.mk: cleanup shared library link command

The command used to link shared libraries when CFG_ULIBS_SHARED=y is
slightly incorrect for two reasons:

1. The -L/-l arguments are passed before the

mk/lib.mk: cleanup shared library link command

The command used to link shared libraries when CFG_ULIBS_SHARED=y is
slightly incorrect for two reasons:

1. The -L/-l arguments are passed before the object files, when they
should normally be added after;

2. The shared libraries needed during the link are passed as files in
addition to being supplied with -L/-l. This is redundant, and is a
consequence of having the shared libraries in the prerequisites and
using $^. Therefore, filter out the .so files.

Signed-off-by: Jerome Forissier <jerome@forissier.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...