core: embed ldelf into tee core

Embeds the ldelf binary into TEE Core using the new script
scripts/gen_ldelf_hex.py.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens

core: embed ldelf into tee core

Embeds the ldelf binary into TEE Core using the new script
scripts/gen_ldelf_hex.py.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

pem_to_pub_c.py: Rework code to be more pythonic

Instances of open() were wrapped in with statements to ensure proper
closing of files even in the case of errors. This also improves
the readability

pem_to_pub_c.py: Rework code to be more pythonic

Instances of open() were wrapped in with statements to ensure proper
closing of files even in the case of errors. This also improves
the readability of the code.

Signed-off-by: Markus S. Wamser <markus.wamser@mixed-mode.de>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
[jf: add file name to commit subject and use imperative mood]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

pem_to_pub_c.py: Add sanity check for public exponent of TA signing key

This change fixes a potential security vulnerability.

The public exponent of the TA signing key is stored by OP-TEE OS as an

pem_to_pub_c.py: Add sanity check for public exponent of TA signing key

This change fixes a potential security vulnerability.

The public exponent of the TA signing key is stored by OP-TEE OS as an
unsigned 32-bit integer. While rarely seen in the wild, public exponents
that overflow this storage field exist. Although the C compiler usually
generates an overflow warning when such an exponent would be set, this
happens only once after the key was changed and is easily overlooked.
With this change the script throws an exception, notifying the user of the
unsuitable key.

Without the sanity check, such an unsuitable key would simply lead to
TA signature verification failures. However, if the public exponent e
is close to a multiple of 2^32, a small exponent attack to forge a
signature might be feasible.

Signed-off-by: Markus S. Wamser <markus.wamser@mixed-mode.de>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
[jf: add file name to commit subject]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

symbolize.py: add support to symbolize TA ftrace addresses

Add supoort to symbolize function graph addresses for instrumented TA.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Joak

symbolize.py: add support to symbolize TA ftrace addresses

Add supoort to symbolize function graph addresses for instrumented TA.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey960)

show more ...

scripts/symbolize.py: accept several spaces after "region"

User TA crash dumps were slightly modified to better align region
numbers. scripts/symbolize.py needs to be updated accordingly.

Fixes: db

scripts/symbolize.py: accept several spaces after "region"

User TA crash dumps were slightly modified to better align region
numbers. scripts/symbolize.py needs to be updated accordingly.

Fixes: dba5a1eab8af1 ("core: better align output of TA dump with many or big regions")
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

show more ...

scripts: re-indent Python scripts

Fixes the following warnings:

$ pycodestyle --version
2.5.0

$ pycodestyle scripts/*.py
scripts/bin_to_c.py:15:9: E117 over-indented
scripts/bin_to_c.py:34:9:

scripts: re-indent Python scripts

Fixes the following warnings:

$ pycodestyle --version
2.5.0

$ pycodestyle scripts/*.py
scripts/bin_to_c.py:15:9: E117 over-indented
scripts/bin_to_c.py:34:9: E117 over-indented
scripts/bin_to_c.py:37:17: E117 over-indented
scripts/bin_to_c.py:49:17: E117 over-indented
scripts/bin_to_c.py:50:25: E117 over-indented
scripts/bin_to_c.py:54:25: E117 over-indented
scripts/bin_to_c.py:56:25: E117 over-indented
scripts/bin_to_c.py:62:9: E117 over-indented

$ cd core/arch/arm/plat-stm32mp1/scripts; \
pycodestyle stm32image.py
stm32image.py:21:9: E117 over-indented
stm32image.py:27:9: E117 over-indented
stm32image.py:29:17: E117 over-indented
stm32image.py:39:9: E117 over-indented
stm32image.py:77:9: E117 over-indented
stm32image.py:84:17: E117 over-indented
stm32image.py:96:9: E117 over-indented
stm32image.py:100:9: E117 over-indented
stm32image.py:125:9: E117 over-indented
stm32image.py:140:9: E117 over-indented

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

trace: fix core id print if in non-atomic context

Make "?" print repetitive equivalent to number of digits needed to display
core id rather than extra spaces as it causes symbolize.py script parsing

trace: fix core id print if in non-atomic context

Make "?" print repetitive equivalent to number of digits needed to display
core id rather than extra spaces as it causes symbolize.py script parsing
failure for call stack addresses in case number of cores is greater than
10.

Also change symbolize.py to detect repetitive "?".

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

gen_hashed_bin.py: open file in binary mode

By default Python tries to open files in text mode. This is
okay for python2, because it uses 8-bit encoding.
But python3 tries to decode file as utf-8 en

gen_hashed_bin.py: open file in binary mode

By default Python tries to open files in text mode. This is
okay for python2, because it uses 8-bit encoding.
But python3 tries to decode file as utf-8 encoded and fails,
because it is a binary file.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

gen_ld_sects: call `print` as a function

With this change gen_ld_sects.py will be compatible with
python3.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.w

gen_ld_sects: call `print` as a function

With this change gen_ld_sects.py will be compatible with
python3.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

gen_hashed_bin: use integer division operator

Use // instead of /, so this script will be compatible
with both python2 and python3.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-b

gen_hashed_bin: use integer division operator

Use // instead of /, so this script will be compatible
with both python2 and python3.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...

checkpatch: do not check DTS files

DTS files may not conform to OP-TEE OS C-source coding style. This
change makes checkpatch script not the check DTS files.

Signed-off-by: Etienne Carriere <etienn

checkpatch: do not check DTS files

DTS files may not conform to OP-TEE OS C-source coding style. This
change makes checkpatch script not the check DTS files.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

scripts: bin_to_c.py

bin_to_c.py generates an ANSI-C source file from a binary image file.
The C source defines an unsigned byte array that stores the binary
data with a 64bit alignment constraint.

scripts: bin_to_c.py

bin_to_c.py generates an ANSI-C source file from a binary image file.
The C source defines an unsigned byte array that stores the binary
data with a 64bit alignment constraint.

The label of the array is provided as input argument to the script.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jerome.Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

ta_bin_to_c.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle ta_bin_to_c.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a ta_bin_to

ta_bin_to_c.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle ta_bin_to_c.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a ta_bin_to_c.py.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

tee_bin_parser.py: fix issues reported by pycodestyle

Fixes issues reported by: pycodestyle tee_bin_parser.py.
Patch obtained by running: autopep8 -i tee_bin_parser.py.

Signed-off-by: Jerome Foriss

tee_bin_parser.py: fix issues reported by pycodestyle

Fixes issues reported by: pycodestyle tee_bin_parser.py.
Patch obtained by running: autopep8 -i tee_bin_parser.py.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

symbolize.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle symbolize.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a symbolize.py

symbolize.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle symbolize.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a symbolize.py (autopep8
v1.4.3).
In addition, add missing 'r' (raw string) in regular expressions.
pycodestyle complains about invalid escape sequences otherwise.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

sign.py: fix issues reported by pycodestyle

Adds missing blank line.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

pem_to_pub_c.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle pem_to_pub_c.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a pem_to_

pem_to_pub_c.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle pem_to_pub_c.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a pem_to_pub_c.py.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

mem_usage.py: fix issues reported by pycodestyle

Fixes issues reported by: pycodestyle mem_usage.py.
Patch obtained by running: autopep8 -i -a mem_usage.py.

Signed-off-by: Jerome Forissier <jerome.

mem_usage.py: fix issues reported by pycodestyle

Fixes issues reported by: pycodestyle mem_usage.py.
Patch obtained by running: autopep8 -i -a mem_usage.py.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

gen_ld_sects.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle gen_ld_sects.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i gen_ld_sects.

gen_ld_sects.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle gen_ld_sects.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i gen_ld_sects.py.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

gen_hashed_bin.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle gen_hashed_bin.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a gen

gen_hashed_bin.py: fix issues reported by pycodestyle and re-indent

Fixes issues reported by: pycodestyle gen_hashed_bin.py and re-indent
(4 spaces).
Patch obtained by running: autopep8 -i -a -a gen_hashed_bin.py.
In addition, remove a few print lines that were commented out.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

scripts/symbolize.py: be more specific when matching stack addresses

Use a more specific regular expression for call stack addresses so that
the script will not attempt to resolve any hexadecimal nu

scripts/symbolize.py: be more specific when matching stack addresses

Use a more specific regular expression for call stack addresses so that
the script will not attempt to resolve any hexadecimal number encountered
in the middle of a message.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

show more ...

auto-locate checkpatch

Try to locate checkpatch.pl in typical location(s) if environment
variable CHECKPATCH is not set.
The launch script first tries to find checkpatch.pl on the path,
next it chec

auto-locate checkpatch

Try to locate checkpatch.pl in typical location(s) if environment
variable CHECKPATCH is not set.
The launch script first tries to find checkpatch.pl on the path,
next it checks typical locations for linux headers, finally it
tries to locate linux sources used for OP-TEE in with QEMU.
The first match is used as the checkpatch instance to be invoked.

Signed-off-by: Markus S. Wamser <markus.wamser@mixed-mode.de>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

scripts/symbolize.py: add help text

Document how the binutils tools (addr2line etc.) are found.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wikla

scripts/symbolize.py: add help text

Document how the binutils tools (addr2line etc.) are found.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

show more ...

symbolize: use CROSS_COMPILE directive if available

Get CROSS_COMPILE prefix directive if defined in the environment.
If CROSS_COMPILE is not defined, default to aarch64-linux-gnu- or
arm-linux-gnue

symbolize: use CROSS_COMPILE directive if available

Get CROSS_COMPILE prefix directive if defined in the environment.
If CROSS_COMPILE is not defined, default to aarch64-linux-gnu- or
arm-linux-gnueabihf- as done prior this change according to the
architecture read from the ELF file.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

show more ...

scripts/symbolize.py: improve error message when a command is not found

It is a common mistake to invoke symbolize.py while not having the proper
toolchain is one's $PATH. The script then exits with

scripts/symbolize.py: improve error message when a command is not found

It is a common mistake to invoke symbolize.py while not having the proper
toolchain is one's $PATH. The script then exits with a stack dump that is
unhelpful to users.
Improve the situation by showing an explicit "command not found" message
and the name of the command.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

show more ...